Skip to content

Xelis 1.19 Compatibility #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Tritonn204 wants to merge 3 commits into
base: staging
Choose a base branch
from
Draft

Xelis 1.19 Compatibility #1227

Tritonn204 wants to merge 3 commits into from

Conversation

@Tritonn204
Copy link
Contributor

@Tritonn204 Tritonn204 commented Dec 8, 2025 •
edited
Loading

This PR migrates the Xelis integration in Stack to use the new FFI bindings for 1.19, which involved some straightforward (but still breaking) API changes and dep updates. This draft has been created to make the team aware of this pivot, while I re-sync to staging instead of main.

TODO:

  • Synchronize to staging
  • Walk back as many dep/build changes as possible (staging sync eliminated the need)
  • ID any points of confusion in the devops AFTER syncing to staging
  • Sync my xelis-dart-sdk work to Slixe's parallel updates to fix current Genesix
  • Re-solidify the Xelis FFI dep tree to use the real endpoints instead of my forks
  • Make PR for downstream cypherstack/xelis-flutter-ffi w/ new API
  • Document the noteworthy mentionables for the team on this thread to allow asynchronous sync-ups

@Tritonn204
Copy link
Contributor Author

Tritonn204 commented Dec 8, 2025

Dart >= 3.1.0 is required, but docs pin the Flutter version to 3.35.7 which ships with only Dart 3.9.2.

@julian-CStack
Copy link
Collaborator

julian-CStack commented Dec 17, 2025

Dart >= 3.1.0 is required, but docs pin the Flutter version to 3.35.7 which ships with only Dart 3.9.2.

Docs are out of date. Will fix today

julian-CStack
julian-CStack reviewed Dec 17, 2025
View reviewed changes
scripts/rust_version.sh
if rustup toolchain list | grep -q "1.85.1"; then
rustup default 1.85.1
if rustup toolchain list | grep -q "1.91.0"; then
rustup default 1.91.0
Copy link
Collaborator

@julian-CStack julian-CStack Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does everything else in stack that uses this version of rust work as expected?

I actually forget everything that does so so I am hesitant to change this without looking at what uses this and testing those libraries. Everything should work but we've had issues in the past with some libraries that break when using newer versions of rust...

julian-CStack
julian-CStack reviewed Dec 17, 2025
View reviewed changes
scripts/android/build_all.sh
(cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/android && ./build_all.sh )
(cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/android && ./build_all.sh )
# (cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/android && ./build_all.sh )
# (cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/android && ./build_all.sh )
Copy link
Collaborator

@julian-CStack julian-CStack Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these will need to be uncommented again. Probably known as this is still a draft PR but just in case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julian-CStack julian-CStack julian-CStack left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tritonn204 @julian-CStack