fix: make sure it.skip tests are still skipped (#16)

* add a spec

* add skip test to CI flow

* fix: confirm it.only still works

* update test

Author: bahmutov

.github/workflows/ci.yml

@@ -21,6 +21,23 @@ jobs:
           npx cypress-expect \
             --min-passing 5 --pending 0
 
+      - name: Run e2e skip tests without grep 🧪
+        run: |
+          npx cypress-expect \
+            --passing 1 --pending 2 \
+            --spec cypress/integration/skip-spec.js \
+            --config testFiles="skip-spec.js"
+
+      # all tests are pending
+      # because the grep tag is only used in "it.skip" tests
+      - name: Run e2e skip tests with grep 🧪
+        run: |
+          npx cypress-expect \
+            --spec cypress/integration/skip-spec.js \
+            --config testFiles="skip-spec.js" \
+            --env grep=pending \
+            --expect expects/pending.json
+
       # there should be 1 test with "hello" substring
       # and 3 other tests that will be pending
       - name: Run tests with "hello" 🧪

cypress/integration/skip-spec.js

@@ -0,0 +1,8 @@
+/// <reference types="cypress" />
+describe('tests that use .skip', () => {
+  it('works', () => {})
+
+  it.skip('is pending', () => {})
+
+  it.skip('is pending again', () => {})
+})

expects/pending.json

@@ -0,0 +1,7 @@
+{
+  "tests that use .skip": {
+    "works": "pending",
+    "is pending": "pending",
+    "is pending again": "pending"
+  }
+}

src/support.js

@@ -35,6 +35,9 @@ function cypressGrep() {
     // skip tests without grep string in their names
     return _it.skip(name, callback)
   }
+
+  // keep the "it.skip" the same as before
+  it.skip = _it.skip
 }
 
 module.exports = cypressGrep