Remove unused and broken code, add proxy for RPM (#458)

vars/dockerBuildArgs.groovy:
  Add passing DAOS_LAB_CA_FILE_URL environment variable.
  Remove some dead code, including some that required whitelisting
  in the groovy sandbox.

vars/packageBuildingPipelineDAOSTest.groovy:
  Fix typo found by spellcheck

Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>

Author: John E. Malmberg

vars/dockerBuildArgs.groovy

@@ -23,41 +23,6 @@ Integer num_proc() {
    *
    * config['parallel_build'] Whether to build in parallel (-j)
    *
-   * Repositories URLs are looked up via Jenkins environment variables.
-   * There are two environment variables that are put together to create
-   * a path to a repo.
-   *
-   * The first envronment variable is "REPOSITORY_URL" which is a common
-   * base URL that is used for all accesses to the repository.
-   *
-   * The rest of the URL for each specific repo is in additional environment
-   * varables with a name format of "DAOS_STACK_$(distro}${mod}_${type}_REPO".
-   *
-   * The ${mod} currently is "_DOCKER" for repositories that are for use
-   * with dockerfiles, and "" for generic repositories.
-   * DOCKER repositories are for both replacing the distro built in
-   * repositories and adding locally built packages.
-   *
-   * The ${distro} is currently one of "EL_7", "EL_8", "LEAP_15", and
-   * "UBUNTU_20_04".
-   *
-   * The ${type} is "LOCAL", "DEV", "STABLE", or "RELEASE".  This is passed
-   * in lower case in the "repo_type" parameter above.
-   *
-   * "LOCAL" type contains only locally built packages.  This is being phased
-   * out for all but Ubuntu.  It is a single repository.
-   *
-   * The other types are group repositories that combine both locally built
-   * package repositories with other repositories.
-   *
-   * The "DEV" type is group for experimental configurations for special PRs.
-   *
-   * The "STABLE" type is a group with locally build packages and also can
-   * contain other repositories.  It should not contain the default distro
-   * provided repositories.  It may also contain locally built signed
-   * release packages.
-   *
-   * The "RELEASE" type contains locally built signed released packages.
    *
    * Getting better repositories for Ubuntu is a work in progress.
    * For Ubuntu repository groups, that will need to be a URL that
@@ -69,27 +34,9 @@ String call(Map config = [:]) {
     Boolean add_repos = config.get('add_repos', true)
     Boolean deps_build = config.get('deps_build', false)
     Boolean parallel_build = config.get('parallel_build', false)
-    String daos_type = 'LOCAL'
-    String dist_type = 'GROUP'
-    String repo_alias = ''
-    String repo_mod = ''
-    String daos_arg = 'DAOS'
-    String dist_arg = 'DISTRO'
-
-    if (config.containsKey('repo_type')) {
-        daos_type = config['repo_type'].toString().toUpperCase()
-        if (daos_type != 'LOCAL') {
-            repo_mod = '_DOCKER'
-            dist_type = daos_type
-        }
-    }
 
     Map stage_info = parseStageInfo(config)
 
-    if (config.containsKey('distro')) {
-        stage_info['target'] = config['distro']
-    }
-
     // The docker agent setup and the provisionNodes step need to know the
     // UID that the build agent is running under.
     String ret_str = ' --build-arg NOBUILD=1 ' +
@@ -107,33 +54,8 @@ String call(Map config = [:]) {
         ret_str += ' --build-arg CB0=' + current_time.get(Calendar.WEEK_OF_YEAR)
     }
 
-    // No env.REPOSITORY_URL, no repos to add.
-    if (add_repos && env.REPOSITORY_URL) {
-        if (stage_info['target'] == 'ubuntu20.04') {
-            // Ubuntu repos curently only used for package building.
-            // When fully implemented it will probably be similar to above.
-            // And the URLS for will be for installing a list of repos.
-            // Details still to be worked out.
-            repo_alias = 'UBUNTU_20_04'
-            daos_arg = repo_alias
-        }
-        dist_repo = env["DAOS_STACK_${repo_alias}${repo_mod}_${dist_type}_REPO"]
-        daos_repo = env["DAOS_STACK_${repo_alias}_${daos_type}_REPO"]
-
-        // Only add the build args if a repo was found.
-        if (dist_repo || daos_repo) {
-            ret_str += ' --build-arg REPO_URL=' + env.REPOSITORY_URL
-            if (daos_repo) {
-                ret_str += " --build-arg REPO_${daos_arg}=" + daos_repo
-            }
-            if (dist_repo) {
-                ret_str += " --build-arg REPO_${dist_arg}=" + dist_repo
-            }
-        }
-    }
-
     // pass through env. var.s
-    ['REPO_FILE_URL', 'HTTP_PROXY', 'HTTPS_PROXY'].each { var ->
+    ['DAOS_LAB_CA_FILE_URL', 'REPO_FILE_URL', 'HTTP_PROXY', 'HTTPS_PROXY'].each { var ->
         if (env."$var") {
             ret_str += ' --build-arg ' + var + '="' + env."$var" + '"'
         }

vars/packageBuildingPipelineDAOSTest.groovy

@@ -228,7 +228,7 @@ void call(Map pipeline_args) {
                         }
                         agent { label 'lightweight' }
                         steps {
-                            sh label: 'Get submdule status',
+                            sh label: 'Get submodule status',
                                script: 'git submodule status'
                             checkoutScm url: 'https://github.com/daos-stack/packaging.git',
                                         checkoutDir: 'packaging-module',