Skip to content

Commit d7910e7

Browse files
committed
include not-saved file on removal of validate grpc prefix
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
1 parent f150b5a commit d7910e7

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

durabletask/internal/shared.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,6 @@ def get_default_host_address() -> str:
5151
return "localhost:4001"
5252

5353

54-
def validate_grpc_options(options: ChannelArgumentType):
55-
"""Validate that all gRPC options are valid. Mainly checking keys. Values can be string, int, float, bool and pointer"""
56-
for key, value in options:
57-
if not isinstance(key, str):
58-
raise ValueError(f"gRPC option key must be a string. Invalid key: {key}")
59-
if not all(key.startswith("grpc.") for key, _ in options):
60-
raise ValueError(
61-
f"All options keys must start with `grpc.`. Invalid options: {options}"
62-
)
63-
64-
6554
def get_grpc_channel(
6655
host_address: Optional[str],
6756
secure_channel: bool = False,
@@ -93,11 +82,6 @@ def get_grpc_channel(
9382
host_address = host_address[len(protocol) :]
9483
break
9584

96-
# Create the base channel
97-
if options is not None:
98-
# validate all options keys prefix starts with `grpc.`
99-
validate_grpc_options(options)
100-
10185
if secure_channel:
10286
channel = grpc.secure_channel(host_address, grpc.ssl_channel_credentials(), options=options)
10387
else:

0 commit comments

Comments
 (0)