Darktable crashes on import after March 12 merges

[wpferguson]

Just built latest master, built, opened an image, returned to darktable, crash.

Figured I'd bisect, so created fresh build. Tried to import a directory of 1500+ images and got 30 before a crash. I'm currently back into November of last year looking for a commit that will run, but each build crashes after importing a few images.

So I guess I need to find what has commits into last year that just got merged.

It corrupts the database, so I need to clean it after each crash.

[wpferguson]

Couldn't bisect it.

Back trace says it's a segfault in views/view.c:283, which is where it's removing modules from the view prior to changing views.

So, in fact, it might not be related to today's merges. Closing for now since I don't have a consistent reproducer.

[wpferguson]

Had to stop and cook dinner so I had a chance to replay everything in my head.

It started with me testing #20494.

I compiled it, started it and loaded an image into darkroom. I expanded DorS to look at the changes then exited darkroom to a crash. Having traced the error above, it now makes sense as it didn't like something about the changed module.

I next started my daily driver which I had just updated and it must have found something in memory left over because it then segfaulted.

Next I built a clean install to chase the bug and got it to default a couple of times. Once I cleared the database, it didn't segfault again.

I went back to my daily driver and it was fine too.

So, #20494 needs some love.