Skip to content

fix(test): restore store_wallet calls lost in merge#663

Merged
lklimek merged 2 commits intozk-extract/all-mergedfrom
copilot/sub-pr-644
Feb 25, 2026
Merged

fix(test): restore store_wallet calls lost in merge#663
lklimek merged 2 commits intozk-extract/all-mergedfrom
copilot/sub-pr-644

Conversation

Copy link
Contributor

Copilot AI commented Feb 25, 2026

Commit 0710295 added db.store_wallet() before register_test_address() in two unit tests to satisfy the wallet_addresses → wallet(seed_hash) foreign key constraint. A subsequent merge from v1.0-dev (7e95598) overwrote those changes, silently dropping the fix.

  • Restored db.store_wallet(&wallet, &Network::Testnet) in test_remove_utxos_removes_from_wallet and test_remove_utxos_cleans_empty_address_entries before the register_test_address call
let db = create_test_database().expect("test db");
db.store_wallet(&wallet, &Network::Testnet)
    .expect("store test wallet");  // ← was lost in merge
register_test_address(&db, &wallet, &addr);

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 25, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr checks 644 --repo dashpay/dash-evo-tool (http block)
    • Triggering command: /usr/bin/gh gh pr view --json number,headRefName,baseRefName (http block)
  • https://api.github.com/repos/dashpay/dash-evo-tool/actions/runs
    • Triggering command: /usr/bin/gh gh api repos/dashpay/dash-evo-tool/actions/runs --jq .workflow_runs[:5] | .[] | {id, name, head_branch, status, conclusion, created_at} (http block)
    • Triggering command: /usr/bin/gh gh run list --repo dashpay/dash-evo-tool --branch copilot/sub-pr-644 --limit 10 (http block)
    • Triggering command: /usr/bin/gh gh run list --repo dashpay/dash-evo-tool --branch zk-extract/all-merged --limit 10 (http block)
  • www.github.com
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/bin/cargo test --all-features --workspace (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Backport non-ZK improvements to zk branch fix(test): restore store_wallet calls lost in merge Feb 25, 2026
Copilot AI requested a review from lklimek February 25, 2026 17:43
@lklimek lklimek marked this pull request as ready for review February 25, 2026 17:46
@lklimek lklimek merged commit 64651c5 into zk-extract/all-merged Feb 25, 2026
3 checks passed
@lklimek lklimek deleted the copilot/sub-pr-644 branch February 25, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants