From ecab98e0389602111e3e866f3b667e295c9d9e57 Mon Sep 17 00:00:00 2001 From: Jake Wilkins Date: Mon, 13 Oct 2025 15:03:46 +0100 Subject: [PATCH] Default config values for ngpus, scheduler_ngpus and worker_ngpus are now converted to integers before being checked to be greater than the value of zero. Beforehand, these values were assumed to be integers, causing a type error for all instantiations of GCPCluster, creating a breaking change --- dask_cloudprovider/gcp/instances.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dask_cloudprovider/gcp/instances.py b/dask_cloudprovider/gcp/instances.py index f0c308a2..47707b34 100644 --- a/dask_cloudprovider/gcp/instances.py +++ b/dask_cloudprovider/gcp/instances.py @@ -662,17 +662,18 @@ def __init__( self.scheduler_machine_type = machine_type self.worker_machine_type = machine_type - self.ngpus = ngpus or self.config.get("ngpus") + ngpus_value = ngpus or self.config.get("ngpus") + self.ngpus = int(ngpus_value) if ngpus_value else None if not self.ngpus: self.scheduler_ngpus = ( scheduler_ngpus if scheduler_ngpus is not None - else self.config.get("scheduler_ngpus", 0) + else int(self.config.get("scheduler_ngpus") or 0) ) self.worker_ngpus = ( worker_ngpus if worker_ngpus is not None - else self.config.get("worker_ngpus", 0) + else int(self.config.get("worker_ngpus") or 0) ) else: if scheduler_ngpus is not None or worker_ngpus is not None: