Skip to content

Adapt worker and nanny to ipv6 #9133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

Adapt worker and nanny to ipv6 #9133

merged 1 commit into from
Nov 4, 2025

Conversation

@csfldf
Copy link
Contributor

@csfldf csfldf commented Oct 30, 2025 •
edited
Loading

We found we failed to create SSH Cluster in ipv6 only machines and it's because some codes in worker, nanny modules work only for ipv4 environment.

This pr tries to adapt worker and annny to ipv6 and we have verified it works in our ipv6 only environment.

  • Tests added / passed
  • Passes pre-commit run --all-files

@csfldf csfldf requested a review from fjetter as a code owner October 30, 2025 16:36
@csfldf csfldf force-pushed the fix/adapt_ipv6 branch 2 times, most recently from b3448d3 to aecb91d Compare October 30, 2025 17:15
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 57m 6s ⏱️ + 8m 58s
 4 112 tests ±0   4 007 ✅ ±0    104 💤 ±0  1 ❌ ±0 
51 516 runs  ±0  49 331 ✅ ±0  2 184 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 36d971a. ± Comparison against base commit 4c61f86.

♻️ This comment has been updated with latest results.

jacobtomlinson
jacobtomlinson reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We always aim to support IPv6, but as we don't have access to an IPv6 only CI environment it's hard to test.

@csfldf csfldf force-pushed the fix/adapt_ipv6 branch 2 times, most recently from b38051b to 42fe1cf Compare November 1, 2025 14:34
@csfldf csfldf requested a review from jacobtomlinson November 1, 2025 15:14
jacobtomlinson
jacobtomlinson reviewed Nov 3, 2025
View reviewed changes
@csfldf csfldf requested a review from jacobtomlinson November 3, 2025 12:30
@jacobtomlinson
Copy link
Member

jacobtomlinson commented Nov 3, 2025

CI failures are related to #9135

@csfldf csfldf closed this Nov 3, 2025
@csfldf csfldf reopened this Nov 3, 2025
@csfldf
Copy link
Contributor Author

csfldf commented Nov 3, 2025 •
edited
Loading

CI failures are related to #9135

Got it. I will re-trigger CI workflow after your pr merged. Thanks for your help!

@jacobtomlinson
Copy link
Member

jacobtomlinson commented Nov 3, 2025

All clear to re-trigger

@csfldf csfldf closed this Nov 3, 2025
@csfldf csfldf reopened this Nov 3, 2025
@csfldf
Copy link
Contributor Author

csfldf commented Nov 3, 2025

All clear to re-trigger

done

jacobtomlinson
jacobtomlinson approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is unrelated. Thanks for iterating on this!

@jacobtomlinson jacobtomlinson merged commit a9ad6d4 into dask:main Nov 4, 2025
33 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csfldf @jacobtomlinson