-
Notifications
You must be signed in to change notification settings - Fork 119
Fix formatting in the default template #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Btw, pyproject.toml includes a line length for black but not for ruff.
lennartkats-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is in sync with the 120 line length used elsewhere? And we need CI checks for this. I pinged you about this offline.
|
@lennartkats-db does the change make sense? we can decide if we want to change formatter settings in pyproject.toml separately |
lennartkats-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gleb! Yes this makes sense. I will offer a "❤️" emoticon for anyone who can update the formatter settings and move them to ruff!
|
@kanterov OK to merge? |
Changes
Fix formatting in the default template. Previously, there was a diff:
The problem is in the default template and not specific to PyDABs.
Why
The template should be pre-formatted so that after the project is initialized, it's already in its final state.
Tests
Updated acceptance tests to check formatting for all files that template produces