Sync-DbaAvailabilityGroup - Fix null reference errors when syncing empty Agent objects #9877
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty Agent objects Fixes #9684 Wrapped JobServer.Refresh() calls in foreach loops with null checks to prevent "You cannot call a method on a null-valued expression" errors when: - No Agent Operators exist on primary - No Agent Proxies exist on primary - Agent service is unavailable on secondary replicas Changes: - AgentCategory: Added foreach loop with JobServer null check (lines 290-296) - AgentOperator: Added foreach loop with JobServer null check (lines 302-306) - AgentProxy: Added foreach loop with JobServer null check (lines 317-321) - AgentSchedule: Added foreach loop with JobServer null check (lines 327-333) This follows the same pattern used for DatabaseOwner sync (line 256) and prevents one secondary's issues from blocking the entire sync operation. Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Chrissy LeMaire <potatoqualitee@users.noreply.github.com>
|
nice fix 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9684
Wrapped JobServer.Refresh() calls in foreach loops with null checks to prevent "You cannot call a method on a null-valued expression" errors when:
Changes
This follows the same pattern used for DatabaseOwner sync (line 256) and prevents one secondary's issues from blocking the entire sync operation.
Generated with Claude Code