Remove attachments behaviour

eccles · eccles · commit 240d41376d33 · 2023-08-24T08:41:07.000+01:00
Signed-off-by: Pal Hewlett &lt;phewlett76@gmail.com&gt;
diff --git a/README.rst b/README.rst
@@ -281,7 +281,6 @@ asset or event is confirmed before returning.
           description: Create an empty radiation bag with id 1.
           asset_label: radiation bag 1
         behaviours:
-          - Attachments
           - RecordEvidence
         attributes:
           arc_display_name: radiation bag 1
diff --git a/archivist/assets.py b/archivist/assets.py
@@ -185,7 +185,6 @@ def create_if_not_exists(
                     - arc_display_name
                 behaviours
                   - RecordEvidence
-                  - Attachments
                 attributes:
                   arc_display_name: RKVST Front Door
                   arc_firmware_version: "1.0"
diff --git a/archivist/constants.py b/archivist/constants.py
@@ -10,7 +10,6 @@
 # These are now hardcoded and not user-selectable. Eventually they will be removed from
 # the backend API and removed from this package.
 ASSET_BEHAVIOURS = [
-    "Attachments",
     "RecordEvidence",
 ]
 
diff --git a/archivist/notebooks/Check Asset Compliance using CURRENT OUTSTANDING Policy.ipynb b/archivist/notebooks/Check Asset Compliance using CURRENT OUTSTANDING Policy.ipynb
@@ -340,7 +340,6 @@
       "    \"identity\": \"assets/652b3fdf-736e-455f-81ec-fed5088a351c\",\n",
       "    \"behaviours\": [\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\",\n",
       "        \"RecordEvidence\",\n",
       "        \"Builtin\"\n",
       "    ],\n",
@@ -363,7 +362,6 @@
       "    \"identity\": \"assets/652b3fdf-736e-455f-81ec-fed5088a351c\",\n",
       "    \"behaviours\": [\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\",\n",
       "        \"RecordEvidence\",\n",
       "        \"Builtin\"\n",
       "    ],\n",
diff --git a/archivist/notebooks/Check Asset Compliance using SINCE Policy.ipynb b/archivist/notebooks/Check Asset Compliance using SINCE Policy.ipynb
@@ -287,7 +287,6 @@
       "        \"RecordEvidence\",\n",
       "        \"Builtin\",\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\"\n",
       "    ],\n",
       "    \"attributes\": {\n",
       "        \"arc_description\": \"Traffic flow control light at A603 North East\",\n",
@@ -310,7 +309,6 @@
       "        \"RecordEvidence\",\n",
       "        \"Builtin\",\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\"\n",
       "    ],\n",
       "    \"attributes\": {\n",
       "        \"arc_description\": \"Traffic flow control light at A603 North East\",\n",
diff --git a/archivist/notebooks/Create Artist and Album Release Info.ipynb b/archivist/notebooks/Create Artist and Album Release Info.ipynb
@@ -188,7 +188,6 @@
       "Asset {\n",
       "    \"identity\": \"assets/17a59a16-3d5c-4d58-8ea6-1b86465ff32f\",\n",
       "    \"behaviours\": [\n",
-      "        \"Attachments\",\n",
       "        \"RecordEvidence\",\n",
       "        \"Builtin\",\n",
       "        \"AssetCreator\"\n",
diff --git a/archivist/notebooks/Create Event with Verified Domain.ipynb b/archivist/notebooks/Create Event with Verified Domain.ipynb
@@ -268,7 +268,6 @@
       "    \"behaviours\": [\n",
       "        \"Builtin\",\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\",\n",
       "        \"RecordEvidence\"\n",
       "    ],\n",
       "    \"chain_id\": \"827586838445807967\",\n",
diff --git a/archivist/notebooks/Find Artist and Additional Album Release Info.ipynb b/archivist/notebooks/Find Artist and Additional Album Release Info.ipynb
@@ -184,7 +184,6 @@
       "        \"RecordEvidence\",\n",
       "        \"Builtin\",\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\"\n",
       "    ],\n",
       "    \"attributes\": {\n",
       "        \"genre\": \"Soul\",\n",
diff --git a/archivist/notebooks/Find Artist and Create Cover Art.ipynb b/archivist/notebooks/Find Artist and Create Cover Art.ipynb
@@ -219,7 +219,6 @@
       "        \"RecordEvidence\",\n",
       "        \"Builtin\",\n",
       "        \"AssetCreator\",\n",
-      "        \"Attachments\"\n",
       "    ],\n",
       "    \"attributes\": {\n",
       "        \"arc_display_name\": \"Adele Laurie Blue Adkins\",\n",
diff --git a/archivist/notebooks/Sharing Album Release Info with Record Labels.ipynb b/archivist/notebooks/Sharing Album Release Info with Record Labels.ipynb
@@ -193,7 +193,6 @@
       "                \"subjects/34b291c3-30f4-4d89-9ec7-85f57354f798\"\n",
       "            ],\n",
       "            \"behaviours\": [\n",
-      "                \"Attachments\",\n",
       "                \"RecordEvidence\"\n",
       "            ],\n",
       "            \"include_attributes\": [],\n",
diff --git a/archivist/notebooks/Sharing Album Release Info with User.ipynb b/archivist/notebooks/Sharing Album Release Info with User.ipynb
@@ -179,7 +179,6 @@
       "        {\n",
       "            \"subjects\": [],\n",
       "            \"behaviours\": [\n",
-      "                \"Attachments\",\n",
       "                \"RecordEvidence\"\n",
       "            ],\n",
       "            \"include_attributes\": [],\n",
diff --git a/archivist/notebooks/Sharing Artist Asset with Record Labels.ipynb b/archivist/notebooks/Sharing Artist Asset with Record Labels.ipynb
@@ -190,7 +190,6 @@
       "                \"subjects/34b291c3-30f4-4d89-9ec7-85f57354f798\"\n",
       "            ],\n",
       "            \"behaviours\": [\n",
-      "                \"Attachments\",\n",
       "                \"RecordEvidence\"\n",
       "            ],\n",
       "            \"include_attributes\": [],\n",
diff --git a/archivist/notebooks/Sharing Artist Asset with User.ipynb b/archivist/notebooks/Sharing Artist Asset with User.ipynb
@@ -175,7 +175,6 @@
       "        {\n",
       "            \"subjects\": [],\n",
       "            \"behaviours\": [\n",
-      "                \"Attachments\",\n",
       "                \"RecordEvidence\"\n",
       "            ],\n",
       "            \"include_attributes\": [],\n",
diff --git a/docs/runner/components/assets_create.rst b/docs/runner/components/assets_create.rst
@@ -25,7 +25,6 @@ The optional :code:`confirm: true` entry means that the step will wait for the a
           description: Create new EV Pump with id 1.
           asset_label: ev pump 1
         behaviours:
-          - Attachments
           - RecordEvidence
         attributes:
           arc_display_name: ev pump 1
diff --git a/docs/runner/components/assets_create_if_not_exists.rst b/docs/runner/components/assets_create_if_not_exists.rst
@@ -35,7 +35,6 @@ Usually these field values are derived from an environment variable
             - arc_namespace
         behaviours:
           - RecordEvidence
-          - Attachments
         attributes:
           arc_display_name: RKVST Paris Front Door
           arc_namespace: door entry
diff --git a/functests/test_resources/door_entry_story.yaml b/functests/test_resources/door_entry_story.yaml
@@ -19,7 +19,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: RKVST Paris Front Door
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -56,7 +55,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: City Hall Paris Front Door
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -94,7 +92,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Courts of Justice Paris Front Door
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -131,7 +128,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Bastille Paris Front Door
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -168,7 +164,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Gare du Nord Apartments Paris Front Door
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -205,7 +200,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Gare du Nord Apartments Paris Side Door
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -249,7 +243,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Access Card 1
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -269,7 +262,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Access Card 2
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -288,7 +280,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Access Card 3
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -306,7 +297,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Access Card 4
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -325,7 +315,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Access Card 5
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
diff --git a/functests/test_resources/dynamic_tolerance_story.yaml b/functests/test_resources/dynamic_tolerance_story.yaml
@@ -16,7 +16,6 @@ steps:
       asset_label: ev pump 1
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: ev pump 1
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
diff --git a/functests/test_resources/richness_story.yaml b/functests/test_resources/richness_story.yaml
@@ -13,7 +13,6 @@ steps:
       asset_label: radiation bag 1
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: radiation bag 1
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -28,7 +27,6 @@ steps:
       asset_label: radiation bag 2
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: radiation bag 2
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -43,7 +41,6 @@ steps:
       asset_label: radiation bag 3
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: radiation bag 3
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
diff --git a/functests/test_resources/synsation_story.yaml.j2 b/functests/test_resources/synsation_story.yaml.j2
@@ -55,7 +55,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: {{ asset.type }} in {{ asset.location_label }}
       arc_namespace: "{{ env['RKVST_UNIQUE_ID'] or 'namespace' }}"
diff --git a/functests/test_resources/wipp_story.yaml b/functests/test_resources/wipp_story.yaml
@@ -15,7 +15,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Drum 1
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
@@ -38,7 +37,6 @@ steps:
         - arc_namespace
     behaviours:
       - RecordEvidence
-      - Attachments
     attributes:
       arc_display_name: Cask 1
       arc_namespace: !ENV ${RKVST_UNIQUE_ID:namespace}
diff --git a/unittests/testeventsconstants.py b/unittests/testeventsconstants.py
@@ -44,31 +44,31 @@
     "display_name": "Accepted",
 }
 PROPS = {
-    "operation": "Attach",
-    "behaviour": "Attachments",
+    "operation": "Record",
+    "behaviour": "RecordEvidence",
     "timestamp_declared": "2019-11-27T14:44:19Z",
     "principal_accepted": PRINCIPAL_ACCEPTED,
 }
 PROPS_WITH_NO_TIMESTAMP = {
-    "operation": "Attach",
-    "behaviour": "Attachments",
+    "operation": "Record",
+    "behaviour": "RecordEvidence",
     "principal_accepted": PRINCIPAL_ACCEPTED,
 }
 PROPS_WITH_TIMESTAMP_ACCEPTED = {
-    "operation": "Attach",
-    "behaviour": "Attachments",
+    "operation": "Record",
+    "behaviour": "RecordEvidence",
     "timestamp_accepted": "2021-04-08T14:44:19Z",
     "principal_accepted": PRINCIPAL_ACCEPTED,
 }
 PROPS_WITH_PRINCIPAL_DECLARED = {
-    "operation": "Attach",
-    "behaviour": "Attachments",
+    "operation": "Record",
+    "behaviour": "RecordEvidence",
     "timestamp_declared": "2019-11-27T14:44:19Z",
     "principal_declared": PRINCIPAL_DECLARED,
 }
 PROPS_WITH_NO_PRINCIPAL = {
-    "operation": "Attach",
-    "behaviour": "Attachments",
+    "operation": "Record",
+    "behaviour": "RecordEvidence",
     "timestamp_declared": "2019-11-27T14:44:19Z",
 }
 
diff --git a/unittests/testnotebooks.py b/unittests/testnotebooks.py
@@ -27,7 +27,7 @@
 
 ARTIST_RESPONSE = {
     "identity": "assets/0c8c04b1-05e1-4653-b438-fd912b0c61b7",
-    "behaviours": ["Attachments", "RecordEvidence", "Builtin", "AssetCreator"],
+    "behaviours": ["RecordEvidence", "Builtin", "AssetCreator"],
     "attributes": {
         "arc_description": "British Soul Singer",
         "arc_display_name": ARTIST_NAME,

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`# These are now hardcoded and not user-selectable. Eventually they will be removed from`
`11`	`11`	`# the backend API and removed from this package.`
`12`	`12`	`ASSET_BEHAVIOURS = [`
`13`		`- "Attachments",`
`14`	`13`	`"RecordEvidence",`
`15`	`14`	`]`
`16`	`15`