feat(core): add indexers for slowest client.List operations

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/indexer/indexer.go

@@ -34,6 +34,7 @@ const (
 	IndexFieldVMByVD    = "spec.blockDeviceRefs.VirtualDisk"
 	IndexFieldVMByVI    = "spec.blockDeviceRefs.VirtualImage"
 	IndexFieldVMByCVI   = "spec.blockDeviceRefs.ClusterVirtualImage"
+	IndexFieldVMByIP    = "status.ipAddress"
 	IndexFieldVMByNode  = "status.node"
 
 	IndexFieldVDByVDSnapshot  = "vd,spec.DataSource.ObjectRef.Name,.Kind=VirtualDiskSnapshot"
@@ -64,6 +65,7 @@ var IndexGetters = []IndexGetter{
 	IndexVMByVD,
 	IndexVMByVI,
 	IndexVMByCVI,
+	IndexVMByIP,
 	IndexVMByNode,
 	IndexVMSnapshotByVM,
 	IndexVMSnapshotByVDSnapshot,
@@ -121,6 +123,16 @@ func IndexVMByCVI() (obj client.Object, field string, extractValue client.Indexe
 	}
 }
 
+func IndexVMByIP() (obj client.Object, field string, extractValue client.IndexerFunc) {
+	return &v1alpha2.VirtualMachine{}, IndexFieldVMByIP, func(object client.Object) []string {
+		vm, ok := object.(*v1alpha2.VirtualMachine)
+		if !ok || vm == nil || vm.Status.IPAddress == "" {
+			return nil
+		}
+		return []string{vm.Status.IPAddress}
+	}
+}
+
 func IndexVMByNode() (obj client.Object, field string, extractValue client.IndexerFunc) {
 	return &v1alpha2.VirtualMachine{}, IndexFieldVMByNode, func(object client.Object) []string {
 		vm, ok := object.(*v1alpha2.VirtualMachine)

images/virtualization-artifact/pkg/controller/vd/internal/inuse.go

@@ -33,6 +33,7 @@ import (
 	"github.com/deckhouse/virtualization-controller/pkg/common/object"
 	commonvd "github.com/deckhouse/virtualization-controller/pkg/common/vd"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
+	"github.com/deckhouse/virtualization-controller/pkg/controller/indexer"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2/vdcondition"
 )
@@ -152,8 +153,8 @@ func (h InUseHandler) checkImageUsage(ctx context.Context, vd *v1alpha2.VirtualD
 
 func (h InUseHandler) updateAttachedVirtualMachines(ctx context.Context, vd *v1alpha2.VirtualDisk) error {
 	var vms v1alpha2.VirtualMachineList
-	err := h.client.List(ctx, &vms, &client.ListOptions{
-		Namespace: vd.GetNamespace(),
+	err := h.client.List(ctx, &vms, &client.MatchingFields{
+		indexer.IndexFieldVMByVD: vd.Name,
 	})
 	if err != nil {
 		return fmt.Errorf("error getting virtual machines: %w", err)

images/virtualization-artifact/pkg/controller/vmip/internal/attached_handler.go

@@ -29,6 +29,7 @@ import (
 	"github.com/deckhouse/virtualization-controller/pkg/common/annotations"
 	"github.com/deckhouse/virtualization-controller/pkg/common/object"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
+	"github.com/deckhouse/virtualization-controller/pkg/controller/indexer"
 	"github.com/deckhouse/virtualization-controller/pkg/eventrecord"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2/vmipcondition"
@@ -83,7 +84,9 @@ func (h *AttachedHandler) Handle(ctx context.Context, vmip *v1alpha2.VirtualMach
 
 func (h *AttachedHandler) getAttachedVirtualMachine(ctx context.Context, vmip *v1alpha2.VirtualMachineIPAddress) (*v1alpha2.VirtualMachine, error) {
 	var vms v1alpha2.VirtualMachineList
-	err := h.client.List(ctx, &vms, &client.ListOptions{Namespace: vmip.Namespace})
+	err := h.client.List(ctx, &vms, &client.MatchingFields{
+		indexer.IndexFieldVMByIP: vmip.Status.Address,
+	})
 	if err != nil {
 		return nil, fmt.Errorf("list vms: %w", err)
 	}