Skip to content

feat(vmclass): use percentage format for coreFractions values #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

feat(vmclass): use percentage format for coreFractions values #1601

wants to merge 75 commits into from

Conversation

@loktev-d
Copy link
Contributor

@loktev-d loktev-d commented Oct 21, 2025 •
edited
Loading

Description

Introduce v1alpha3 version of VirtualMachineClass with percentage string format (e.g., 5 → "5%") for coreFractions. Use Kubernetes conversion webhooks for version compatibility between v1alpha2 and v1alpha3

Key changes

  • v1alpha2: Maintains original coreFractions: []int format for backward compatibility
  • v1alpha3 (storage version): Introduces new coreFractions: []string format with "%" suffix
  • Conversion webhook: Provides automatic bidirectional conversion between versions (v1alpha2 is hub, v1alpha3 is spoke). Injected into VirtualMachineClass CRD on controller startup.
  • Admission webhook: Added conversion to hub version so that validation is compatible with both versions
  • E2E tests: use new v1alpha3 version

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmclass
type: feature
summary: use percentage format for coreFractions with conversion webhook

@loktev-d
wip
723327c 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
58498a2 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
sourcery-ai[bot]
sourcery-ai bot reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @loktev-d, your pull request is larger than the review limit of 150000 diff characters

@loktev-d loktev-d marked this pull request as draft October 21, 2025 07:45
loktev-d and others added 2 commits October 21, 2025 11:00
@loktev-d
Merge branch 'main' into feat/vmclass/core-fractions-percentage
ee98848 
Signed-off-by: Daniil Loktev <70405899+loktev-d@users.noreply.github.com>
@loktev-d
wip
0cab994 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
z9r5
z9r5 reviewed Oct 21, 2025
View reviewed changes
crds/doc-ru-virtualmachineclasses.yaml
coreFractions:
description: |
Допустимые значения параметра `coreFraction`.
Допустимые значения параметра `coreFraction` в процентах (например, "5%", "10%", "25%", "50%", "100%").
Copy link
Member

@z9r5 z9r5 Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Допустимые значения параметра `coreFraction` в процентах (например, "5%", "10%", "25%", "50%", "100%").
Максимальная доля использования ядра CPU в процентах (например, "5%", "10%", "25%", "50%", "100%").

Тут каждого ядра? Всех ядер?

Copy link
Contributor Author

@loktev-d loktev-d Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется немного будет сбивать с толку, потому что тут указываются именно допустимые значения

Copy link
Member

@z9r5 z9r5 Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется немного будет сбивать с толку, потому что тут указываются именно допустимые значения

А... тут по сути список возможных coreFractions чтоли. Хм... Блин, описание такое себе конечно. И в целом в спеке есть подобные не понятные штуки.. пупупу...

z9r5
z9r5 previously approved these changes Oct 22, 2025
View reviewed changes
loktev-d and others added 7 commits October 22, 2025 16:44
@loktev-d
remove formating changes
6e978ef 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
b033f17 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
28a0f91 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
1c477ad 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
774de40 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d @z9r5
Apply suggestion from @z9r5
8e15550 
Co-authored-by: Artem Kladov <6360800+z9r5@users.noreply.github.com>
Signed-off-by: Daniil Loktev <70405899+loktev-d@users.noreply.github.com>
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
Revert "Apply suggestion from @z9r5"
5458ff6 
This reverts commit ca8b840.

Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d loktev-d force-pushed the feat/vmclass/core-fractions-percentage branch from ffe3f98 to 5458ff6 Compare October 22, 2025 13:45
@loktev-d loktev-d added this to the v1.2.0 milestone Oct 22, 2025
@loktev-d
wip
b71d209 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
ccd15e2 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
fa19dff 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
b07e3c5 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
7dcb2b6 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Oct 30, 2025
@loktev-d
fix transformers
b015808 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Oct 30, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Oct 30, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Oct 30, 2025
@loktev-d
fix validation message
1855184 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
Revert "fix validation message"
6c747b2 
This reverts commit 1855184.

Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d loktev-d force-pushed the feat/vmclass/core-fractions-percentage branch from 3684ec9 to 6c747b2 Compare November 7, 2025 10:08
@loktev-d
set v1alpha3 as storage version
569b5b8 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
fix conversion test
cba744c 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Nov 7, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 7, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 7, 2025
@loktev-d loktev-d added validation/skip/doc_changes Skip doc changes validation e2e/run Run e2e test on cluster of PR author labels Nov 10, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 10, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 10, 2025
@Isteb4k Isteb4k marked this pull request as ready for review November 10, 2025 09:20
Isteb4k
Isteb4k requested changes Nov 10, 2025
View reviewed changes
api/core/v1alpha3/virtual_machine_class_conversion.go
*/

package v1alpha3

Copy link
Contributor

@Isteb4k Isteb4k Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

var _ conversion.Hub = &VirtualMachineClass{}

@loktev-d
add deprecation, move coreFractions validation to webhook
572df39 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
508d036 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
codegen
ea60530 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
wip
9867d72 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
fix validation
3b207fb 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
fix license
b0b08b0 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d
fix unit tests
adbaa0e 
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z9r5 z9r5 z9r5 left review comments

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Isteb4k Isteb4k Isteb4k requested changes

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@hardcoretime hardcoretime Awaiting requested review from hardcoretime

@danilrwx danilrwx Awaiting requested review from danilrwx

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@goganat goganat Awaiting requested review from goganat goganat is a code owner

@universal-itengineer universal-itengineer Awaiting requested review from universal-itengineer universal-itengineer is a code owner

@nevermarine nevermarine Awaiting requested review from nevermarine nevermarine is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@loktev-d loktev-d

Labels

validation/skip/doc_changes Skip doc changes validation

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@loktev-d @deckhouse-BOaTswain @z9r5 @Isteb4k