Typo in date: "Dev" should be "Dec" (December).

The description states "Gives ability to acquire a spectrum data, while keeping the raw CCD image (ie, without vertical binning)" but this plugin is for photo-detectors, not CCD cameras. Photo-detectors typically don't have binning options and don't produce images. The description appears to be copied from another plugin (possibly spectrum_raw.py) without being updated for this plugin's actual purpose.

Typo in docstring: "add to to all compatible viewports" should be "add to all compatible viewports" (remove duplicate "to").

⚠️ Potential issue | 🟡 Minor

#!/bin/bash
# First, locate and examine the file
find . -name "photo_det_live.py" -type f

#!/bin/bash
# Get file size to determine how to read it
wc -l plugins/photo_det_live.py

#!/bin/bash
# Read the relevant lines (33-80 to see full context)
sed -n '33,80p' plugins/photo_det_live.py

#!/bin/bash
# Search for StreamController class definition and usage
rg "class StreamController" --type py -A 5

#!/bin/bash
# Search for add_photo_det_stream method to see what it returns
rg "def add_photo_det_stream" --type py -A 20

#!/bin/bash
# Read the complete add_photo_det_stream method (lines 59-99)
sed -n '59,99p' plugins/photo_det_live.py

Add class and method docstrings in reST format and return type hints.

The class and both methods lack proper documentation and return type annotations per Python guidelines:

• Class PhotoDetectorLivePlugin has no docstring
• __init__ is missing both docstring and return type hint (-> None)
• add_photo_det_stream has an improperly formatted docstring (single-line, non-reST) and is missing a return type hint; the method returns stream_cont on line 97

 class PhotoDetectorLivePlugin(Plugin):
+    """
+    Live-display plugin for photo-detector monochromator streams.
+    """
     name = "Photo-detector live display"
@@
-    def __init__(self, microscope: model.Microscope, main_app: OdemisGUIApp):
+    def __init__(self, microscope: model.Microscope, main_app: OdemisGUIApp) -> None:
+        """
+        Initialize the plugin and register photo-detector stream actions.
+        
+        :param microscope: Active microscope instance.
+        :param main_app: Main GUI application.
+        """
@@
-    def add_photo_det_stream(self, name: str, detector: model.Detector):
-        """ Create a Monochromator stream, using a photo-detector and add to to all compatible viewports"""
+    def add_photo_det_stream(self, name: str, detector: model.Detector) -> "StreamController":
+        """
+        Create a monochromator stream using a photo-detector and add it to compatible viewports.
+        
+        :param name: Stream name.
+        :param detector: Photo-detector to bind.
+        :return: The created stream controller.
+        """

In `@plugins/photo_det_live.py` around lines 33 - 59, Add reST docstrings and
return type hints: add a class-level reST docstring to PhotoDetectorLivePlugin
describing purpose and authorship; add an __init__ docstring in reST and
annotate __init__ with -> None; replace the single-line docstring in
add_photo_det_stream with a proper multi-line reST docstring describing
parameters (name, detector), behavior and return value, and add a return type
hint for add_photo_det_stream matching the actual returned object (the variable
stream_cont) — if the concrete type isn't available, import typing.Any or
typing.Optional and annotate accordingly; update imports if needed.

The code unconditionally adds spectrograph axes to the axes dictionary without checking if spg is None. When no spectrograph affects the detector and main_data.spectrograph is also None (which can happen in some microscope configurations), spg will be None, leading to axis map entries with None components. This pattern is inconsistent with addTimeCorrelator (line 2009 in stream_bar.py) which checks if spg is truthy before adding spectrograph axes. Consider wrapping the axes.update() call in an if spg: condition similar to how it's done in addTimeCorrelator.

⚠️ Potential issue | 🟡 Minor

Add a docstring for _set_protection and drop unused lpos.

_set_protection needs a docstring per guidelines, and lpos is unused here.

                 for an, val in self._expected_do_pos.items():
                     channel = self._name_to_do_axis[an]
                     if channel not in self._led_prot_do:
                         continue
-                    _, hpos, lpos, dur = self._do_axes[channel]
+                    _, hpos, _lpos, dur = self._do_axes[channel]
                     if self.position.value[an] == val:
                         logging.debug("Shutter on axis %s already in protected position", an)
                     else:
                         tsleep = max(tsleep, dur)
                     self.SetIO(2, channel, val == hpos)
@@
-    def _set_protection(self, protected: bool) -> bool:
+    def _set_protection(self, protected: bool) -> bool:
+        """
+        Toggle LED protection state.
+
+        :param protected: True to force protection, False to restore expected DO state.
+        :return: The requested protection state.
+        """
         if self.protection.value == protected:
             return protected  # no change

In `@src/odemis/driver/tmcm.py` around lines 1462 - 1510, Add a docstring to the
_set_protection method describing its purpose, parameters, and return value (it
toggles protection state, takes protected: bool, returns the new state) and
remove the unused lpos local variable from the _switch_led_prot method where
_do_axes is unpacked (change "do_an, hpos, lpos, dur = self._do_axes[channel]"
to only unpack the used names or use a throwaway name like _ for the unused
element). Ensure references to _refswitch_lock and calls to _switch_led_prot
remain unchanged.

The code accesses self.protection.value without checking if the attribute exists. While this should be safe because self.protection is only created when self._led_prot_do is not empty (line 463-467), and this code is inside a condition checking channel in self._led_prot_do, the logic is fragile. For consistency with line 1557, consider using hasattr(self, "protection") before accessing self.protection.value, or document why this is safe.