Skip to content

Commit 4083a6e

Browse files
committed
fix: editor state, self-match key-binding
1 parent c41f819 commit 4083a6e

File tree

9 files changed

+22
-44
lines changed

9 files changed

+22
-44
lines changed

src/components/BattleTV/BattleTV.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ function PaginatedItems({ battleTvType }: { battleTvType: BattleType }) {
103103
const dispatch = useAppDispatch();
104104

105105
if (!currentBattles.hasbeenFetched) {
106-
console.log('fetching battles');
107106
dispatch(
108107
fetchBattlesAction({ battleTvType: battleTvType, page: pageCount }),
109108
);

src/components/Editor/Editor.tsx

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import {
2727
} from '../../store/EditorSettings/settings';
2828

2929
import {
30+
GameType,
3031
updateUserCode,
3132
UpdateUserCodeRequestObject,
3233
UserCode,
@@ -172,50 +173,36 @@ export default function CodeEditor(props: Editor.Props): JSX.Element {
172173
});
173174

174175
//Keybinding for save -> CTRL+S
175-
176176
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyCode.KeyS, function () {
177177
props.SaveRef.current?.click();
178178
});
179179

180180
//Keybinding for Simulate -> CTRL+ALT+N
181-
182-
if (props.page == 'Dashboard') {
183-
editor.addCommand(
184-
monaco.KeyMod.CtrlCmd | monaco.KeyMod.Alt | monaco.KeyCode.KeyN,
185-
function () {
181+
editor.addCommand(
182+
monaco.KeyMod.CtrlCmd | monaco.KeyMod.Alt | monaco.KeyCode.KeyN,
183+
function () {
184+
if (GameType.NORMAL) {
186185
dispatch(isSelfMatchModalOpened(true));
187186
dispatch(codeCommitNameChanged('Current Code'));
188187
dispatch(codeCommitIDChanged(null));
189188
dispatch(mapCommitNameChanged('Current Map'));
190189
dispatch(mapCommitIDChanged(null));
191-
},
192-
);
193-
194-
//Keybinding for Commit -> CTRL+K
195-
196-
editor.addCommand(
197-
monaco.KeyMod.CtrlCmd | monaco.KeyCode.KeyK,
198-
function () {
199-
dispatch(isCommitModalOpened(true));
200-
},
201-
);
202-
}
203-
204-
if (props.page == 'PvP') {
205-
editor.addCommand(
206-
monaco.KeyMod.CtrlCmd | monaco.KeyMod.Alt | monaco.KeyCode.KeyN,
207-
function () {
190+
} else if (GameType.PVP) {
208191
dispatch(isPvPSelfMatchModalOpened(true));
209-
dispatch(code1CommitNameChanged('Current Player 1 Code'));
192+
dispatch(code1CommitNameChanged('Current Code'));
210193
dispatch(code1CommitIDChanged(null));
211-
dispatch(code2CommitNameChanged('Current Player 2 Code'));
194+
dispatch(code2CommitNameChanged('Current Code'));
212195
dispatch(code2CommitIDChanged(null));
213-
},
214-
);
215-
}
196+
}
197+
},
198+
);
216199

217-
//Keybinding for Submit -> CTRL+SHIFT+S
200+
//Keybinding for Commit -> CTRL+K
201+
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyCode.KeyK, function () {
202+
dispatch(isCommitModalOpened(true));
203+
});
218204

205+
//Keybinding for Submit -> CTRL+SHIFT+S
219206
editor.addCommand(
220207
monaco.KeyMod.CtrlCmd | monaco.KeyMod.Shift | monaco.KeyCode.KeyS,
221208
function () {

src/components/Leaderboard/Leaderboard.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ function PaginatedItems(props: LeaderboardType.Props) {
129129
leaderboardAPI
130130
.getPvPLeaderboard(pageNum, itemsPerPage)
131131
.then(response => {
132-
console.log(response);
133132
setPvpItems(response);
134133
setIsPvPLoaded(true);
135134
})

src/components/Websocket/Websocket.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export const Websocket: React.FunctionComponent = () => {
1919
const currentUserapi = new CurrentUserApi(apiConfig);
2020
const dispatch = useAppDispatch();
2121
const gameType = useAppSelector(CurrentGameType);
22-
console.log(gameType.toString());
2322
const [user, setUser] = useState<CurrentUserProfile>();
2423

2524
useEffect(() => {
@@ -37,7 +36,6 @@ export const Websocket: React.FunctionComponent = () => {
3736
break;
3837
case GameStatus.Executed:
3938
Toast.success('Executed successfully!');
40-
console.log(gameType);
4139
// TODO: find non-hacky way to do this
4240
dispatch(changeSimulationState(true));
4341
dispatch(

src/pages/Dashboard/Dashboard.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
Language,
44
DailyChallengesApi,
55
CurrentUserApi,
6+
CodeType,
67
} from '@codecharacter-2024/client';
78
import { RendererComponent } from '@codecharacter-2024/renderer';
89
import Toast from 'react-hot-toast';
@@ -177,7 +178,7 @@ export default function Dashboard(): JSX.Element {
177178
.finally(() => localStorage.setItem('firstTime', 'false'));
178179

179180
codeAPI
180-
.getLatestCode('PVP')
181+
.getLatestCode(CodeType.Pvp)
181182
.then(response => {
182183
dispatch(initializePvPEditorStates(response));
183184
})
@@ -196,11 +197,8 @@ export default function Dashboard(): JSX.Element {
196197
);
197198

198199
const handleLanguageChange = (language: string) => {
199-
console.log(language);
200200
switch (language) {
201201
case 'C++':
202-
console.log('changed to cpp');
203-
console.log(pageState);
204202
switch (pageState) {
205203
case 'Dashboard':
206204
dispatch(changeLanguage('c_cpp'));

src/store/BattleTV/BattleTvSlice.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ export const fetchBattlesAction = createAsyncThunk(
5858
reqobj: { battleTvType: BattleType; page: number },
5959
{ rejectWithValue },
6060
) => {
61-
console.log('called');
6261
try {
6362
switch (reqobj.battleTvType) {
6463
case BattleType.NORMAL:

src/store/EditorSettings/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const initialState: settingsStateType = {
2222
enableSnippets: true,
2323
isInfoOpen: false,
2424
isCommitModalOpen: false,
25-
autocomplete: true,
25+
autocomplete: false,
2626
};
2727

2828
export interface CodeAndLanguage {

src/store/editor/code.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,15 @@ export const editorSlice = createSlice({
6565
},
6666

6767
initializePvPEditorStates: (state, action: PayloadAction<Code>) => {
68+
state.userCode = action.payload.code;
6869
if (action.payload.language === 'C' || action.payload.language === 'CPP')
6970
state.language = 'c_cpp';
7071
else if (action.payload.language === 'PYTHON') state.language = 'python';
7172
else if (action.payload.language === 'JAVA') state.language = 'java';
7273
state.lastSavedAt = action.payload.lastSavedAt;
7374
const desiredIndex = languagesAvailable.indexOf(state.language);
7475
state.allLanguagesPvPCode[desiredIndex] = action.payload.code;
76+
state.gameType = GameType.PVP;
7577
},
7678

7779
updateUserCode: (
@@ -89,7 +91,7 @@ export const editorSlice = createSlice({
8991
if (gameType === GameType.NORMAL) {
9092
state.allLanguagesNormalCode[desiredIndex] =
9193
newCodeAndLanguage.currentUserCode;
92-
} else {
94+
} else if (gameType === GameType.PVP) {
9395
state.allLanguagesPvPCode[desiredIndex] =
9496
newCodeAndLanguage.currentUserCode;
9597
}
@@ -101,7 +103,6 @@ export const editorSlice = createSlice({
101103
action: PayloadAction<GameTypeAndLanguage>,
102104
) => {
103105
state.gameType = action.payload.gameType;
104-
console.log(action);
105106
if (action.payload.gameType === GameType.NORMAL) {
106107
state.userCode =
107108
state.allLanguagesNormalCode[

src/store/rendererLogs/logAPI.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ export const getLogs = (id: string, gametype: GameType): Promise<string> => {
66
return new Promise((resolve, reject) => {
77
const gameAPI = new GameApi(apiConfig);
88
const pvpGameApi = new PvpGameApi(apiConfig);
9-
console.log(gametype.toString());
109
if (gametype === GameType.NORMAL) {
1110
gameAPI
1211
.getGameLogsByGameId(id)
1312
.then(logs => {
14-
console.log(`fetched ${logs}`);
1513
resolve(logs);
1614
})
1715
.catch(error => {
@@ -23,7 +21,6 @@ export const getLogs = (id: string, gametype: GameType): Promise<string> => {
2321
pvpGameApi
2422
.getPvpGameLogsByGameId(id)
2523
.then(logs => {
26-
console.log(`fetched ${logs}`);
2724
resolve(logs);
2825
})
2926
.catch(error => {

0 commit comments

Comments
 (0)