fix(no-invalid-regexp): allow v-mode regexes containing -- after single token in a char class #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-rowe
force-pushed
the
no-invalid-valid-regexp
branch
from
af3c5ec to
2559550
Compare
…le token in a char class
lionel-rowe
force-pushed
the
no-invalid-valid-regexp
branch
from
2559550 to
f7427b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442
The large diff in src/js_regex/mod.rs is mostly just ctrl+h test changes due to the validator methods now accepting/returning
UnicodeModeenums (u/v/none) instead of booleans (u/none).