Skip to content

feat: add social image #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drwpow merged 1 commit into from
Nov 11, 2025
Merged

feat: add social image #345

drwpow merged 1 commit into from
Nov 11, 2025

Conversation

@drwpow
Copy link
Contributor

@drwpow drwpow commented Oct 28, 2025

Changes

Adds a social image to embeds from Tim’s design

social

How to Review

  • Are the meta tags correct?

@drwpow drwpow requested a review from ChucKN0risK October 28, 2025 18:57
@netlify
Copy link

netlify bot commented Oct 28, 2025 •
edited
Loading

✅ Deploy Preview for designtokensorg ready!

Name Link
🔨 Latest commit 93d89d9
🔍 Latest deploy log https://app.netlify.com/projects/designtokensorg/deploys/69135a64bb3cd20008a98c52
😎 Deploy Preview https://deploy-preview-345--designtokensorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@julien-deramond
Copy link

julien-deramond commented Oct 28, 2025 •
edited
Loading

Are the meta tags correct?

Sorry to jump in. I’m subscribed to this repo’s notifications to follow DTCG updates, but I noticed something familiar from when we migrated Bootstrap’s docs to Astro.

FYI, there’s a fallback mechanism on Twitter/X’s side that relies on og:* tags: https://developer.x.com/en/docs/x-for-websites/cards/overview/markup

We ended up using the following config in Bootstrap, which might help: https://github.com/twbs/bootstrap/blob/main/site/src/components/head/Social.astro

Btw, there's a small typo in the URL where /assets/iamges -> /assets/images

@drwpow
Copy link
Contributor Author

drwpow commented Nov 11, 2025

@julien-deramond Please always jump in with great tips like this, thank you! Will gladly steal from that setup 🙏

@drwpow drwpow force-pushed the drwpow/social-img branch 2 times, most recently from 5fc612d to 49dd0c1 Compare November 11, 2025 15:46
@drwpow drwpow merged commit 5bad995 into main Nov 11, 2025
7 checks passed
@drwpow drwpow deleted the drwpow/social-img branch November 11, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChucKN0risK ChucKN0risK Awaiting requested review from ChucKN0risK

@kaelig kaelig Awaiting requested review from kaelig

@ilikescience ilikescience Awaiting requested review from ilikescience

@resource11 resource11 Awaiting requested review from resource11

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drwpow @julien-deramond