From 1078ec7ae55ff81d1b00d20d5ec7a1c2002f2ea5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vavrinecz=20P=C3=A9ter?= Date: Thu, 6 Feb 2025 18:03:58 +0100 Subject: [PATCH 1/5] fix nav buttons --- src/index.html | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/index.html b/src/index.html index 04bd19e..9d5e18c 100644 --- a/src/index.html +++ b/src/index.html @@ -11,7 +11,6 @@ - From f0c9079181aeadd67553dd788023243b32d5df03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vavrinecz=20P=C3=A9ter?= Date: Thu, 6 Feb 2025 18:28:39 +0100 Subject: [PATCH 2/5] hide desktop navbar on mobile --- src/index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/index.html b/src/index.html index 9d5e18c..26c48e9 100644 --- a/src/index.html +++ b/src/index.html @@ -21,10 +21,10 @@ title="Toggle Navigation Menu" > - + - Browse Challenges - Sign Up + Browse Challenges + Sign Up From 70b14a14c4f66848936d7718ffc30588dc1a953e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vavrinecz=20P=C3=A9ter?= Date: Thu, 6 Feb 2025 18:31:26 +0100 Subject: [PATCH 3/5] invert banner image colors --- src/styles.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles.css b/src/styles.css index 2cbb72e..cb9a90d 100644 --- a/src/styles.css +++ b/src/styles.css @@ -669,7 +669,7 @@ form > span { #jumbo-image { max-height: 20rem; - /* TODO: Invert banner colors using CSS */ + filter: invert(1); } @media (max-width: 600px) { From 7d3666eab9cf2f985a63572bb64b08c19191e5a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vavrinecz=20P=C3=A9ter?= Date: Thu, 6 Feb 2025 18:33:51 +0100 Subject: [PATCH 4/5] modified grid to 2x2 --- src/styles.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/styles.css b/src/styles.css index cb9a90d..c2a6d46 100644 --- a/src/styles.css +++ b/src/styles.css @@ -876,8 +876,7 @@ form > span { #challenge-grid { display: grid; - /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: none; + grid-template-columns: 1fr 1fr; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From 3a852785e2e16448fb87a928c0fd3729bdacc9f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vavrinecz=20P=C3=A9ter?= Date: Thu, 6 Feb 2025 18:41:16 +0100 Subject: [PATCH 5/5] improve form validation --- src/script.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/script.js b/src/script.js index 529f585..c9621f1 100644 --- a/src/script.js +++ b/src/script.js @@ -25,11 +25,14 @@ addEventListener("submit", (event) => { let email = document.getElementById("email").value; - // TODO: Show Correct Status Messages on Signup Form - // 1. successful signup - // 2. empty email - // 3. taken email - // 4. repeat email + if (email === "") { + renderEmailEmptyError(); + } else if (usersTable.find(user => user.username === email)) { + renderEmailTakenError(); + } else { + renderSuccess(); + usersTable.push({ username: email }); + } }); let toggleNav = () => {