ClassNotFound Exceptions when trying to get EurekaBootApp run

[aburghcap]

Starter seems to have compatibility issues with current Spring Boot and Spring Cloud.
Trying to solve them on my second try following devon microservices guide

a) devonfw-version is expression, should be constant:
[WARNING] 'version' contains an expression but should be a constant. @ com.capgemini.devonfw:devonfw-bom:${devonfw.version}, C:\DevonOO\workspaces\microservice-fork.ws\devon\bom\pom.xml, line 12
...
when doing
mvn --projects bom,modules/microservices/microservices,modules/microservices/microservice-archetype,modules/microservices/microservice-infra-archetype --also-make install

b) ClassNotFoundException: org.springframework.boot.context.embedded.FilterRegistrationBean and similar

[aburghcap]

original messages attached from mvn install:
mvn-install.log

[aburghcap]

messages attached from mvn generate infra archetype:
mvn-generate-infra.log

[aburghcap]

Exception from start of EurekaBootApp after mvn install attached:
ClassNotFoundException_EurekaBootApp.log

[aburghcap]

Switching to Spring Cloud Release Edgware and Spring Boot 1.5.9 service-eureka and service-zuul got running :-)
Followed https://projects.spring.io/spring-cloud/#quick-start

[aburghcap]

service-auth build still failed with maven-surefire-plugin:2.12.4:test missing JUnit48+
mvn-install-service-auth-fail.log

[aburghcap]

got service-auth running with changing maven parent also to spring boot as in the other infra modules:

org.springframework.boot spring-boot-starter-parent 1.5.9.RELEASE

[aburghcap]

POST auth-login works.
service-conf / archaius-bootified works.

[aburghcap]

created sampleapp1 - mvn install fails with
The project com.capgemini:sampleapp1:0.1-SNAPSHOT (C:\DevonOO\workspaces\microservice-fork.ws\devon\sampleapp1\pom.xml) has 1 error
'dependencies.dependency.version' for org.springframework.boot:spring-boot-starter-ws:jar is missing. @ line 270, column 17

fixed by adding version to

org.springframework.boot
spring-boot-starter-ws
${spring.boot.version}

[aburghcap]

sampleapp1 mvn install still fails with
[ERROR] Failed to execute goal on project sampleapp1: Could not resolve dependencies for project com.capgemini:sampleapp1:jar:0.1-SNAPSHOT: The following artifacts could not be resolved: com.capgemini
.devonfw.starter:devonfw-microservices-starter:jar:2.2.1-SNAPSHOT, org.springframework.boot:spring-boot-starter-ws:jar:1.5.9.RELEASE: Could not find artifact com.capgemini.devonfw.starter:devonfw-micr
oservices-starter:jar:2.2.1-SNAPSHOT -> [Help 1]

[aburghcap]

replaced dependency spring-boot-starter-ws 1.4... with 1.5.9er spring-boot-starter-web-services
and relocated SpringBootServletInitializer following https://stackoverflow.com/questions/38843015/spring-boot-springbootservletinitializer-is-deprecated

mvn install success!

[aburghcap]

start failed
fixed by
replaced com.capgemini.devonfw.microservices.foo.FooBootApp
with com.capgemini.sampleapp1.SpringBootApp

changed import ServletRegistrationBean to org.springframework.boot.web.servlet.ServletRegistrationBean;

same for import org.springframework.boot.web.servlet.FilterRegistrationBean;

[aburghcap]

start fails with
Caused by: java.lang.Error: Unresolved compilation problems:
The hierarchy of the type JsonWebTokenAuthenticationFilter is inconsistent
The method setExceptionIfHeaderMissing(boolean) is undefined for the type JsonWebTokenAuthenticationFilter
The method setPrincipalRequestHeader(String) is undefined for the type JsonWebTokenAuthenticationFilter
The method doFilter(ServletRequest, ServletResponse, FilterChain) of type JsonWebTokenAuthenticationFilter must override or implement a supertype method
The method doFilter(ServletRequest, ServletResponse, FilterChain) is undefined for the type Object
The method setAuthenticationManager(AuthenticationManager) of type JsonWebTokenAuthenticationFilter must override or implement a supertype method
The method setAuthenticationManager(AuthenticationManager) is undefined for the type Object

currently not detected by Eclipse. So far no idea to solve that

[aburghcap]

@hohwille You know these starters. Can you please try to have a short look on this issue and check whether
a) this is a valid issue and
b) it is worth completing the above work?
Hopefully I get both starters fixed so that I can show the result on Thursday at TH Köln.

[hohwille]

[WARNING] 'version' contains an expression but should be a constant.

You will get many of such warnings in a real project. We use an expression as version on purpose. This is a long discussion ("war") because maven developers did not really care about the release management needs in complex real world projects.
Conclusion: Just ignore this warning. Feel free to raise a MNG issue in mavens JIRA to prevent the warning or lower the severity. Maybe maven 4 or 5 will one day allow to simply omit the version in development pom.xml files and generate it on the fly for consumer POM when installing/deploying.

b) ClassNotFoundException:

Obviously some problem here. I am still not sure if I got everything correct. IMHO there was some dependency conflict in your particular project setup. When it comes to spring and spring-boot updates: This is more than welcome. You are free to provide a PR for oasp4j. If you do not have time, let us know so we can take over what is already planned for OASP.
Is your project also available as OSS (on githhub) so you could provide the link? Otherwise was the update spring-boot-starter-web-services:1.5.9 the only relevant change?

Finally do you want to create an extension of our service-client infrastructure for netflix stack (eureka service discovery)? If so you should plan a PR from the start and begin with a fork of oasp4j and a new feature branch from the start:
https://github.com/oasp-forge/oasp4j-wiki/wiki/oasp-code-contributions

[aburghcap]

ClassNotFound solved. Sampleapp1 stops with exception "hierarchy of the type JsonWebTokenAuthenticationFilter is inconsistent" when starting via commandline java -jar target/sampleapp-bootified.jar. In Eclipse sampleapp1 starts without an exception. Still working on that and plan to create a pull-request on the starter when I got it running.