Add support for NLB with TCP or HTTP health check

Author: snemetz

main.tf

@@ -306,6 +306,31 @@ resource "aws_lb_target_group" "application-https" {
   }
 }
 
+# Build NLB Target Group health check stansa
+locals {
+  health_base = {
+    interval            = "10"
+    port                = "${var.health_check_port}"
+    healthy_threshold   = "${var.health_check_healthy_threshold}"
+    unhealthy_threshold = "${var.health_check_unhealthy_threshold}"
+    protocol            = "${var.health_check_protocol}"
+  }
+
+  http = {
+    path    = "${var.health_check_path}"
+    matcher = "200-399"
+    timeout = "6"
+  }
+
+  h_keys      = "${join(",", keys(local.health_base))}"
+  h_vals      = "${join(",", values(local.health_base))}"
+  http_keys   = "${join(",", keys(local.http))}"
+  http_vals   = "${join(",", values(local.http))}"
+  keys        = "${ var.health_check_protocol == "TCP" ? local.h_keys : "${local.h_keys},${local.http_keys}" }"
+  vals        = "${ var.health_check_protocol == "TCP" ? local.h_vals : "${local.h_vals},${local.http_vals}" }"
+  healthcheck = "${zipmap(split(",", local.keys), split(",", local.vals))}"
+}
+
 resource "aws_lb_target_group" "network" {
   count = "${
     module.enabled.value &&
@@ -317,25 +342,15 @@ resource "aws_lb_target_group" "network" {
     list(element(compact(split(",",local.instance_tcp_ports)), count.index))
     )}"
 
-  port       = "${element(compact(split(",",local.instance_tcp_ports)), count.index)}"
-  protocol   = "TCP"
-  vpc_id     = "${var.vpc_id}"
-  stickiness = []
+  health_check = "${list(local.healthcheck)}"
+  port         = "${element(compact(split(",",local.instance_tcp_ports)), count.index)}"
+  protocol     = "TCP"
+  stickiness   = []
+  tags         = "${module.label.tags}"
+  vpc_id       = "${var.vpc_id}"
 
   #deregistration_delay  = "${}"
   #target_type           = "${}"
-  health_check {
-    interval            = "10"                                      # only 10, 30 valid. Cannot be changed after creation
-    port                = "${var.health_check_port}"
-    healthy_threshold   = "${var.health_check_healthy_threshold}"
-    unhealthy_threshold = "${var.health_check_unhealthy_threshold}"
-    protocol            = "${var.health_check_protocol}"
-    timeout             = "6"                                       # "${var.health_check_timeout}"
-    path                = "${var.health_check_path}"
-    matcher             = "200-399"
-  }
-
-  tags = "${module.label.tags}"
 
   lifecycle {
     create_before_destroy = true

test/main.tf

@@ -34,19 +34,47 @@ module "lb-tcp" {
   #enabled             = false
   health_check_path = "/healthcheck"
 
-  health_check_port    = "3199"
-  security_groups      = ["sg-bef0a5c2"]                                 # Need at least 1
-  lb_protocols         = ["HTTP", "HTTPS"]
-  type                 = "network"
-  subnets              = "${data.aws_subnet_ids.private_subnet_ids.ids}"
-  vpc_id               = "${data.aws_vpc.vpc.id}"
-  ports                = "3000,4000"
-  instance_http_ports  = "80,8080"
-  instance_https_ports = "443"
-  instance_tcp_ports   = ""
-  lb_http_ports        = "80,8080"
-  lb_https_ports       = "443"
-  lb_tcp_ports         = ""
+  health_check_protocol = "HTTP"
+  health_check_port     = "3199"
+  security_groups       = ["sg-bef0a5c2"]                                 # Need at least 1
+  lb_protocols          = ["HTTP", "HTTPS"]
+  type                  = "network"
+  subnets               = "${data.aws_subnet_ids.private_subnet_ids.ids}"
+  vpc_id                = "${data.aws_vpc.vpc.id}"
+  ports                 = "3000,4000"
+  instance_http_ports   = "80,8080"
+  instance_https_ports  = "443"
+  instance_tcp_ports    = ""
+  lb_http_ports         = "80,8080"
+  lb_https_ports        = "443"
+  lb_tcp_ports          = ""
+}
+
+module "lb-tcp-tcp" {
+  source       = "../"
+  name         = "lb-tcp-tcp"
+  environment  = "one"
+  organization = "wiser"
+
+  #attributes      = ["role", "policy", "use", ""]
+  #tags            = "${map("Key", "Value")}"
+  #enabled             = false
+  health_check_path = "/healthcheck"
+
+  health_check_protocol = "TCP"
+  health_check_port     = "3199"
+  security_groups       = ["sg-bef0a5c2"]                                 # Need at least 1
+  lb_protocols          = ["HTTP", "HTTPS"]
+  type                  = "network"
+  subnets               = "${data.aws_subnet_ids.private_subnet_ids.ids}"
+  vpc_id                = "${data.aws_vpc.vpc.id}"
+  ports                 = "3000,4000"
+  instance_http_ports   = "80,8080"
+  instance_https_ports  = "443"
+  instance_tcp_ports    = ""
+  lb_http_ports         = "80,8080"
+  lb_https_ports        = "443"
+  lb_tcp_ports          = ""
 }
 
 module "lb-http" {

test/providers.tf

@@ -1,6 +1,5 @@
 provider "aws" {
-  region  = "${var.region}"
-  version = "1.5"
+  region = "${var.region}"
 
-  # Can not upgrade until bugs introduced in 1.6 are fixed
+  #version = "1.5"
 }

variables.tf

@@ -188,7 +188,9 @@ variable "health_check_interval" {
 
 variable "health_check_matcher" {
   description = "The HTTP codes that are a success when checking TG health."
-  default     = "200-299"                                                    # AWS default is 200-399
+  default     = "200-299"
+
+  # AWS default is 200-399
 }
 
 variable "health_check_path" {