After update privacy link takes button class

[Julix91]

As per #28 buttons can take custom classes

However, the privacy policy page link can be either a normal text link or a button depending on another setting:

It should not take the custom button class unless it actually is a button.

The default button styles already do this correctly.

This was working correctly before the 1.2.49 update.

What that looks like when not expecting it:

Before it was like this:

Based on the re-ordering I'm guessing some other html changed so I'll have to change our styles regardless. Just thinking this likely is applying to someone else out there.

[Julix91]

Relevant code checks if the short-code is already called:

if ( $input['link_position'] === 'message' && strpos( $input['message_text'], '[cookies_policy_link' ) === false )
	$input['message_text'] .= ' [cookies_policy_link]';

and the short-code accepts a class argument

// defaults
		$defaults = array(
			'title'	=> esc_html( $options['see_more_opt']['text'] !== '' ? $options['see_more_opt']['text'] : '➜' ),
			'link'	=> ( $options['see_more_opt']['link_type'] === 'custom' ? $options['see_more_opt']['link'] : get_permalink( $options['see_more_opt']['id'] ) ),
			'class'	=> $options['css_class']
		);
		
		// combine shortcode arguments
		$args = shortcode_atts( $defaults, $args );

So an immediate fix is to just call the shortcode in the message with a parameter (any class will do to avoid the default kicking in) [cookies_policy_link class="text-link"].

However, the menu clearly calls it button class - and there's a button wrapper for buttons and this link is not in it.

Maybe we could document that the short-code takes an optional class parameter?

[Julix91]

As for the alignment issue in the screenshot shown earlier...

The wrapper for the buttons is new - before it was flatter - so I used Grid to style it, which now broke - but it's a good change on your end!

And on mine, this restores what I had:

    #cn-notice-buttons {
        display: contents;
    }

Except for the specificity war. Adding an id in front of the selectors #cookie-notice .cookie-notice-container broke a bunch of my stuff (easily fixed on my end by adding #cookie-notice in front of my styles as well, but annoying).

# is an _ aggressive_ level of specificity even without adding extra class things on top. I'm assuming it's because you use #cookie-notice for JS somewhere? It only has either .cn-bottom or the other one as class. Just give it cookie-notice also as additional class (to use for CSS).

So, in conclusion, managed to resolve the issues I had on my end.

BUT I do recommend changing the styles to be less dramatic so that users can overwrite them more easily if they chose to. :)