test(recovery): distinguish tests for recoverable vs unrecoverable CUP corruptions #7920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierugo-dfinity
changed the title
pierugo-dfinity
added
the
CI_ALL_BAZEL_TARGETS
…riant of same nodes
…overy-tests/soft-vs-hard-cup-corruption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This branch currently has the changes introduced by
pierugo/orchestrator/return-subnet-id. The actual changes of this PR will only contain the contents ofrs/tests/consensusafter the first is merged.This PR introduces a nuance in how we corrupt a CUP: whether we corrupt it in a way that can still determine the subnet or not. If yes, then the recovery should be fairly identical to a normal one: we can use the same nodes and provision SSH keys:
sr_app_recoverable_corrupt_cup_with_chain_keys_test. If not, then we can neither provision SSH keys nor use the same nodes:sr_app_failover_nodes_test.