Remove macro-definition of signed_less_than from X-macro.

And substitute it with a concrete class implementation.

Author: NlightNFotis

src/solvers/smt2_incremental/smt_bit_vector_theory.cpp

@@ -137,3 +137,26 @@ void smt_bit_vector_theoryt::unsigned_greater_than_or_equalt::validate(
 const smt_function_application_termt::factoryt<
   smt_bit_vector_theoryt::unsigned_greater_than_or_equalt>
   smt_bit_vector_theoryt::unsigned_greater_than_or_equal{};
+
+const char *smt_bit_vector_theoryt::signed_less_thant::identifier()
+{
+  return "bvslt";
+}
+
+smt_sortt smt_bit_vector_theoryt::signed_less_thant::return_sort(
+  const smt_termt &lhs,
+  const smt_termt &rhs)
+{
+  return smt_bool_sortt{};
+}
+
+void smt_bit_vector_theoryt::signed_less_thant::validate(
+  const smt_termt &lhs,
+  const smt_termt &rhs)
+{
+  validate_bit_vector_predicate_arguments(lhs, rhs);
+}
+
+const smt_function_application_termt::factoryt<
+  smt_bit_vector_theoryt::signed_less_thant>
+  smt_bit_vector_theoryt::signed_less_than{};

src/solvers/smt2_incremental/smt_bit_vector_theory.def

@@ -3,7 +3,6 @@
 /// [X-macro](https://en.wikipedia.org/wiki/X_Macro) pattern. These define the
 /// set of bitvector theory functions which are implemented and it is used to
 /// automate repetitive parts of the implementation.
-SMT_BITVECTOR_THEORY_PREDICATE(bvslt, signed_less_than)
 SMT_BITVECTOR_THEORY_PREDICATE(bvsle, signed_less_than_or_equal)
 SMT_BITVECTOR_THEORY_PREDICATE(bvsgt, signed_greater_than)
 SMT_BITVECTOR_THEORY_PREDICATE(bvsge, signed_greater_than_or_equal)

src/solvers/smt2_incremental/smt_bit_vector_theory.h

@@ -59,6 +59,15 @@ class smt_bit_vector_theoryt
   static const smt_function_application_termt::factoryt<
     unsigned_greater_than_or_equalt>
     unsigned_greater_than_or_equal;
+
+  struct signed_less_thant final
+  {
+    static const char *identifier();
+    static smt_sortt return_sort(const smt_termt &lhs, const smt_termt &rhs);
+    static void validate(const smt_termt &lhs, const smt_termt &rhs);
+  };
+  static const smt_function_application_termt::factoryt<signed_less_thant>
+    signed_less_than;
 };
 
 #endif // CPROVER_SOLVERS_SMT2_INCREMENTAL_SMT_BIT_VECTOR_THEORY_H