Skip to content

Commit db9b588

Browse files
authored
Merge pull request #45 from sbillinge/patch_glob
fix: remove glob of home in image-loader
2 parents 2c02eb3 + bebec81 commit db9b588

File tree

3 files changed

+29
-11
lines changed

3 files changed

+29
-11
lines changed

news/patch_glob.rst

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
**Added:**
2+
3+
* <news item>
4+
5+
**Changed:**
6+
7+
* <news item>
8+
9+
**Deprecated:**
10+
11+
* <news item>
12+
13+
**Removed:**
14+
15+
* Removed glob of user home in load-image
16+
17+
**Fixed:**
18+
19+
* <news item>
20+
21+
**Security:**
22+
23+
* <news item>

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ template = "{tag}"
4242
dev_template = "{tag}"
4343
dirty_template = "{tag}"
4444

45+
[tool.setuptools]
46+
package-dir = {"" = "src"}
47+
4548
[tool.setuptools.packages.find]
4649
where = ["src"] # list of folders that contain the packages (["."] by default)
4750
include = ["*"] # package names should match these glob patterns (["*"] by default)

src/diffpy/srxplanar/loadimage.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -73,21 +73,13 @@ def load_image(self, filename):
7373
:param filename: str or Path, image file name or path
7474
:return: 2D ndarray, flipped image array
7575
"""
76-
filename = Path(
77-
filename
78-
).expanduser() # handle "~", make it a Path object
79-
if filename.exists():
80-
filenamefull = filename
81-
else:
82-
found_files = list(Path.home().rglob(filename.name))
83-
filenamefull = found_files[0] if found_files else None
84-
85-
if filenamefull is None or not filenamefull.exists():
76+
filenamefull = Path(filename).resolve()
77+
78+
if not filenamefull.exists():
8679
raise FileNotFoundError(
8780
f"Error: file not found: {filename}, "
8881
f"Please rerun specifying a valid filename."
8982
)
90-
return np.zeros((100, 100))
9183

9284
image = np.zeros((100, 100))
9385
for _ in range(10): # retry 10 times (5 seconds total)

0 commit comments

Comments
 (0)