WIP: refactor

Author: Flink

spec/lib/docker_manager/upgrader_spec.rb

@@ -9,41 +9,63 @@
   fab!(:user, :admin)
 
   let(:repo_path) { Rails.root.to_s }
-  let(:from_version) { "abc123" }
+  let(:from_version) { "2025.12" }
   let(:repo) do
     instance_double(
       DockerManager::GitRepo,
       path: repo_path,
       name: "discourse",
       start_upgrading: true,
       stop_upgrading: true,
-      latest_local_commit: "abc123",
+      latest_local_commit: "2025.12",
       tracking_ref: "origin/main",
       upstream_branch: "origin/main",
       has_local_main?: true,
       detached_head?: false,
     )
   end
-  let(:web_server_adapter) do
-    instance_double(
-      DockerManager::PitchforkAdapter,
-      min_workers: 1,
-      server_name: "Pitchfork",
-      launcher_pid: 1000,
-      master_pid: 1001,
-      workers: [2001, 2002, 2003],
-      reload: true,
-      scale_down_workers: true,
-      scale_up_workers: true,
-      clear_restart_flag: true,
-    )
+
+  describe "#web_server" do
+    context "when unicorn is running" do
+      before do
+        allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f '^unicorn[^_]'").and_return(
+          "1234",
+        )
+      end
+
+      it "uses UnicornAdapter" do
+        expect(upgrader.web_server).to be_a_kind_of(DockerManager::UnicornAdapter)
+      end
+    end
+
+    context "when pitchfork is running" do
+      before do
+        allow_any_instance_of(Kernel).to receive(:`).with("pgrep -f '^unicorn[^_]'").and_return("")
+      end
+
+      it "uses PitchforkAdapter" do
+        expect(upgrader.web_server).to be_a_kind_of(DockerManager::PitchforkAdapter)
+      end
+    end
   end
 
   describe "#upgrade" do
+    let(:launcher_pid) { 1000 }
+    let(:master_pid) { 1001 }
+    let(:workers) { [2001, 2002, 2003] }
+
     before do
-      allow(DockerManager::PitchforkAdapter).to receive(:new).and_return(web_server_adapter)
-      allow_any_instance_of(described_class).to receive(:`).with(/pgrep/).and_return("")
+      allow_any_instance_of(Kernel).to receive(:`).with(/pgrep/).and_return("")
       allow(Open3).to receive(:popen2e).and_yield([], [], OpenStruct.new(value: 0))
+      allow(upgrader.web_server).to receive_messages(
+        launcher_pid:,
+        master_pid:,
+        workers:,
+        scale_down_workers: nil,
+        reload: nil,
+        clear_restart_flag: nil,
+        scale_up_workers: nil,
+      )
     end
 
     context "when a repo fails to start upgrading" do
@@ -55,53 +77,23 @@
     end
 
     context "when not enough workers are running" do
-      let(:web_server_adapter) do
-        instance_double(
-          DockerManager::PitchforkAdapter,
-          min_workers: 1,
-          server_name: "Pitchfork",
-          launcher_pid: 1000,
-          master_pid: 1001,
-          workers: [2001],
-          clear_restart_flag: true,
-        )
-      end
+      let(:workers) { [2001] }
 
       it "raises an error" do
         expect { upgrader.upgrade }.to raise_error("Not enough workers")
       end
     end
 
     context "when launcher process is missing" do
-      let(:web_server_adapter) do
-        instance_double(
-          DockerManager::PitchforkAdapter,
-          min_workers: 1,
-          server_name: "Pitchfork",
-          launcher_pid: 0,
-          master_pid: 1001,
-          workers: [2001, 2002],
-          clear_restart_flag: true,
-        )
-      end
+      let(:launcher_pid) { 0 }
 
       it "raises an error" do
         expect { upgrader.upgrade }.to raise_error("No Pitchfork master or launcher")
       end
     end
 
     context "when master process is missing" do
-      let(:web_server_adapter) do
-        instance_double(
-          DockerManager::PitchforkAdapter,
-          min_workers: 1,
-          server_name: "Pitchfork",
-          launcher_pid: 1000,
-          master_pid: 0,
-          workers: [2001, 2002],
-          clear_restart_flag: true,
-        )
-      end
+      let(:master_pid) { 0 }
 
       it "raises an error" do
         expect { upgrader.upgrade }.to raise_error("No Pitchfork master or launcher")
@@ -111,12 +103,12 @@
     context "with valid configuration" do
       it "scales down workers" do
         upgrader.upgrade
-        expect(web_server_adapter).to have_received(:scale_down_workers).with(2)
+        expect(upgrader.web_server).to have_received(:scale_down_workers).with(2)
       end
 
       it "reloads the web server to free memory" do
         upgrader.upgrade
-        expect(web_server_adapter).to have_received(:reload).twice
+        expect(upgrader.web_server).to have_received(:reload).twice
       end
 
       it "runs git fetch and reset commands" do
@@ -165,7 +157,7 @@
 
       it "clears the restart flag" do
         upgrader.upgrade
-        expect(web_server_adapter).to have_received(:clear_restart_flag)
+        expect(upgrader.web_server).to have_received(:clear_restart_flag)
       end
     end
 
@@ -257,33 +249,7 @@
 
       it "scales workers back up" do
         expect { upgrader.upgrade }.to raise_error(RuntimeError)
-        expect(web_server_adapter).to have_received(:scale_up_workers).with(2)
-      end
-    end
-  end
-
-  describe "web_server_adapter selection" do
-    context "when unicorn is running" do
-      before do
-        allow_any_instance_of(described_class).to receive(:`).with(
-          "pgrep -f '^unicorn[^_]'",
-        ).and_return("1234")
-      end
-
-      it "uses UnicornAdapter" do
-        expect(upgrader.web_server).to be_a_kind_of(DockerManager::UnicornAdapter)
-      end
-    end
-
-    context "when pitchfork is running" do
-      before do
-        allow_any_instance_of(described_class).to receive(:`).with(
-          "pgrep -f '^unicorn[^_]'",
-        ).and_return("")
-      end
-
-      it "uses PitchforkAdapter" do
-        expect(upgrader.web_server).to be_a_kind_of(DockerManager::PitchforkAdapter)
+        expect(upgrader.web_server).to have_received(:scale_up_workers).with(2)
       end
     end
   end