Skip to content

Conversation

@garybadwal
Copy link

For fixes: #2267

What I did:

  1. Moved the "How you can help" section above "Schedule" section in the release roadmap page.

How I tested:

  1. I run the server and viewed the page manually. The changes look fine.

<p>The release manager will keep the schedule updated and ensure efficient
routing of issues and reminders for deadlines.</p>
<section id="feature-freeze-alpha-1">
<h3>Feature freeze / Alpha 1</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Feature freeze / Alpha 1", "Beta 1", "RC 1", and "Final" should be updated to be h4 tags as they are subsections of "Process" (h3)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahboyce This is resolved, just updated these in the new commit.

…dated to be h4 tags as they are subsections of "Process" (h3)
@garybadwal
Copy link
Author

@sarahboyce I have updated the PR with requested changes.

@garybadwal garybadwal requested a review from sarahboyce October 26, 2025 12:05
<p>The release manager will keep the schedule updated and ensure efficient
routing of issues and reminders for deadlines.</p>
<section id="feature-freeze-alpha-1">
<h4>Feature freeze / Alpha 1</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h4>Feature freeze / Alpha 1</h3>
<h4>Feature freeze / Alpha 1</h4>

(For all)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahboyce Sorry I missed it 😅, was a bit excited. Updated this in new commit.

@garybadwal
Copy link
Author

@sarahboyce Updated the mistakes can you check once again. 😅

@garybadwal garybadwal requested a review from sarahboyce October 26, 2025 14:28
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I believe this resolves the issue

When reviewing the page, I think it looks very strange that the complementary section of the page is completely blank and so at the very least I think we should add to the template:

{% block content-related %}

  <div role="complementary">
    <h2 class="visuallyhidden" id="aside-header">Additional Information</h2>

    {% donation_snippet %}
  </div>

{% endblock %}

If you add this and perhaps squash all commits, I think this is good to go

garybadwal and others added 3 commits October 27, 2025 10:16
Included moving the "Process" section to be a subsection of "Schedule" (so it's a bit less distracting)

Added django-admin-dracula (django#2269)

Bump coverage from 7.10.7 to 7.11.0 in /requirements

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.10.7 to 7.11.0.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.10.7...7.11.0)

---
updated-dependencies:
- dependency-name: coverage
  dependency-version: 7.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump sentry-sdk from 2.41.0 to 2.42.0 in /requirements

Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.41.0 to 2.42.0.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@2.41.0...2.42.0)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-version: 2.42.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Fixed language switcher on search results pages (django#2272)

* Fix language switcher on search results pages

* Makefile delete revert

Added 2025 PyCharm banner

Fixed translations of results count for languages where 0 is singular rather than plural.

"Feature freeze / Alpha 1", "Beta 1", "RC 1", and "Final" has been updated to be h4 tags as they are subsections of "Process" (h3)

Fixed the H4 closing tags

Add complementary content section to roadmap template
@garybadwal garybadwal requested a review from sarahboyce October 27, 2025 04:48
@garybadwal
Copy link
Author

@sarahboyce I have done the changes you requested, also squash all commits, can you give it a review?

Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add {% load fundraising_extras %} near the top of the template (recommend you test the changes)

Also you haven't squashed the commits but we can do this on merging

@garybadwal garybadwal requested a review from sarahboyce October 27, 2025 05:44
@garybadwal
Copy link
Author

@sarahboyce I have added the {% load fundraising_extras %} near the top of the template

Comment on lines 2 to 3
{% load date_format %}
{% load fundraising_extras %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% load date_format %}
{% load fundraising_extras %}
{% load date_format fundraising_extras %}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahboyce This is resolved 👍🏻

@garybadwal
Copy link
Author

@sarahboyce Updated the changes that you requested.

@garybadwal garybadwal requested a review from sarahboyce October 27, 2025 07:21
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

I won't merge the PR as I am not part of the website WG and would let them review and merge

Also a tip, I would refrain from using @ to notify individuals quite so frequently. You have @-ed me 9 times in 2 days. Personally, I consider an @ like a poke. On voluntary projects such as this, I don't recommend doing this at all if someone is actively engaging (responding within a few days). If it has been a few weeks without engagement, then an @ is more appropriate
Note that most folks get notifications on PRs they've engaged with by default unless they have unsubscribed. So the extra comments are not necessary 👍

@garybadwal
Copy link
Author

Thank you sarahboyce, and sorry for '@'. I was excited and was new to open source contributions in here so I didn't know that, I'll keep that noted for next time.

Thank you for your guidance and continuous support 🙌🏻

@garybadwal
Copy link
Author

Sarahboyce out of curiosity, who will be merging this PR?

@sarahboyce sarahboyce requested a review from a team October 30, 2025 04:52
@SaptakS
Copy link
Contributor

SaptakS commented Oct 30, 2025

Thanks for the PR @garybadwal . I will take a look at the PR, review and merge.

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garybadwal
Copy link
Author

garybadwal commented Oct 30, 2025

Thank you so much @SaptakS, excited to get this merged. 🙌🏻🫡

@garybadwal
Copy link
Author

Hi @SaptakS, hope you’re doing well. Just wanted to check when you might be able to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move up the "how you can help" section on release roadmap pages

3 participants