-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Move up the "how you can help" section on release roadmap pages #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…" (so it's a bit less distracting)
…angoproject.com into relase-roadmap-fix
| <p>The release manager will keep the schedule updated and ensure efficient | ||
| routing of issues and reminders for deadlines.</p> | ||
| <section id="feature-freeze-alpha-1"> | ||
| <h3>Feature freeze / Alpha 1</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Feature freeze / Alpha 1", "Beta 1", "RC 1", and "Final" should be updated to be h4 tags as they are subsections of "Process" (h3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahboyce This is resolved, just updated these in the new commit.
…dated to be h4 tags as they are subsections of "Process" (h3)
|
@sarahboyce I have updated the PR with requested changes. |
| <p>The release manager will keep the schedule updated and ensure efficient | ||
| routing of issues and reminders for deadlines.</p> | ||
| <section id="feature-freeze-alpha-1"> | ||
| <h4>Feature freeze / Alpha 1</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h4>Feature freeze / Alpha 1</h3> | |
| <h4>Feature freeze / Alpha 1</h4> |
(For all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahboyce Sorry I missed it 😅, was a bit excited. Updated this in new commit.
|
@sarahboyce Updated the mistakes can you check once again. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I believe this resolves the issue
When reviewing the page, I think it looks very strange that the complementary section of the page is completely blank and so at the very least I think we should add to the template:
{% block content-related %}
<div role="complementary">
<h2 class="visuallyhidden" id="aside-header">Additional Information</h2>
{% donation_snippet %}
</div>
{% endblock %}
If you add this and perhaps squash all commits, I think this is good to go
Included moving the "Process" section to be a subsection of "Schedule" (so it's a bit less distracting) Added django-admin-dracula (django#2269) Bump coverage from 7.10.7 to 7.11.0 in /requirements Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.10.7 to 7.11.0. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.10.7...7.11.0) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Bump sentry-sdk from 2.41.0 to 2.42.0 in /requirements Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.41.0 to 2.42.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.41.0...2.42.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-version: 2.42.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Fixed language switcher on search results pages (django#2272) * Fix language switcher on search results pages * Makefile delete revert Added 2025 PyCharm banner Fixed translations of results count for languages where 0 is singular rather than plural. "Feature freeze / Alpha 1", "Beta 1", "RC 1", and "Final" has been updated to be h4 tags as they are subsections of "Process" (h3) Fixed the H4 closing tags Add complementary content section to roadmap template
…angoproject.com into relase-roadmap-fix
for more information, see https://pre-commit.ci
|
@sarahboyce I have done the changes you requested, also squash all commits, can you give it a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add {% load fundraising_extras %} near the top of the template (recommend you test the changes)
Also you haven't squashed the commits but we can do this on merging
|
@sarahboyce I have added the |
| {% load date_format %} | ||
| {% load fundraising_extras %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {% load date_format %} | |
| {% load fundraising_extras %} | |
| {% load date_format fundraising_extras %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahboyce This is resolved 👍🏻
|
@sarahboyce Updated the changes that you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
I won't merge the PR as I am not part of the website WG and would let them review and merge
Also a tip, I would refrain from using @ to notify individuals quite so frequently. You have @-ed me 9 times in 2 days. Personally, I consider an @ like a poke. On voluntary projects such as this, I don't recommend doing this at all if someone is actively engaging (responding within a few days). If it has been a few weeks without engagement, then an @ is more appropriate
Note that most folks get notifications on PRs they've engaged with by default unless they have unsubscribed. So the extra comments are not necessary 👍
|
Thank you sarahboyce, and sorry for '@'. I was excited and was new to open source contributions in here so I didn't know that, I'll keep that noted for next time. Thank you for your guidance and continuous support 🙌🏻 |
|
Sarahboyce out of curiosity, who will be merging this PR? |
|
Thanks for the PR @garybadwal . I will take a look at the PR, review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you so much @SaptakS, excited to get this merged. 🙌🏻🫡 |
|
Hi @SaptakS, hope you’re doing well. Just wanted to check when you might be able to merge this PR. |
For fixes: #2267
What I did:
How I tested: