From 255fa088fab7850cb918f2fe98c6f30bd01f620c Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sun, 31 Aug 2025 15:18:36 +0200
Subject: [PATCH 1/7] impl

---
 .../UseConditionalAccessCodeFixProvider.cs    | 10 +--
 src/Analyzers.xml                             |  3 +
 .../Analysis/UseConditionalAccessAnalyzer.cs  | 36 +++++++++
 .../CSharp/Extensions/CodeStyleExtensions.cs  |  6 ++
 src/Common/ConfigOptionKeys.Generated.cs      | 79 ++++++++++---------
 src/Common/ConfigOptions.Generated.cs         |  6 ++
 src/ConfigOptions.xml                         |  5 ++
 .../RCS1146UseConditionalAccessTests.cs       | 35 ++++++++
 .../CodeGeneration/CodeGeneration.csproj      |  2 +-
 src/Tools/CodeGenerator/CodeGenerator.csproj  |  2 +-
 .../ConfigurationFileGenerator.csproj         |  2 +-
 src/Tools/Metadata/Metadata.csproj            |  2 +-
 .../MetadataGenerator.csproj                  |  2 +-
 .../src/configurationFiles.generated.ts       |  5 ++
 14 files changed, 146 insertions(+), 49 deletions(-)

diff --git a/src/Analyzers.CodeFixes/CSharp/CodeFixes/UseConditionalAccessCodeFixProvider.cs b/src/Analyzers.CodeFixes/CSharp/CodeFixes/UseConditionalAccessCodeFixProvider.cs
index d43e2a8765..0648ab923d 100644
--- a/src/Analyzers.CodeFixes/CSharp/CodeFixes/UseConditionalAccessCodeFixProvider.cs
+++ b/src/Analyzers.CodeFixes/CSharp/CodeFixes/UseConditionalAccessCodeFixProvider.cs
@@ -79,11 +79,11 @@ private static async Task<Document> UseConditionalAccessAsync(
     {
         SemanticModel semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
 
-        SyntaxKind kind = binaryExpression.Kind();
+        SyntaxKind binaryExpressionKind = binaryExpression.Kind();
 
-        (ExpressionSyntax left, ExpressionSyntax right) = UseConditionalAccessAnalyzer.GetFixableExpressions(binaryExpression, kind, semanticModel, cancellationToken);
+        (ExpressionSyntax left, ExpressionSyntax right) = UseConditionalAccessAnalyzer.GetFixableExpressions(binaryExpression, binaryExpressionKind, semanticModel, cancellationToken);
 
-        NullCheckStyles allowedStyles = (kind == SyntaxKind.LogicalAndExpression)
+        NullCheckStyles allowedStyles = (binaryExpressionKind == SyntaxKind.LogicalAndExpression)
             ? (NullCheckStyles.NotEqualsToNull | NullCheckStyles.IsNotNull)
             : (NullCheckStyles.EqualsToNull | NullCheckStyles.IsNull);
 
@@ -134,12 +134,12 @@ private static async Task<Document> UseConditionalAccessAsync(
             }
             case SyntaxKind.LogicalNotExpression:
             {
-                builder.Append((kind == SyntaxKind.LogicalAndExpression) ? " == false" : " != true");
+                builder.Append((binaryExpressionKind == SyntaxKind.LogicalAndExpression) ? " == false" : " != true");
                 break;
             }
             default:
             {
-                builder.Append((kind == SyntaxKind.LogicalAndExpression) ? " == true" : " != false");
+                builder.Append((binaryExpressionKind == SyntaxKind.LogicalAndExpression) ? " == true" : " != false");
                 break;
             }
         }
diff --git a/src/Analyzers.xml b/src/Analyzers.xml
index 9f23544cd0..8dbaf34c8d 100644
--- a/src/Analyzers.xml
+++ b/src/Analyzers.xml
@@ -4484,6 +4484,9 @@ string s2 = s as string;]]></Before>
     <DefaultSeverity>Info</DefaultSeverity>
     <IsEnabledByDefault>true</IsEnabledByDefault>
     <MinLanguageVersion>6.0</MinLanguageVersion>
+    <ConfigOptions>
+      <Option Key="null_conditional_operator.avoid_negative_boolean_comparison" />
+    </ConfigOptions>
     <Samples>
       <Sample>
         <Before><![CDATA[if (s != null && s.StartsWith("a"))
diff --git a/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs b/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs
index b629f92688..19c50c0296 100644
--- a/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs
+++ b/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs
@@ -126,6 +126,14 @@ private static void AnalyzeBinaryExpression(SyntaxNodeAnalysisContext context)
         if (left is null)
             return;
 
+        bool avoidNegativeBooleanComparison = context.GetAvoidNegativeBooleanComparison();
+
+        if (avoidNegativeBooleanComparison
+            && ShouldBeNegativeBooleanComparison(binaryExpression, right))
+        {
+            return;
+        }
+
         ISymbol operatorSymbol = context.SemanticModel.GetSymbol(binaryExpression, context.CancellationToken);
 
         if (operatorSymbol?.Name == WellKnownMemberNames.BitwiseOrOperatorName)
@@ -456,4 +464,32 @@ bool IsFirstChild(SyntaxNode node)
             return true;
         }
     }
+
+    private static bool ShouldBeNegativeBooleanComparison(ExpressionSyntax binaryExpression, ExpressionSyntax rightExpression)
+    {
+        switch (rightExpression.Kind())
+        {
+            case SyntaxKind.LogicalOrExpression:
+            case SyntaxKind.LogicalAndExpression:
+            case SyntaxKind.BitwiseOrExpression:
+            case SyntaxKind.BitwiseAndExpression:
+            case SyntaxKind.ExclusiveOrExpression:
+            case SyntaxKind.EqualsExpression:
+            case SyntaxKind.NotEqualsExpression:
+            case SyntaxKind.LessThanExpression:
+            case SyntaxKind.LessThanOrEqualExpression:
+            case SyntaxKind.GreaterThanExpression:
+            case SyntaxKind.GreaterThanOrEqualExpression:
+            case SyntaxKind.IsExpression:
+            case SyntaxKind.AsExpression:
+            case SyntaxKind.IsPatternExpression:
+            {
+                return false;
+            }
+            default:
+            {
+                return binaryExpression.IsKind(SyntaxKind.LogicalOrExpression);
+            }
+        }
+    }
 }
diff --git a/src/Common/CSharp/Extensions/CodeStyleExtensions.cs b/src/Common/CSharp/Extensions/CodeStyleExtensions.cs
index 1abfbbab7b..b4a06fafbb 100644
--- a/src/Common/CSharp/Extensions/CodeStyleExtensions.cs
+++ b/src/Common/CSharp/Extensions/CodeStyleExtensions.cs
@@ -211,6 +211,12 @@ public static BlankLineStyle GetBlankLineBetweenSingleLineAccessors(this SyntaxN
         return BlankLineStyle.None;
     }
 
+    public static bool GetAvoidNegativeBooleanComparison(this SyntaxNodeAnalysisContext context)
+    {
+        AnalyzerConfigOptions configOptions = context.GetConfigOptions();
+
+        return ConfigOptions.TryGetValueAsBool(configOptions, ConfigOptions.NullConditionalOperator_AvoidNegativeBooleanComparison, out bool value) && value;
+    }
     public static bool? PreferAnonymousFunctionOrMethodGroup(this SyntaxNodeAnalysisContext context)
     {
         AnalyzerConfigOptions configOptions = context.GetConfigOptions();
diff --git a/src/Common/ConfigOptionKeys.Generated.cs b/src/Common/ConfigOptionKeys.Generated.cs
index d03c51daff..e55c9dfc75 100644
--- a/src/Common/ConfigOptionKeys.Generated.cs
+++ b/src/Common/ConfigOptionKeys.Generated.cs
@@ -6,44 +6,45 @@ namespace Roslynator
 {
     internal static partial class ConfigOptionKeys
     {
-        public const string AccessibilityModifiers                            = "roslynator_accessibility_modifiers";
-        public const string AccessorBracesStyle                               = "roslynator_accessor_braces_style";
-        public const string ArrayCreationTypeStyle                            = "roslynator_array_creation_type_style";
-        public const string ArrowTokenNewLine                                 = "roslynator_arrow_token_new_line";
-        public const string BinaryOperatorNewLine                             = "roslynator_binary_operator_new_line";
-        public const string BlankLineAfterFileScopedNamespaceDeclaration      = "roslynator_blank_line_after_file_scoped_namespace_declaration";
-        public const string BlankLineBetweenClosingBraceAndSwitchSection      = "roslynator_blank_line_between_closing_brace_and_switch_section";
-        public const string BlankLineBetweenSingleLineAccessors               = "roslynator_blank_line_between_single_line_accessors";
-        public const string BlankLineBetweenSwitchSections                    = "roslynator_blank_line_between_switch_sections";
-        public const string BlankLineBetweenUsingDirectives                   = "roslynator_blank_line_between_using_directives";
-        public const string BlockBracesStyle                                  = "roslynator_block_braces_style";
-        public const string BodyStyle                                         = "roslynator_body_style";
-        public const string ConditionalOperatorConditionParenthesesStyle      = "roslynator_conditional_operator_condition_parentheses_style";
-        public const string ConditionalOperatorNewLine                        = "roslynator_conditional_operator_new_line";
-        public const string ConfigureAwait                                    = "roslynator_configure_await";
-        public const string DocCommentSummaryStyle                            = "roslynator_doc_comment_summary_style";
-        public const string EmptyStringStyle                                  = "roslynator_empty_string_style";
-        public const string EnumFlagValueStyle                                = "roslynator_enum_flag_value_style";
-        public const string EnumHasFlagStyle                                  = "roslynator_enum_has_flag_style";
-        public const string EqualsTokenNewLine                                = "roslynator_equals_token_new_line";
-        public const string InfiniteLoopStyle                                 = "roslynator_infinite_loop_style";
-        public const string MaxLineLength                                     = "roslynator_max_line_length";
-        public const string NewLineAtEndOfFile                                = "roslynator_new_line_at_end_of_file";
-        public const string NewLineBeforeWhileInDoStatement                   = "roslynator_new_line_before_while_in_do_statement";
-        public const string NullCheckStyle                                    = "roslynator_null_check_style";
-        public const string NullConditionalOperatorNewLine                    = "roslynator_null_conditional_operator_new_line";
-        public const string ObjectCreationParenthesesStyle                    = "roslynator_object_creation_parentheses_style";
-        public const string ObjectCreationTypeStyle                           = "roslynator_object_creation_type_style";
-        public const string PrefixFieldIdentifierWithUnderscore               = "roslynator_prefix_field_identifier_with_underscore";
-        public const string SuppressUnityScriptMethods                        = "roslynator_suppress_unity_script_methods";
-        public const string TabLength                                         = "roslynator_tab_length";
-        public const string TrailingCommaStyle                                = "roslynator_trailing_comma_style";
-        public const string UnityCodeAnalysisEnabled                          = "roslynator_unity_code_analysis.enabled";
-        public const string UseAnonymousFunctionOrMethodGroup                 = "roslynator_use_anonymous_function_or_method_group";
-        public const string UseBlockBodyWhenDeclarationSpansOverMultipleLines = "roslynator_use_block_body_when_declaration_spans_over_multiple_lines";
-        public const string UseBlockBodyWhenExpressionSpansOverMultipleLines  = "roslynator_use_block_body_when_expression_spans_over_multiple_lines";
-        public const string UseCollectionExpression                           = "roslynator_use_collection_expression";
-        public const string UseVar                                            = "roslynator_use_var";
-        public const string UseVarInsteadOfImplicitObjectCreation             = "roslynator_use_var_instead_of_implicit_object_creation";
+        public const string AccessibilityModifiers                                 = "roslynator_accessibility_modifiers";
+        public const string AccessorBracesStyle                                    = "roslynator_accessor_braces_style";
+        public const string ArrayCreationTypeStyle                                 = "roslynator_array_creation_type_style";
+        public const string ArrowTokenNewLine                                      = "roslynator_arrow_token_new_line";
+        public const string BinaryOperatorNewLine                                  = "roslynator_binary_operator_new_line";
+        public const string BlankLineAfterFileScopedNamespaceDeclaration           = "roslynator_blank_line_after_file_scoped_namespace_declaration";
+        public const string BlankLineBetweenClosingBraceAndSwitchSection           = "roslynator_blank_line_between_closing_brace_and_switch_section";
+        public const string BlankLineBetweenSingleLineAccessors                    = "roslynator_blank_line_between_single_line_accessors";
+        public const string BlankLineBetweenSwitchSections                         = "roslynator_blank_line_between_switch_sections";
+        public const string BlankLineBetweenUsingDirectives                        = "roslynator_blank_line_between_using_directives";
+        public const string BlockBracesStyle                                       = "roslynator_block_braces_style";
+        public const string BodyStyle                                              = "roslynator_body_style";
+        public const string ConditionalOperatorConditionParenthesesStyle           = "roslynator_conditional_operator_condition_parentheses_style";
+        public const string ConditionalOperatorNewLine                             = "roslynator_conditional_operator_new_line";
+        public const string ConfigureAwait                                         = "roslynator_configure_await";
+        public const string DocCommentSummaryStyle                                 = "roslynator_doc_comment_summary_style";
+        public const string EmptyStringStyle                                       = "roslynator_empty_string_style";
+        public const string EnumFlagValueStyle                                     = "roslynator_enum_flag_value_style";
+        public const string EnumHasFlagStyle                                       = "roslynator_enum_has_flag_style";
+        public const string EqualsTokenNewLine                                     = "roslynator_equals_token_new_line";
+        public const string InfiniteLoopStyle                                      = "roslynator_infinite_loop_style";
+        public const string MaxLineLength                                          = "roslynator_max_line_length";
+        public const string NewLineAtEndOfFile                                     = "roslynator_new_line_at_end_of_file";
+        public const string NewLineBeforeWhileInDoStatement                        = "roslynator_new_line_before_while_in_do_statement";
+        public const string NullCheckStyle                                         = "roslynator_null_check_style";
+        public const string NullConditionalOperator_AvoidNegativeBooleanComparison = "roslynator_null_conditional_operator.avoid_negative_boolean_comparison";
+        public const string NullConditionalOperatorNewLine                         = "roslynator_null_conditional_operator_new_line";
+        public const string ObjectCreationParenthesesStyle                         = "roslynator_object_creation_parentheses_style";
+        public const string ObjectCreationTypeStyle                                = "roslynator_object_creation_type_style";
+        public const string PrefixFieldIdentifierWithUnderscore                    = "roslynator_prefix_field_identifier_with_underscore";
+        public const string SuppressUnityScriptMethods                             = "roslynator_suppress_unity_script_methods";
+        public const string TabLength                                              = "roslynator_tab_length";
+        public const string TrailingCommaStyle                                     = "roslynator_trailing_comma_style";
+        public const string UnityCodeAnalysisEnabled                               = "roslynator_unity_code_analysis.enabled";
+        public const string UseAnonymousFunctionOrMethodGroup                      = "roslynator_use_anonymous_function_or_method_group";
+        public const string UseBlockBodyWhenDeclarationSpansOverMultipleLines      = "roslynator_use_block_body_when_declaration_spans_over_multiple_lines";
+        public const string UseBlockBodyWhenExpressionSpansOverMultipleLines       = "roslynator_use_block_body_when_expression_spans_over_multiple_lines";
+        public const string UseCollectionExpression                                = "roslynator_use_collection_expression";
+        public const string UseVar                                                 = "roslynator_use_var";
+        public const string UseVarInsteadOfImplicitObjectCreation                  = "roslynator_use_var_instead_of_implicit_object_creation";
     }
 }
\ No newline at end of file
diff --git a/src/Common/ConfigOptions.Generated.cs b/src/Common/ConfigOptions.Generated.cs
index 556a34bd13..8069b0d699 100644
--- a/src/Common/ConfigOptions.Generated.cs
+++ b/src/Common/ConfigOptions.Generated.cs
@@ -159,6 +159,12 @@ public static partial class ConfigOptions
             defaultValuePlaceholder: "equality_operator|pattern_matching", 
             description:             "Use equality operator or pattern matching as a null check");
 
+        public static readonly ConfigOptionDescriptor NullConditionalOperator_AvoidNegativeBooleanComparison = new(
+            key:                     ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, 
+            defaultValue:            "true", 
+            defaultValuePlaceholder: "", 
+            description:             "Do not suggest to use null-conditional operator when result would be `... != true/false`");
+
         public static readonly ConfigOptionDescriptor NullConditionalOperatorNewLine = new(
             key:                     ConfigOptionKeys.NullConditionalOperatorNewLine, 
             defaultValue:            null, 
diff --git a/src/ConfigOptions.xml b/src/ConfigOptions.xml
index 7e43508098..89529598e0 100644
--- a/src/ConfigOptions.xml
+++ b/src/ConfigOptions.xml
@@ -237,6 +237,11 @@
       <Value>when_type_is_obvious</Value>
     </Values>
   </Option>
+    <Option Id="NullConditionalOperator_AvoidNegativeBooleanComparison">
+        <Key>null_conditional_operator.avoid_negative_boolean_comparison</Key>
+        <DefaultValue>true</DefaultValue>
+        <Description>Do not suggest to use null-conditional operator when result would be `... != true/false`</Description>
+    </Option>
   <!--
   <Option Id="">
     <Key></Key>
diff --git a/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs b/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs
index ef1c451928..f3dba54f47 100644
--- a/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs
+++ b/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs
@@ -983,4 +983,39 @@ void M()
 }
 ");
     }
+
+    [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
+    public async Task Test_AvoidNegativeBooleanComparison()
+    {
+        await VerifyNoDiagnosticAsync(@"
+class Foo
+{
+    void M1()
+    {
+        Foo x = null;
+
+        if ([|x == null || x.Equals(x)|]) { }
+
+        if ([|x == default(Foo) || x.Equals(x)|]) { }
+
+        if ([|x == default || x.Equals(x)|]) { }
+
+        if ([|x == null || (x.Equals(x)|])) { }
+
+        if ([|x == null || !x.Equals(x)|]) { }
+
+        if ([|x == null || (!x.Equals(x)|])) { }
+    }
+
+    void M2()
+    {
+        Foo? x = null;
+
+        if ([|x == null || x.Value.Equals(x)|]) { }
+
+        if ([|x == null || !x.Value.Equals(x)|]) { }
+    }
+}
+", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
+    }
 }
diff --git a/src/Tools/CodeGeneration/CodeGeneration.csproj b/src/Tools/CodeGeneration/CodeGeneration.csproj
index 12656c13d3..1dac1d7358 100644
--- a/src/Tools/CodeGeneration/CodeGeneration.csproj
+++ b/src/Tools/CodeGeneration/CodeGeneration.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/Tools/CodeGenerator/CodeGenerator.csproj b/src/Tools/CodeGenerator/CodeGenerator.csproj
index 6a4a16fdbc..e3496cd0a1 100644
--- a/src/Tools/CodeGenerator/CodeGenerator.csproj
+++ b/src/Tools/CodeGenerator/CodeGenerator.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/Tools/ConfigurationFileGenerator/ConfigurationFileGenerator.csproj b/src/Tools/ConfigurationFileGenerator/ConfigurationFileGenerator.csproj
index de103e9207..3221b98d3d 100644
--- a/src/Tools/ConfigurationFileGenerator/ConfigurationFileGenerator.csproj
+++ b/src/Tools/ConfigurationFileGenerator/ConfigurationFileGenerator.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/Tools/Metadata/Metadata.csproj b/src/Tools/Metadata/Metadata.csproj
index 8207189ad7..6617083b3e 100644
--- a/src/Tools/Metadata/Metadata.csproj
+++ b/src/Tools/Metadata/Metadata.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/Tools/MetadataGenerator/MetadataGenerator.csproj b/src/Tools/MetadataGenerator/MetadataGenerator.csproj
index 20474cd697..eb6bf87e75 100644
--- a/src/Tools/MetadataGenerator/MetadataGenerator.csproj
+++ b/src/Tools/MetadataGenerator/MetadataGenerator.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/VisualStudioCode/package/src/configurationFiles.generated.ts b/src/VisualStudioCode/package/src/configurationFiles.generated.ts
index 538f74612f..a6c95c394f 100644
--- a/src/VisualStudioCode/package/src/configurationFiles.generated.ts
+++ b/src/VisualStudioCode/package/src/configurationFiles.generated.ts
@@ -112,6 +112,10 @@ roslynator_analyzers.enabled_by_default = true|false
 #roslynator_null_conditional_operator_new_line = after|before
 # Applicable to: rcs0059
 
+#roslynator_null_conditional_operator.avoid_negative_boolean_comparison = 
+# Default: true
+# Applicable to: rcs1146
+
 #roslynator_object_creation_parentheses_style = include|omit
 # Applicable to: rcs1050
 
@@ -594,6 +598,7 @@ roslynator_analyzers.enabled_by_default = true|false
 
 # Use conditional access
 #dotnet_diagnostic.rcs1146.severity = suggestion
+# Options: roslynator_null_conditional_operator.avoid_negative_boolean_comparison
 
 # Remove redundant cast
 #dotnet_diagnostic.rcs1151.severity = silent

From 79ef1c0d3150588d7648f71cc31499f2a6fdd263 Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sun, 31 Aug 2025 15:22:40 +0200
Subject: [PATCH 2/7] changelog

---
 ChangeLog.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ChangeLog.md b/ChangeLog.md
index 3213038c68..2960907ed6 100644
--- a/ChangeLog.md
+++ b/ChangeLog.md
@@ -27,6 +27,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- Add option `roslynator_nul_conditional_operator.avoid_negative_boolean_comparison` ([PR](https://github.com/dotnet/roslynator/pull/1688))
+  - Do not suggest to use null-conditional operator when result would be `... != true/false`
+  - Applicable for [RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
 - [CLI] Add support for GitLab analyzer reports ([PR](https://github.com/dotnet/roslynator/pull/1633))
 
 ### Fixed

From 5d234c4d67a90bce18be08d4f9cec12d850bb515 Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sun, 31 Aug 2025 15:27:59 +0200
Subject: [PATCH 3/7] fix

---
 src/Tools/CodeGeneration/EditorConfig/EditorConfigGenerator.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Tools/CodeGeneration/EditorConfig/EditorConfigGenerator.cs b/src/Tools/CodeGeneration/EditorConfig/EditorConfigGenerator.cs
index 473264ea24..1927be9099 100644
--- a/src/Tools/CodeGeneration/EditorConfig/EditorConfigGenerator.cs
+++ b/src/Tools/CodeGeneration/EditorConfig/EditorConfigGenerator.cs
@@ -79,7 +79,7 @@ public static string GenerateEditorConfig(RoslynatorMetadata metadata, bool comm
                 w.WriteAnalyzer(
                     analyzer.Id.ToLowerInvariant(),
                     (analyzer.IsEnabledByDefault)
-                        ? ((DiagnosticSeverity)Enum.Parse(typeof(DiagnosticSeverity), analyzer.DefaultSeverity)).ToReportDiagnostic()
+                        ? Enum.Parse<DiagnosticSeverity>(analyzer.DefaultSeverity).ToReportDiagnostic()
                         : ReportDiagnostic.Suppress);
 
                 if (analyzer.ConfigOptions.Count > 0)

From 31810c0a781eb3607e717d1402b0db64712288cc Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sun, 31 Aug 2025 15:43:12 +0200
Subject: [PATCH 4/7] update

---
 src/Common/ConfigOptions.Generated.cs         |  4 +-
 src/ConfigOptions.xml                         |  3 +-
 .../RCS1146UseConditionalAccessTests.cs       | 37 ++++++++++---------
 .../src/configurationFiles.generated.ts       |  4 +-
 4 files changed, 26 insertions(+), 22 deletions(-)

diff --git a/src/Common/ConfigOptions.Generated.cs b/src/Common/ConfigOptions.Generated.cs
index 8069b0d699..ba906549c2 100644
--- a/src/Common/ConfigOptions.Generated.cs
+++ b/src/Common/ConfigOptions.Generated.cs
@@ -161,8 +161,8 @@ public static partial class ConfigOptions
 
         public static readonly ConfigOptionDescriptor NullConditionalOperator_AvoidNegativeBooleanComparison = new(
             key:                     ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, 
-            defaultValue:            "true", 
-            defaultValuePlaceholder: "", 
+            defaultValue:            "false", 
+            defaultValuePlaceholder: "true|false", 
             description:             "Do not suggest to use null-conditional operator when result would be `... != true/false`");
 
         public static readonly ConfigOptionDescriptor NullConditionalOperatorNewLine = new(
diff --git a/src/ConfigOptions.xml b/src/ConfigOptions.xml
index 89529598e0..7a33531856 100644
--- a/src/ConfigOptions.xml
+++ b/src/ConfigOptions.xml
@@ -239,7 +239,8 @@
   </Option>
     <Option Id="NullConditionalOperator_AvoidNegativeBooleanComparison">
         <Key>null_conditional_operator.avoid_negative_boolean_comparison</Key>
-        <DefaultValue>true</DefaultValue>
+        <DefaultValue>false</DefaultValue>
+        <ValuePlaceholder>true|false</ValuePlaceholder>
         <Description>Do not suggest to use null-conditional operator when result would be `... != true/false`</Description>
     </Option>
   <!--
diff --git a/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs b/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs
index f3dba54f47..0b0d7e6926 100644
--- a/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs
+++ b/src/Tests/Analyzers.Tests/RCS1146UseConditionalAccessTests.cs
@@ -209,7 +209,7 @@ void M()
             && f) { }
     }
 }
-""");
+""", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -235,7 +235,7 @@ void M()
         if (x?.Equals(x) == false) { }
     }
 }
-");
+", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -319,7 +319,7 @@ void M()
         if (dic?[0].Equals("x") == false) { }
     }
 }
-""");
+""", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -363,7 +363,7 @@ Foo M()
     Foo M2() => null;
     Foo M3() => null;
 }
-");
+", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -429,7 +429,7 @@ void M()
         if (x?.ToString()?.ToString() != null) { }
     }
 }
-""");
+""", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -488,7 +488,7 @@ void M()
         if (x?.ToString()?.ToString()?.ToString() != null) { }
     }
 }
-");
+", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -527,7 +527,7 @@ void M()
         if (x != null && (x.P != null) is object _) { }
     }
 }
-""");
+""", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
     }
 
     [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseConditionalAccess)]
@@ -994,26 +994,29 @@ void M1()
     {
         Foo x = null;
 
-        if ([|x == null || x.Equals(x)|]) { }
+        if (x == null || x.Equals(x)) { }
 
-        if ([|x == default(Foo) || x.Equals(x)|]) { }
+        if (x == default(Foo) || x.Equals(x)) { }
 
-        if ([|x == default || x.Equals(x)|]) { }
+        if (x == default || x.Equals(x)) { }
 
-        if ([|x == null || (x.Equals(x)|])) { }
+        if (x == null || (x.Equals(x))) { }
 
-        if ([|x == null || !x.Equals(x)|]) { }
+        if (x == null || !x.Equals(x)) { }
 
-        if ([|x == null || (!x.Equals(x)|])) { }
+        if (x == null || (!x.Equals(x))) { }
     }
+}
 
-    void M2()
+struct Foo2
+{
+    void M()
     {
-        Foo? x = null;
+        Foo2? x = null;
 
-        if ([|x == null || x.Value.Equals(x)|]) { }
+        if (x == null || x.Value.Equals(x)) { }
 
-        if ([|x == null || !x.Value.Equals(x)|]) { }
+        if (x == null || !x.Value.Equals(x)) { }
     }
 }
 ", options: Options.AddConfigOption(ConfigOptionKeys.NullConditionalOperator_AvoidNegativeBooleanComparison, true));
diff --git a/src/VisualStudioCode/package/src/configurationFiles.generated.ts b/src/VisualStudioCode/package/src/configurationFiles.generated.ts
index a6c95c394f..abe06c678e 100644
--- a/src/VisualStudioCode/package/src/configurationFiles.generated.ts
+++ b/src/VisualStudioCode/package/src/configurationFiles.generated.ts
@@ -112,8 +112,8 @@ roslynator_analyzers.enabled_by_default = true|false
 #roslynator_null_conditional_operator_new_line = after|before
 # Applicable to: rcs0059
 
-#roslynator_null_conditional_operator.avoid_negative_boolean_comparison = 
-# Default: true
+#roslynator_null_conditional_operator.avoid_negative_boolean_comparison = true|false
+# Default: false
 # Applicable to: rcs1146
 
 #roslynator_object_creation_parentheses_style = include|omit

From c61413e9e268da05181e76614f0e433c04aaeb82 Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sun, 31 Aug 2025 15:49:22 +0200
Subject: [PATCH 5/7] changelog

---
 ChangeLog.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ChangeLog.md b/ChangeLog.md
index 2960907ed6..c2d585680e 100644
--- a/ChangeLog.md
+++ b/ChangeLog.md
@@ -27,7 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Add option `roslynator_nul_conditional_operator.avoid_negative_boolean_comparison` ([PR](https://github.com/dotnet/roslynator/pull/1688))
+- Add option `roslynator_null_conditional_operator.avoid_negative_boolean_comparison` ([PR](https://github.com/dotnet/roslynator/pull/1688))
   - Do not suggest to use null-conditional operator when result would be `... != true/false`
   - Applicable for [RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
 - [CLI] Add support for GitLab analyzer reports ([PR](https://github.com/dotnet/roslynator/pull/1633))

From 4c234420359716eef8f26b4d877577767eb489ec Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sun, 31 Aug 2025 16:11:35 +0200
Subject: [PATCH 6/7] update

---
 .../CSharp/Analysis/UseConditionalAccessAnalyzer.cs   |  8 +++-----
 src/Common/CSharp/Extensions/CodeStyleExtensions.cs   | 11 +++++------
 2 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs b/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs
index 19c50c0296..1eb0a9bdde 100644
--- a/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs
+++ b/src/Analyzers/CSharp/Analysis/UseConditionalAccessAnalyzer.cs
@@ -126,10 +126,8 @@ private static void AnalyzeBinaryExpression(SyntaxNodeAnalysisContext context)
         if (left is null)
             return;
 
-        bool avoidNegativeBooleanComparison = context.GetAvoidNegativeBooleanComparison();
-
-        if (avoidNegativeBooleanComparison
-            && ShouldBeNegativeBooleanComparison(binaryExpression, right))
+        if (context.GetConfigOptions().AvoidNegativeBooleanComparison()
+            && WillBeConvertedToNegativeBooleanComparison(binaryExpression, right))
         {
             return;
         }
@@ -465,7 +463,7 @@ bool IsFirstChild(SyntaxNode node)
         }
     }
 
-    private static bool ShouldBeNegativeBooleanComparison(ExpressionSyntax binaryExpression, ExpressionSyntax rightExpression)
+    private static bool WillBeConvertedToNegativeBooleanComparison(ExpressionSyntax binaryExpression, ExpressionSyntax rightExpression)
     {
         switch (rightExpression.Kind())
         {
diff --git a/src/Common/CSharp/Extensions/CodeStyleExtensions.cs b/src/Common/CSharp/Extensions/CodeStyleExtensions.cs
index b4a06fafbb..3fb9d2401d 100644
--- a/src/Common/CSharp/Extensions/CodeStyleExtensions.cs
+++ b/src/Common/CSharp/Extensions/CodeStyleExtensions.cs
@@ -211,12 +211,6 @@ public static BlankLineStyle GetBlankLineBetweenSingleLineAccessors(this SyntaxN
         return BlankLineStyle.None;
     }
 
-    public static bool GetAvoidNegativeBooleanComparison(this SyntaxNodeAnalysisContext context)
-    {
-        AnalyzerConfigOptions configOptions = context.GetConfigOptions();
-
-        return ConfigOptions.TryGetValueAsBool(configOptions, ConfigOptions.NullConditionalOperator_AvoidNegativeBooleanComparison, out bool value) && value;
-    }
     public static bool? PreferAnonymousFunctionOrMethodGroup(this SyntaxNodeAnalysisContext context)
     {
         AnalyzerConfigOptions configOptions = context.GetConfigOptions();
@@ -627,4 +621,9 @@ private static bool TryGetNewLinePosition(
         newLinePosition = NewLinePosition.None;
         return false;
     }
+
+    public static bool AvoidNegativeBooleanComparison(this AnalyzerConfigOptions configOptions)
+    {
+        return ConfigOptions.TryGetValueAsBool(configOptions, ConfigOptions.NullConditionalOperator_AvoidNegativeBooleanComparison, out bool value) && value;
+    }
 }

From f75ea381433e0905d98d313ee4435513fb16ecd1 Mon Sep 17 00:00:00 2001
From: Josef Pihrt <josef@pihrt.net>
Date: Sat, 22 Nov 2025 21:37:24 +0100
Subject: [PATCH 7/7] changelog

---
 ChangeLog.md | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/ChangeLog.md b/ChangeLog.md
index bbdb2cfb22..715694531b 100644
--- a/ChangeLog.md
+++ b/ChangeLog.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add option `roslynator_null_conditional_operator.avoid_negative_boolean_comparison` ([PR](https://github.com/dotnet/roslynator/pull/1688))
+  - Do not suggest to use null-conditional operator when result would be `... != true/false`
+  - Applicable for [RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
+
 ### Fixed
 
 - Fix analyzer [RCS1172](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1172) ([PR](https://github.com/dotnet/roslynator/pull/1710))
@@ -40,9 +46,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Add option `roslynator_null_conditional_operator.avoid_negative_boolean_comparison` ([PR](https://github.com/dotnet/roslynator/pull/1688))
-  - Do not suggest to use null-conditional operator when result would be `... != true/false`
-  - Applicable for [RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
 - [CLI] Add support for GitLab analyzer reports ([PR](https://github.com/dotnet/roslynator/pull/1633))
 
 ### Fixed