Replace usages of templating mechanism inside msbuild code paths with GenerateFileFromTemplate

[ViktorHofer]

With dotnet/arcade#7403 merged, dotnet/runtime can use the GenerateFileFromTemplate task to generate files based on templates from within msbuild. Some code places that would benefit from this:

• runtime/eng/testing/tests.targets

  Lines 96 to 98 in ccec848

  	<GenerateRunScript RunCommands="@(RunScriptCommands)"
  	TemplatePath="$(RunScriptInputPath)"
  	OutputPath="$(RunScriptOutputPath)" />

• runtime/src/tests/Common/CLRTest.Execute.Batch.targets

  Line 63 in b13715b

  <Target Name="GenerateBatchExecutionScript"

• runtime/src/libraries/pkg/test/testPackages.proj

  Lines 118 to 123 in e25f14b

  	<!-- Generate project.csproj from template. -->
  	<MakeDir Directories="$(_projectDir)" />
  	<WriteLinesToFile
  	File="$(_projectFile)"
  	Lines="$([System.IO.File]::ReadAllText('$(ProjectTemplate)').Replace('{PackageId}', $(_packageId)).Replace('{PackageVersion}', $(_packageVersion)).Replace('{TargetFrameworks}', $(_projectTFMs)).Replace('{NetCoreAppCurrent}', $(NetCoreAppCurrent)).Replace('{NetCoreAppCurrentVersion}', $(NetCoreAppCurrentVersion)).Replace('{MicrosoftNetCoreAppFrameworkName}', $(MicrosoftNetCoreAppFrameworkName)).Replace('{MicrosoftNetCoreAppRefPackDir}', $(MicrosoftNetCoreAppRefPackDir)).Replace('{RestoreAdditionalProjectSources}', $(ArtifactsPackagesDir)).Replace('{RestorePackagesPath}', $(TestPackageDir)))"
  	Overwrite="true" />

• runtime/eng/testing/linker/trimmingTests.targets

  Lines 69 to 86 in e25f14b

  	<MakeDir Directories="$(_projectDir)" />
  	<WriteLinesToFile File="$(_projectFile)"
  	Lines="$([System.IO.File]::ReadAllText('$(ProjectTemplate)')
  	.Replace('{MicrosoftNETCoreAppVersion}', '$(MicrosoftNETCoreAppVersion)')
  	.Replace('{NetCoreAppCurrent}', '$(NetCoreAppCurrent)')
  	.Replace('{NetCoreAppMaximumVersion}', '$(NetCoreAppMaximumVersion)')
  	.Replace('{TargetingPackDir}','$(MicrosoftNetCoreAppRefPackDir)')
  	.Replace('{RuntimeIdentifier}','%(TestConsoleApps.TestRuntimeIdentifier)')
  	.Replace('{MicrosoftNETILLinkTasksVersion}', '$(MicrosoftNETILLinkTasksVersion)')
  	.Replace('{ExtraTrimmerArgs}', '%(TestConsoleApps.ExtraTrimmerArgs)')
  	.Replace('{AdditionalProjectReferences}', '$(_additionalProjectReferencesString)')
  	.Replace('{RepositoryEngineeringDir}', '$(RepositoryEngineeringDir)')
  	.Replace('{MonoAOTCompilerDir}', '$(MonoAOTCompilerDir)')
  	.Replace('{MonoProjectRoot}', '$(MonoProjectRoot)')
  	.Replace('{MonoAOTCompilerTasksAssemblyPath}', '$(MonoAOTCompilerTasksAssemblyPath)')
  	.Replace('{WasmAppBuilderTasksAssemblyPath}', '$(WasmAppBuilderTasksAssemblyPath)')
  	.Replace('{MicrosoftNetCoreAppRuntimePackRidDir}', '$(MicrosoftNetCoreAppRuntimePackRidDir)'))"
  	Overwrite="true" />

• runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.json.in

  Line 2 in e25f14b

  "version": "${WorkloadVersion}",

and probably a few others that I that don't know about.

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

With dotnet/arcade#7403 merged, dotnet/runtime can use the GenerateFileFromTemplate task to generate files based on templates from within msbuild. Some code places that would benefit from this:

• runtime/eng/testing/tests.targets

  Lines 96 to 98 in ccec848

  	<GenerateRunScript RunCommands="@(RunScriptCommands)"
  	TemplatePath="$(RunScriptInputPath)"
  	OutputPath="$(RunScriptOutputPath)" />

• runtime/src/tests/Common/CLRTest.Execute.Batch.targets

  Line 63 in b13715b

  <Target Name="GenerateBatchExecutionScript"

• runtime/src/libraries/pkg/test/testPackages.proj

  Lines 118 to 123 in e25f14b

  	<!-- Generate project.csproj from template. -->
  	<MakeDir Directories="$(_projectDir)" />
  	<WriteLinesToFile
  	File="$(_projectFile)"
  	Lines="$([System.IO.File]::ReadAllText('$(ProjectTemplate)').Replace('{PackageId}', $(_packageId)).Replace('{PackageVersion}', $(_packageVersion)).Replace('{TargetFrameworks}', $(_projectTFMs)).Replace('{NetCoreAppCurrent}', $(NetCoreAppCurrent)).Replace('{NetCoreAppCurrentVersion}', $(NetCoreAppCurrentVersion)).Replace('{MicrosoftNetCoreAppFrameworkName}', $(MicrosoftNetCoreAppFrameworkName)).Replace('{MicrosoftNetCoreAppRefPackDir}', $(MicrosoftNetCoreAppRefPackDir)).Replace('{RestoreAdditionalProjectSources}', $(ArtifactsPackagesDir)).Replace('{RestorePackagesPath}', $(TestPackageDir)))"
  	Overwrite="true" />

• runtime/eng/testing/linker/trimmingTests.targets

  Lines 69 to 86 in e25f14b

  	<MakeDir Directories="$(_projectDir)" />
  	<WriteLinesToFile File="$(_projectFile)"
  	Lines="$([System.IO.File]::ReadAllText('$(ProjectTemplate)')
  	.Replace('{MicrosoftNETCoreAppVersion}', '$(MicrosoftNETCoreAppVersion)')
  	.Replace('{NetCoreAppCurrent}', '$(NetCoreAppCurrent)')
  	.Replace('{NetCoreAppMaximumVersion}', '$(NetCoreAppMaximumVersion)')
  	.Replace('{TargetingPackDir}','$(MicrosoftNetCoreAppRefPackDir)')
  	.Replace('{RuntimeIdentifier}','%(TestConsoleApps.TestRuntimeIdentifier)')
  	.Replace('{MicrosoftNETILLinkTasksVersion}', '$(MicrosoftNETILLinkTasksVersion)')
  	.Replace('{ExtraTrimmerArgs}', '%(TestConsoleApps.ExtraTrimmerArgs)')
  	.Replace('{AdditionalProjectReferences}', '$(_additionalProjectReferencesString)')
  	.Replace('{RepositoryEngineeringDir}', '$(RepositoryEngineeringDir)')
  	.Replace('{MonoAOTCompilerDir}', '$(MonoAOTCompilerDir)')
  	.Replace('{MonoProjectRoot}', '$(MonoProjectRoot)')
  	.Replace('{MonoAOTCompilerTasksAssemblyPath}', '$(MonoAOTCompilerTasksAssemblyPath)')
  	.Replace('{WasmAppBuilderTasksAssemblyPath}', '$(WasmAppBuilderTasksAssemblyPath)')
  	.Replace('{MicrosoftNetCoreAppRuntimePackRidDir}', '$(MicrosoftNetCoreAppRuntimePackRidDir)'))"
  	Overwrite="true" />

and probably a few others that I that don't know about.

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure
Milestone:	Future

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

[dotnet-policy-service]

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.