From fbf161c294026f576f3f73ee97278e299cc09153 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Tue, 4 Nov 2025 17:19:59 +0000 Subject: [PATCH 01/21] Update dependencies from https://github.com/dotnet/roslyn build 20250915.8 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25467.18 -> To Version 4.14.0-3.25465.8 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25465.8 --- eng/Version.Details.xml | 22 +++++++++++----------- eng/Versions.props | 8 ++++---- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index fb2c40fedf6190..52e5a4c3797b28 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -360,30 +360,30 @@ https://github.com/dotnet/runtime-assets 7ace84ca21dc53ca1e9c5d6f6d02b8245461eabf - + https://github.com/dotnet/roslyn - dcf9af2b54e4469b94697b1b92d31354ce698f66 + b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef - + https://github.com/dotnet/roslyn - dcf9af2b54e4469b94697b1b92d31354ce698f66 + b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef - + https://github.com/dotnet/roslyn - dcf9af2b54e4469b94697b1b92d31354ce698f66 + b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef - - https://github.com/dotnet/roslyn-analyzers - 16865ea61910500f1022ad2b96c499e5df02c228 + + https://github.com/dotnet/roslyn + b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef https://github.com/dotnet/roslyn-analyzers 16865ea61910500f1022ad2b96c499e5df02c228 - + https://github.com/dotnet/roslyn - dcf9af2b54e4469b94697b1b92d31354ce698f66 + b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef diff --git a/eng/Versions.props b/eng/Versions.props index aced2bc9461ac4..86866d61971c08 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -36,7 +36,7 @@ - 3.11.0-beta1.25173.3 + 3.12.0-beta1.25465.8 9.0.0-preview.25173.3 - 4.12.0-3.25467.18 - 4.12.0-3.25467.18 - 4.12.0-3.25467.18 + 4.14.0-3.25465.8 + 4.14.0-3.25465.8 + 4.14.0-3.25465.8 --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> --- .../src/System/Text/Json/Document/JsonDocument.MetadataDb.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs index dca61c889c89d8..20cdf3775c0a43 100644 --- a/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs +++ b/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs @@ -381,7 +381,7 @@ internal MetadataDb CopySegment(int startIndex, int endIndex) byte[] newDatabase = new byte[length]; _data.AsSpan(startIndex, length).CopyTo(newDatabase); - Span newDbInts = MemoryMarshal.Cast(newDatabase); + Span newDbInts = MemoryMarshal.Cast(newDatabase.AsSpan()); int locationOffset = newDbInts[0]; // Need to nudge one forward to account for the hidden quote on the string. From 46bb931fe20e5c673a48e1f9aabf01d259bf2a84 Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Mon, 10 Nov 2025 15:07:12 -0500 Subject: [PATCH 03/21] Fix conversion error --- .../System.Runtime.Numerics/src/System/Numerics/BigInteger.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs b/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs index e173705da39c47..dced09c94df283 100644 --- a/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs +++ b/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs @@ -384,7 +384,7 @@ public BigInteger(ReadOnlySpan value, bool isUnsigned = false, bool isBigE // The bytes parameter is in little-endian byte order. // We can just copy the bytes directly into the uint array. - value.Slice(0, wholeUInt32Count * 4).CopyTo(MemoryMarshal.AsBytes(val)); + value.Slice(0, wholeUInt32Count * 4).CopyTo(MemoryMarshal.AsBytes(val.AsSpan())); } // In both of the above cases on big-endian architecture, we need to perform From fd0957e8dd2e62ebe202811c08c55ec1da67b661 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Tue, 11 Nov 2025 02:02:35 +0000 Subject: [PATCH 04/21] Update dependencies from https://github.com/dotnet/roslyn build 20251110.12 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25467.18 -> To Version 4.14.0-3.25560.12 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25560.12 --- eng/Version.Details.xml | 20 ++++++++++---------- eng/Versions.props | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 52e5a4c3797b28..068d5d15ffd281 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -360,30 +360,30 @@ https://github.com/dotnet/runtime-assets 7ace84ca21dc53ca1e9c5d6f6d02b8245461eabf - + https://github.com/dotnet/roslyn - b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef + 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 - + https://github.com/dotnet/roslyn - b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef + 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 - + https://github.com/dotnet/roslyn - b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef + 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 - + https://github.com/dotnet/roslyn - b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef + 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 https://github.com/dotnet/roslyn-analyzers 16865ea61910500f1022ad2b96c499e5df02c228 - + https://github.com/dotnet/roslyn - b0a9adbf61d6fb6ef4e53e09555fa6b6f189fcef + 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 diff --git a/eng/Versions.props b/eng/Versions.props index 86866d61971c08..3f3e0b05fd8838 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -36,7 +36,7 @@ - 3.12.0-beta1.25465.8 + 3.12.0-beta1.25560.12 9.0.0-preview.25173.3 - 4.14.0-3.25465.8 - 4.14.0-3.25465.8 - 4.14.0-3.25465.8 + 4.14.0-3.25560.12 + 4.14.0-3.25560.12 + 4.14.0-3.25560.12 --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> --- .../src/System/Net/Http/Headers/HttpHeaders.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs index 03b5934ea38dc1..905250e96a05bd 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs @@ -1205,8 +1205,8 @@ internal static int GetStoreValuesIntoStringArray(HeaderDescriptor descriptor, o } int currentIndex = 0; - ReadStoreValues(values, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); - ReadStoreValues(values, info.RawValue, null, ref currentIndex); + ReadStoreValues(values.AsSpan(), info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); + ReadStoreValues(values.AsSpan(), info.RawValue, null, ref currentIndex); Debug.Assert(currentIndex == length); return length; From 985324a044ef9ff467af6e57c9109251dc5eea44 Mon Sep 17 00:00:00 2001 From: Adeel Mujahid <3840695+am11@users.noreply.github.com> Date: Sat, 2 Nov 2024 09:49:32 +0200 Subject: [PATCH 07/21] Cherry-pick dotnet/roslyn update from .NET 10 Commit message of the cherry-picked commit (note this branch now references newer versions): Update Roslyn to 4.13.0-1.24510.9 (#109467) * Update Roslyn to 4.13.0-1.24510.9 * Update roslyn-analyzers * Fix first-class Span breaks * Remove LangVersion=latest * Fixup more places * Updates and fixes --------- Co-authored-by: Jan Jones --- .../TestCasesRunner/AssemblyChecker.cs | 2 +- .../DependencyInjectionSpecificationTests.cs | 2 +- .../tests/StringValuesTests.cs | 30 +++++++------- .../tests/ImmutableStackTest.cs | 2 +- .../tests/ListDictionaryTests.cs | 4 +- .../Generic/Queue/Queue.Generic.Tests.cs | 1 - .../Generic/Stack/Stack.Generic.Tests.cs | 2 +- .../Composition/CompositionErrorTests.cs | 2 +- .../TraceListenerClassTests.cs | 2 +- .../System.Memory/tests/Memory/CopyTo.cs | 2 +- .../tests/ReadOnlySpan/CopyTo.cs | 2 +- .../System.Memory/tests/Span/CopyTo.cs | 2 +- .../System/Net/Http/Headers/HttpHeaders.cs | 6 +-- .../tests/TensorTests.cs | 40 +++++++++---------- .../System.Diagnostics.Debug.Tests.csproj | 1 + .../System/Globalization/GraphemeBreakTest.cs | 2 +- .../CompilerServices/RuntimeHelpersTests.cs | 11 +++-- 17 files changed, 59 insertions(+), 54 deletions(-) diff --git a/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs b/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs index bbe9184c4d7817..c62434f172dd2f 100644 --- a/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs +++ b/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs @@ -977,7 +977,7 @@ private IEnumerable VerifyReferences (AssemblyDefinition original, Assem .Select (name => name.Name) .ToArray (); - if (!actual.SequenceEqual(expected)) + if (!actual!.SequenceEqual(expected)) yield return $"Expected references do not match actual references:\n\tExpected: {string.Join(", ", expected)}\n\tActual: {string.Join(", ", actual)}"; } diff --git a/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs b/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs index dd910d35e102e8..46381662e03d02 100644 --- a/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs +++ b/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs @@ -900,7 +900,7 @@ public void DisposesInReverseOrderOfCreation() // Assert Assert.Equal(outer, callback.Disposed[0]); - Assert.Equal(multipleServices.Reverse(), callback.Disposed.Skip(1).Take(3).OfType()); + Assert.Equal(Enumerable.Reverse(multipleServices), callback.Disposed.Skip(1).Take(3).OfType()); Assert.Equal(outer.SingleService, callback.Disposed[4]); } diff --git a/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs b/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs index 5a0a0719ccc574..6cb9cb3c808491 100644 --- a/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs +++ b/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs @@ -453,19 +453,19 @@ public void DefaultNullOrEmpty_Concat(StringValues stringValues) { string[] expected = new[] { "abc", "bcd", "foo" }; StringValues expectedStringValues = new StringValues(expected); - Assert.Equal(expected, StringValues.Concat(stringValues, expectedStringValues)); - Assert.Equal(expected, StringValues.Concat(expectedStringValues, stringValues)); - Assert.Equal(expected, StringValues.Concat((string)null, in expectedStringValues)); - Assert.Equal(expected, StringValues.Concat(in expectedStringValues, (string)null)); + Assert.Equal(expected, StringValues.Concat(stringValues, expectedStringValues).ToArray()); + Assert.Equal(expected, StringValues.Concat(expectedStringValues, stringValues).ToArray()); + Assert.Equal(expected, StringValues.Concat((string)null, in expectedStringValues).ToArray()); + Assert.Equal(expected, StringValues.Concat(in expectedStringValues, (string)null).ToArray()); string[] empty = new string[0]; StringValues emptyStringValues = new StringValues(empty); - Assert.Equal(empty, StringValues.Concat(stringValues, StringValues.Empty)); - Assert.Equal(empty, StringValues.Concat(StringValues.Empty, stringValues)); - Assert.Equal(empty, StringValues.Concat(stringValues, new StringValues())); - Assert.Equal(empty, StringValues.Concat(new StringValues(), stringValues)); - Assert.Equal(empty, StringValues.Concat((string)null, in emptyStringValues)); - Assert.Equal(empty, StringValues.Concat(in emptyStringValues, (string)null)); + Assert.Equal(empty, StringValues.Concat(stringValues, StringValues.Empty).ToArray()); + Assert.Equal(empty, StringValues.Concat(StringValues.Empty, stringValues).ToArray()); + Assert.Equal(empty, StringValues.Concat(stringValues, new StringValues()).ToArray()); + Assert.Equal(empty, StringValues.Concat(new StringValues(), stringValues).ToArray()); + Assert.Equal(empty, StringValues.Concat((string)null, in emptyStringValues).ToArray()); + Assert.Equal(empty, StringValues.Concat(in emptyStringValues, (string)null).ToArray()); } [Theory] @@ -475,24 +475,24 @@ public void Concat(StringValues stringValues, string[] array) string[] filled = new[] { "abc", "bcd", "foo" }; string[] expectedPrepended = array.Concat(filled).ToArray(); - Assert.Equal(expectedPrepended, StringValues.Concat(stringValues, new StringValues(filled))); + Assert.Equal(expectedPrepended, StringValues.Concat(stringValues, new StringValues(filled)).ToArray()); string[] expectedAppended = filled.Concat(array).ToArray(); - Assert.Equal(expectedAppended, StringValues.Concat(new StringValues(filled), stringValues)); + Assert.Equal(expectedAppended, StringValues.Concat(new StringValues(filled), stringValues).ToArray()); StringValues values = stringValues; foreach (string s in filled) { values = StringValues.Concat(in values, s); } - Assert.Equal(expectedPrepended, values); + Assert.Equal(expectedPrepended, (string[])values); values = stringValues; - foreach (string s in filled.Reverse()) + foreach (string s in Enumerable.Reverse(filled)) { values = StringValues.Concat(s, in values); } - Assert.Equal(expectedAppended, values); + Assert.Equal(expectedAppended, (string[])values); } [Fact] diff --git a/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs b/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs index 4abd031ed43b2d..397990ee494971 100644 --- a/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs +++ b/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs @@ -305,7 +305,7 @@ public void PeekRef_Empty() protected override IEnumerable GetEnumerableOf(params T[] contents) { ImmutableStack stack = ImmutableStack.Empty; - foreach (T value in contents.Reverse()) + foreach (T value in Enumerable.Reverse(contents)) { stack = stack.Push(value); } diff --git a/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs b/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs index e1e2d9da040da8..abbecf3bd18c1c 100644 --- a/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs +++ b/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs @@ -137,7 +137,7 @@ public static void Set_CustomComparerTest() int visited = s_dictionaryData.Length; - Assert.All(s_dictionaryData.Reverse(), element => + Assert.All(Enumerable.Reverse(s_dictionaryData), element => { string newValue = "new" + element.Value; Assert.True(ld.Contains(element.Key)); @@ -154,7 +154,7 @@ public static void Remove_CustomComparerTest() ObservableStringComparer comparer = new ObservableStringComparer(); ListDictionary ld = Fill(new ListDictionary(comparer), s_dictionaryData); - Assert.All(s_dictionaryData.Reverse(), element => + Assert.All(Enumerable.Reverse(s_dictionaryData), element => { int originalSize = ld.Count; Assert.True(ld.Contains(element.Key)); diff --git a/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs b/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs index 7c900d4c6ef325..e5adef0e878d7a 100644 --- a/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs +++ b/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs @@ -181,7 +181,6 @@ public void Queue_Generic_ToArray_NonWrappedQueue(int count) Queue collection = new Queue(count + 1); AddToCollection(collection, count); T[] elements = collection.ToArray(); - elements.Reverse(); Assert.True(Enumerable.SequenceEqual(elements, collection.ToArray())); } diff --git a/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs b/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs index a3e04713f1d6aa..8c032eff8f7deb 100644 --- a/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs +++ b/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs @@ -80,7 +80,7 @@ public void Stack_Generic_Constructor_IEnumerable(EnumerableType enumerableType, _ = numberOfMatchingElements; IEnumerable enumerable = CreateEnumerable(enumerableType, null, enumerableLength, 0, numberOfDuplicateElements); Stack stack = new Stack(enumerable); - Assert.Equal(enumerable.ToArray().Reverse(), stack.ToArray()); + Assert.Equal(Enumerable.Reverse(enumerable.ToArray()), stack.ToArray()); } [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs index 4dbd14618a3165..0a0b4e7ed09a60 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs @@ -416,7 +416,7 @@ private static CompositionError CreateCompositionError(CompositionErrorId id, st private static CompositionError CreateCompositionError(params string[] messages) { CompositionError error = null; - foreach (string message in messages.Reverse()) + foreach (string message in Enumerable.Reverse(messages)) { CompositionException exception = null; if (error != null) diff --git a/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs b/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs index a2e60be4859335..095bfac1763b70 100644 --- a/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs +++ b/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs @@ -358,7 +358,7 @@ public void WriteFooterTest_LogicalOperationStack() listener.Flush(); Assert.Contains("LogicalOperationStack=", listener.Output); - Assert.Contains(string.Join(", ", items.Reverse()), listener.Output); + Assert.Contains(string.Join(", ", Enumerable.Reverse(items)), listener.Output); } finally { diff --git a/src/libraries/System.Memory/tests/Memory/CopyTo.cs b/src/libraries/System.Memory/tests/Memory/CopyTo.cs index 69f9f1fd2a4423..c88fd64d52e5d4 100644 --- a/src/libraries/System.Memory/tests/Memory/CopyTo.cs +++ b/src/libraries/System.Memory/tests/Memory/CopyTo.cs @@ -41,7 +41,7 @@ public static void TryCopyToArraySegmentImplicit() Memory srcMemory = src; bool success = srcMemory.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src.AsSpan(), segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs b/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs index 578f7867ac96ce..0d297485f7a40f 100644 --- a/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs +++ b/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs @@ -42,7 +42,7 @@ public static void TryCopyToArraySegmentImplicit() ReadOnlySpan srcSpan = new ReadOnlySpan(src); bool success = srcSpan.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src.AsSpan(), segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/CopyTo.cs b/src/libraries/System.Memory/tests/Span/CopyTo.cs index 0e87eea54c61fc..4b10f5d00bdb1e 100644 --- a/src/libraries/System.Memory/tests/Span/CopyTo.cs +++ b/src/libraries/System.Memory/tests/Span/CopyTo.cs @@ -42,7 +42,7 @@ public static void TryCopyToArraySegmentImplicit() Span srcSpan = new Span(src); bool success = srcSpan.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src.AsSpan(), segment); } [Fact] diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs index 905250e96a05bd..ef8b5f06288463 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs @@ -1165,7 +1165,7 @@ internal static void GetStoreValuesAsStringOrStringArray(HeaderDescriptor descri else { Debug.Assert(length > 1, "The header should have been removed when it became empty"); - values = multiValue = new string[length]; + values = (multiValue = new string[length])!; } int currentIndex = 0; @@ -1205,8 +1205,8 @@ internal static int GetStoreValuesIntoStringArray(HeaderDescriptor descriptor, o } int currentIndex = 0; - ReadStoreValues(values.AsSpan(), info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); - ReadStoreValues(values.AsSpan(), info.RawValue, null, ref currentIndex); + ReadStoreValues(values!, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); + ReadStoreValues(values!, info.RawValue, null, ref currentIndex); Debug.Assert(currentIndex == length); return length; diff --git a/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs b/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs index b1ad7a4c2d78cf..357fb4c295f90f 100644 --- a/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs +++ b/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs @@ -684,7 +684,7 @@ public static void TensorMultiplyTests() Tensor t1 = Tensor.Create(Enumerable.Range(0, 3), [3, 1]); Tensor t2 = Tensor.Multiply(t0.AsReadOnlyTensorSpan(), t1); - Assert.Equal([3,3], t2.Lengths.ToArray()); + Assert.Equal([3,3], t2.Lengths); Assert.Equal(0, t2[0, 0]); Assert.Equal(0, t2[0, 1]); Assert.Equal(0, t2[0, 2]); @@ -697,7 +697,7 @@ public static void TensorMultiplyTests() t2 = Tensor.Multiply(t1.AsReadOnlyTensorSpan(), t0); - Assert.Equal([3, 3], t2.Lengths.ToArray()); + Assert.Equal([3, 3], t2.Lengths); Assert.Equal(0, t2[0, 0]); Assert.Equal(0, t2[0, 1]); Assert.Equal(0, t2[0, 2]); @@ -711,7 +711,7 @@ public static void TensorMultiplyTests() t1 = Tensor.Create(Enumerable.Range(0, 9), [3, 3]); t2 = Tensor.Multiply(t0.AsReadOnlyTensorSpan(), t1); - Assert.Equal([3, 3], t2.Lengths.ToArray()); + Assert.Equal([3, 3], t2.Lengths); Assert.Equal(0, t2[0, 0]); Assert.Equal(1, t2[0, 1]); Assert.Equal(4, t2[0, 2]); @@ -729,7 +729,7 @@ public static void TensorBroadcastTests() Tensor t0 = Tensor.Create(Enumerable.Range(0, 3), [1, 3, 1, 1, 1]); Tensor t1 = Tensor.Broadcast(t0, [1, 3, 1, 2, 1]); - Assert.Equal([1, 3, 1, 2, 1], t1.Lengths.ToArray()); + Assert.Equal([1, 3, 1, 2, 1], t1.Lengths); Assert.Equal(0, t1[0, 0, 0, 0, 0]); Assert.Equal(0, t1[0, 0, 0, 1, 0]); @@ -739,7 +739,7 @@ public static void TensorBroadcastTests() Assert.Equal(2, t1[0, 2, 0, 1, 0]); t1 = Tensor.Broadcast(t0, [1, 3, 2, 1, 1]); - Assert.Equal([1, 3, 2, 1, 1], t1.Lengths.ToArray()); + Assert.Equal([1, 3, 2, 1, 1], t1.Lengths); Assert.Equal(0, t1[0, 0, 0, 0, 0]); Assert.Equal(0, t1[0, 0, 1, 0, 0]); @@ -751,7 +751,7 @@ public static void TensorBroadcastTests() t0 = Tensor.Create(Enumerable.Range(0, 3), [1, 3]); t1 = Tensor.Create(Enumerable.Range(0, 3), [3, 1]); var t2 = Tensor.Broadcast(t0, [3, 3]); - Assert.Equal([3, 3], t2.Lengths.ToArray()); + Assert.Equal([3, 3], t2.Lengths); Assert.Equal(0, t2[0, 0]); Assert.Equal(1, t2[0, 1]); @@ -765,7 +765,7 @@ public static void TensorBroadcastTests() t1 = Tensor.Create(Enumerable.Range(0, 3), [3, 1]); t2 = Tensor.Broadcast(t1, [3, 3]); - Assert.Equal([3, 3], t2.Lengths.ToArray()); + Assert.Equal([3, 3], t2.Lengths); Assert.Equal(0, t2[0, 0]); Assert.Equal(0, t2[0, 1]); @@ -789,11 +789,11 @@ public static void TensorBroadcastTests() Assert.Equal(2, s1[2, 2]); var t3 = t2.Slice(0..1, ..); - Assert.Equal([1, 3], t3.Lengths.ToArray()); + Assert.Equal([1, 3], t3.Lengths); t1 = Tensor.Create(Enumerable.Range(0, 3), default); t2 = Tensor.Broadcast(t1, [3, 3]); - Assert.Equal([3, 3], t2.Lengths.ToArray()); + Assert.Equal([3, 3], t2.Lengths); Assert.Equal(0, t2[0, 0]); Assert.Equal(1, t2[0, 1]); @@ -811,15 +811,15 @@ public static void TensorResizeTests() { Tensor t0 = Tensor.Create(Enumerable.Range(0, 8), [2, 2, 2]); var t1 = Tensor.Resize(t0, [1]); - Assert.Equal([1], t1.Lengths.ToArray()); + Assert.Equal([1], t1.Lengths); Assert.Equal(0, t1[0]); t1 = Tensor.Resize(t0, [1, 1]); - Assert.Equal([1, 1], t1.Lengths.ToArray()); + Assert.Equal([1, 1], t1.Lengths); Assert.Equal(0, t1[0, 0]); t1 = Tensor.Resize(t0, [6]); - Assert.Equal([6], t1.Lengths.ToArray()); + Assert.Equal([6], t1.Lengths); Assert.Equal(0, t1[0]); Assert.Equal(1, t1[1]); Assert.Equal(2, t1[2]); @@ -828,7 +828,7 @@ public static void TensorResizeTests() Assert.Equal(5, t1[5]); t1 = Tensor.Resize(t0, [10]); - Assert.Equal([10], t1.Lengths.ToArray()); + Assert.Equal([10], t1.Lengths); Assert.Equal(0, t1[0]); Assert.Equal(1, t1[1]); Assert.Equal(2, t1[2]); @@ -841,7 +841,7 @@ public static void TensorResizeTests() Assert.Equal(0, t1[9]); t1 = Tensor.Resize(t0, [2, 5]); - Assert.Equal([2, 5], t1.Lengths.ToArray()); + Assert.Equal([2, 5], t1.Lengths); Assert.Equal(0, t1[0, 0]); Assert.Equal(1, t1[0, 1]); Assert.Equal(2, t1[0, 2]); @@ -859,8 +859,8 @@ public static void TensorSplitTests() { Tensor t0 = Tensor.Create(Enumerable.Range(0, 8), [2, 2, 2]); var t1 = Tensor.Split(t0, 2, 0); - Assert.Equal([1, 2, 2], t1[0].Lengths.ToArray()); - Assert.Equal([1, 2, 2], t1[1].Lengths.ToArray()); + Assert.Equal([1, 2, 2], t1[0].Lengths); + Assert.Equal([1, 2, 2], t1[1].Lengths); Assert.Equal(0, t1[0][0, 0, 0]); Assert.Equal(1, t1[0][0, 0, 1]); Assert.Equal(2, t1[0][0, 1, 0]); @@ -871,8 +871,8 @@ public static void TensorSplitTests() Assert.Equal(7, t1[1][0, 1, 1]); t1 = Tensor.Split(t0, 2, 1); - Assert.Equal([2, 1, 2], t1[0].Lengths.ToArray()); - Assert.Equal([2, 1, 2], t1[1].Lengths.ToArray()); + Assert.Equal([2, 1, 2], t1[0].Lengths); + Assert.Equal([2, 1, 2], t1[1].Lengths); Assert.Equal(0, t1[0][0, 0, 0]); Assert.Equal(1, t1[0][0, 0, 1]); Assert.Equal(4, t1[0][1, 0, 0]); @@ -883,8 +883,8 @@ public static void TensorSplitTests() Assert.Equal(7, t1[1][1, 0, 1]); t1 = Tensor.Split(t0, 2, 2); - Assert.Equal([2, 2, 1], t1[0].Lengths.ToArray()); - Assert.Equal([2, 2, 1], t1[1].Lengths.ToArray()); + Assert.Equal([2, 2, 1], t1[0].Lengths); + Assert.Equal([2, 2, 1], t1[1].Lengths); Assert.Equal(0, t1[0][0, 0, 0]); Assert.Equal(2, t1[0][0, 1, 0]); Assert.Equal(4, t1[0][1, 0, 0]); diff --git a/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj b/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj index f27284e29a9079..8cd911f50213dc 100644 --- a/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj +++ b/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj @@ -13,6 +13,7 @@ + diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs b/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs index c741edd8829661..e7edba854fae70 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs @@ -141,7 +141,7 @@ public void VisualBasicReverseString() // Arrange string forwardActual = string.Concat(clusters.SelectMany(cluster => cluster).Select(rune => rune.ToString())); - string reverseExpected = string.Concat(clusters.Reverse().SelectMany(cluster => cluster).Select(rune => rune.ToString())); + string reverseExpected = string.Concat(Enumerable.Reverse(clusters).SelectMany(cluster => cluster).Select(rune => rune.ToString())); // Act diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs index 13ce28e4f233cd..8c9f6ea247c580 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs @@ -391,10 +391,10 @@ public static void ArrayGetSubArrayTest() Assert.Equal(a, RuntimeHelpers.GetSubArray(a, range)); range = new Range(Index.FromStart(1), Index.FromEnd(5)); - Assert.Equal(new int [] { 2, 3, 4, 5}, RuntimeHelpers.GetSubArray(a, range)); + Assert.Equal(new int[] { 2, 3, 4, 5 }, RuntimeHelpers.GetSubArray(a, range)); range = new Range(Index.FromStart(0), Index.FromStart(a.Length + 1)); - Assert.Throws(() => { int [] array = RuntimeHelpers.GetSubArray(a, range); }); + Assert.Throws(() => { int[] array = RuntimeHelpers.GetSubArray(a, range); }); } [Fact] @@ -454,6 +454,11 @@ private ref struct RefStructWithReferences private ref struct RefStructWithRef { public ref int a; + + internal RefStructWithRef(ref int aVal) + { + a = ref aVal; + } } private ref struct RefStructWithNestedRef @@ -499,7 +504,7 @@ public static unsafe void SizeOf() Assert.Equal(8, RuntimeHelpers.SizeOf(typeof(double).TypeHandle)); Assert.Equal(3, RuntimeHelpers.SizeOf(typeof(Byte3).TypeHandle)); Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(void*).TypeHandle)); - Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(delegate* ).TypeHandle)); + Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(delegate*).TypeHandle)); Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(int).MakeByRefType().TypeHandle)); Assert.Throws(() => RuntimeHelpers.SizeOf(default)); Assert.ThrowsAny(() => RuntimeHelpers.SizeOf(typeof(List<>).TypeHandle)); From 8f7224bbec5351a7be2224019b6adea3a817d1a2 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Thu, 20 Nov 2025 15:36:35 -0800 Subject: [PATCH 08/21] Use Enumerable.Reverse for clarity in PermuteDimensions --- .../src/System/Numerics/Tensors/netcore/TensorExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs index 8c8f02970db525..414e3c55d91f21 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs @@ -2658,7 +2658,7 @@ public static Tensor PermuteDimensions(this Tensor tensor, params ReadO if (dimensions.IsEmpty) { - lengths = tensor._lengths.Reverse().ToArray(); + lengths = Enumerable.Reverse(tensor._lengths).ToArray(); permutation = Enumerable.Range(0, tensor.Rank).Reverse().ToArray(); } else From d3b617afed84d3586a296c8543ef25341c24c2f5 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Fri, 21 Nov 2025 02:03:24 +0000 Subject: [PATCH 09/21] Update dependencies from https://github.com/dotnet/roslyn build 20251120.7 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25569.8 -> To Version 4.14.0-3.25570.7 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25570.7 --- eng/Version.Details.xml | 20 ++++++++++---------- eng/Versions.props | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index dee79849af6584..4423c3fbb40e8e 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -360,30 +360,30 @@ https://github.com/dotnet/runtime-assets 91ea918f8fb26ec1d290283e5c5eeb1b003113da - + https://github.com/dotnet/roslyn - 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 + 8cafac4760a78176ef0e167bea66b97b65437930 - + https://github.com/dotnet/roslyn - 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 + 8cafac4760a78176ef0e167bea66b97b65437930 - + https://github.com/dotnet/roslyn - 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 + 8cafac4760a78176ef0e167bea66b97b65437930 - + https://github.com/dotnet/roslyn - 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 + 8cafac4760a78176ef0e167bea66b97b65437930 https://github.com/dotnet/roslyn-analyzers 16865ea61910500f1022ad2b96c499e5df02c228 - + https://github.com/dotnet/roslyn - 27eff4aab1ec7f7c9e15efcc65b02937023f9b34 + 8cafac4760a78176ef0e167bea66b97b65437930 diff --git a/eng/Versions.props b/eng/Versions.props index 26793143b6b827..597f34b75879c7 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -36,7 +36,7 @@ - 3.12.0-beta1.25560.12 + 3.12.0-beta1.25570.7 9.0.0-preview.25173.3 - 4.14.0-3.25560.12 - 4.14.0-3.25560.12 - 4.14.0-3.25560.12 + 4.14.0-3.25570.7 + 4.14.0-3.25570.7 + 4.14.0-3.25570.7 + + + + + + + + + + diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 4423c3fbb40e8e..a7e00edcaed052 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -360,17 +360,17 @@ https://github.com/dotnet/runtime-assets 91ea918f8fb26ec1d290283e5c5eeb1b003113da - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 304768b76e90f5d224b745e3a03cfc5e9509baf6 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 304768b76e90f5d224b745e3a03cfc5e9509baf6 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 304768b76e90f5d224b745e3a03cfc5e9509baf6 https://github.com/dotnet/roslyn @@ -381,9 +381,9 @@ 16865ea61910500f1022ad2b96c499e5df02c228 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 304768b76e90f5d224b745e3a03cfc5e9509baf6 diff --git a/eng/Versions.props b/eng/Versions.props index 597f34b75879c7..d377a4815d1f52 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -44,9 +44,9 @@ Any tools that contribute to the design-time experience should use the MicrosoftCodeAnalysisVersion_LatestVS property above to ensure they do not break the local dev experience. --> - 4.14.0-3.25570.7 - 4.14.0-3.25570.7 - 4.14.0-3.25570.7 + 4.14.0-3.25179.1 + 4.14.0-3.25179.1 + 4.14.0-3.25179.1 - + https://github.com/dotnet/roslyn - 304768b76e90f5d224b745e3a03cfc5e9509baf6 + 8cafac4760a78176ef0e167bea66b97b65437930 diff --git a/eng/Versions.props b/eng/Versions.props index d377a4815d1f52..597f34b75879c7 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -44,9 +44,9 @@ Any tools that contribute to the design-time experience should use the MicrosoftCodeAnalysisVersion_LatestVS property above to ensure they do not break the local dev experience. --> - 4.14.0-3.25179.1 - 4.14.0-3.25179.1 - 4.14.0-3.25179.1 + 4.14.0-3.25570.7 + 4.14.0-3.25570.7 + 4.14.0-3.25570.7 - - - - - - - - - - diff --git a/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs b/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs index c62434f172dd2f..bbe9184c4d7817 100644 --- a/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs +++ b/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/AssemblyChecker.cs @@ -977,7 +977,7 @@ private IEnumerable VerifyReferences (AssemblyDefinition original, Assem .Select (name => name.Name) .ToArray (); - if (!actual!.SequenceEqual(expected)) + if (!actual.SequenceEqual(expected)) yield return $"Expected references do not match actual references:\n\tExpected: {string.Join(", ", expected)}\n\tActual: {string.Join(", ", actual)}"; } diff --git a/src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs b/src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs index 119aa6667de378..c36ce7c6feb0a0 100644 --- a/src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs +++ b/src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs @@ -1848,7 +1848,7 @@ public virtual async Task ReadWrite_MessagesSmallerThanReadBuffer_Success(ReadWr } Assert.Equal(writerBytes.Length, n); - AssertExtensions.SequenceEqual(writerBytes.AsSpan(), readerBytes.AsSpan(0, writerBytes.Length)); + AssertExtensions.SequenceEqual(writerBytes, readerBytes.AsSpan(0, writerBytes.Length)); await writes; } @@ -2985,7 +2985,7 @@ public virtual async Task ZeroByteRead_PerformsZeroByteReadOnUnderlyingStreamWhe if (FlushGuaranteesAllDataWritten) { - AssertExtensions.SequenceEqual(data.AsSpan(), buffer.AsSpan(0, bytesRead)); + AssertExtensions.SequenceEqual(data, buffer.AsSpan(0, bytesRead)); } } } diff --git a/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs b/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs index 46381662e03d02..dd910d35e102e8 100644 --- a/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs +++ b/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/DependencyInjectionSpecificationTests.cs @@ -900,7 +900,7 @@ public void DisposesInReverseOrderOfCreation() // Assert Assert.Equal(outer, callback.Disposed[0]); - Assert.Equal(Enumerable.Reverse(multipleServices), callback.Disposed.Skip(1).Take(3).OfType()); + Assert.Equal(multipleServices.Reverse(), callback.Disposed.Skip(1).Take(3).OfType()); Assert.Equal(outer.SingleService, callback.Disposed[4]); } diff --git a/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs b/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs index 6cb9cb3c808491..5a0a0719ccc574 100644 --- a/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs +++ b/src/libraries/Microsoft.Extensions.Primitives/tests/StringValuesTests.cs @@ -453,19 +453,19 @@ public void DefaultNullOrEmpty_Concat(StringValues stringValues) { string[] expected = new[] { "abc", "bcd", "foo" }; StringValues expectedStringValues = new StringValues(expected); - Assert.Equal(expected, StringValues.Concat(stringValues, expectedStringValues).ToArray()); - Assert.Equal(expected, StringValues.Concat(expectedStringValues, stringValues).ToArray()); - Assert.Equal(expected, StringValues.Concat((string)null, in expectedStringValues).ToArray()); - Assert.Equal(expected, StringValues.Concat(in expectedStringValues, (string)null).ToArray()); + Assert.Equal(expected, StringValues.Concat(stringValues, expectedStringValues)); + Assert.Equal(expected, StringValues.Concat(expectedStringValues, stringValues)); + Assert.Equal(expected, StringValues.Concat((string)null, in expectedStringValues)); + Assert.Equal(expected, StringValues.Concat(in expectedStringValues, (string)null)); string[] empty = new string[0]; StringValues emptyStringValues = new StringValues(empty); - Assert.Equal(empty, StringValues.Concat(stringValues, StringValues.Empty).ToArray()); - Assert.Equal(empty, StringValues.Concat(StringValues.Empty, stringValues).ToArray()); - Assert.Equal(empty, StringValues.Concat(stringValues, new StringValues()).ToArray()); - Assert.Equal(empty, StringValues.Concat(new StringValues(), stringValues).ToArray()); - Assert.Equal(empty, StringValues.Concat((string)null, in emptyStringValues).ToArray()); - Assert.Equal(empty, StringValues.Concat(in emptyStringValues, (string)null).ToArray()); + Assert.Equal(empty, StringValues.Concat(stringValues, StringValues.Empty)); + Assert.Equal(empty, StringValues.Concat(StringValues.Empty, stringValues)); + Assert.Equal(empty, StringValues.Concat(stringValues, new StringValues())); + Assert.Equal(empty, StringValues.Concat(new StringValues(), stringValues)); + Assert.Equal(empty, StringValues.Concat((string)null, in emptyStringValues)); + Assert.Equal(empty, StringValues.Concat(in emptyStringValues, (string)null)); } [Theory] @@ -475,24 +475,24 @@ public void Concat(StringValues stringValues, string[] array) string[] filled = new[] { "abc", "bcd", "foo" }; string[] expectedPrepended = array.Concat(filled).ToArray(); - Assert.Equal(expectedPrepended, StringValues.Concat(stringValues, new StringValues(filled)).ToArray()); + Assert.Equal(expectedPrepended, StringValues.Concat(stringValues, new StringValues(filled))); string[] expectedAppended = filled.Concat(array).ToArray(); - Assert.Equal(expectedAppended, StringValues.Concat(new StringValues(filled), stringValues).ToArray()); + Assert.Equal(expectedAppended, StringValues.Concat(new StringValues(filled), stringValues)); StringValues values = stringValues; foreach (string s in filled) { values = StringValues.Concat(in values, s); } - Assert.Equal(expectedPrepended, (string[])values); + Assert.Equal(expectedPrepended, values); values = stringValues; - foreach (string s in Enumerable.Reverse(filled)) + foreach (string s in filled.Reverse()) { values = StringValues.Concat(s, in values); } - Assert.Equal(expectedAppended, (string[])values); + Assert.Equal(expectedAppended, values); } [Fact] diff --git a/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs b/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs index 397990ee494971..4abd031ed43b2d 100644 --- a/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs +++ b/src/libraries/System.Collections.Immutable/tests/ImmutableStackTest.cs @@ -305,7 +305,7 @@ public void PeekRef_Empty() protected override IEnumerable GetEnumerableOf(params T[] contents) { ImmutableStack stack = ImmutableStack.Empty; - foreach (T value in Enumerable.Reverse(contents)) + foreach (T value in contents.Reverse()) { stack = stack.Push(value); } diff --git a/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs b/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs index abbecf3bd18c1c..e1e2d9da040da8 100644 --- a/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs +++ b/src/libraries/System.Collections.Specialized/tests/ListDictionaryTests.cs @@ -137,7 +137,7 @@ public static void Set_CustomComparerTest() int visited = s_dictionaryData.Length; - Assert.All(Enumerable.Reverse(s_dictionaryData), element => + Assert.All(s_dictionaryData.Reverse(), element => { string newValue = "new" + element.Value; Assert.True(ld.Contains(element.Key)); @@ -154,7 +154,7 @@ public static void Remove_CustomComparerTest() ObservableStringComparer comparer = new ObservableStringComparer(); ListDictionary ld = Fill(new ListDictionary(comparer), s_dictionaryData); - Assert.All(Enumerable.Reverse(s_dictionaryData), element => + Assert.All(s_dictionaryData.Reverse(), element => { int originalSize = ld.Count; Assert.True(ld.Contains(element.Key)); diff --git a/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs b/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs index e5adef0e878d7a..7c900d4c6ef325 100644 --- a/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs +++ b/src/libraries/System.Collections/tests/Generic/Queue/Queue.Generic.Tests.cs @@ -181,6 +181,7 @@ public void Queue_Generic_ToArray_NonWrappedQueue(int count) Queue collection = new Queue(count + 1); AddToCollection(collection, count); T[] elements = collection.ToArray(); + elements.Reverse(); Assert.True(Enumerable.SequenceEqual(elements, collection.ToArray())); } diff --git a/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs b/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs index 8c032eff8f7deb..a3e04713f1d6aa 100644 --- a/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs +++ b/src/libraries/System.Collections/tests/Generic/Stack/Stack.Generic.Tests.cs @@ -80,7 +80,7 @@ public void Stack_Generic_Constructor_IEnumerable(EnumerableType enumerableType, _ = numberOfMatchingElements; IEnumerable enumerable = CreateEnumerable(enumerableType, null, enumerableLength, 0, numberOfDuplicateElements); Stack stack = new Stack(enumerable); - Assert.Equal(Enumerable.Reverse(enumerable.ToArray()), stack.ToArray()); + Assert.Equal(enumerable.ToArray().Reverse(), stack.ToArray()); } [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs index 0a0b4e7ed09a60..4dbd14618a3165 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionErrorTests.cs @@ -416,7 +416,7 @@ private static CompositionError CreateCompositionError(CompositionErrorId id, st private static CompositionError CreateCompositionError(params string[] messages) { CompositionError error = null; - foreach (string message in Enumerable.Reverse(messages)) + foreach (string message in messages.Reverse()) { CompositionException exception = null; if (error != null) diff --git a/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs b/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs index 095bfac1763b70..a2e60be4859335 100644 --- a/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs +++ b/src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests/TraceListenerClassTests.cs @@ -358,7 +358,7 @@ public void WriteFooterTest_LogicalOperationStack() listener.Flush(); Assert.Contains("LogicalOperationStack=", listener.Output); - Assert.Contains(string.Join(", ", Enumerable.Reverse(items)), listener.Output); + Assert.Contains(string.Join(", ", items.Reverse()), listener.Output); } finally { diff --git a/src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/ArraySinglePrimitiveRecord.cs b/src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/ArraySinglePrimitiveRecord.cs index ef2195a342a04d..a28359d9bb13dc 100644 --- a/src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/ArraySinglePrimitiveRecord.cs +++ b/src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/ArraySinglePrimitiveRecord.cs @@ -161,7 +161,7 @@ internal static IReadOnlyList DecodePrimitiveTypes(BinaryReader reader, int c { if (typeof(T) == typeof(short) || typeof(T) == typeof(ushort)) { - Span span = MemoryMarshal.Cast(result.AsSpan()); + Span span = MemoryMarshal.Cast(result); #if NET BinaryPrimitives.ReverseEndianness(span, span); #else @@ -173,7 +173,7 @@ internal static IReadOnlyList DecodePrimitiveTypes(BinaryReader reader, int c } else if (typeof(T) == typeof(int) || typeof(T) == typeof(uint) || typeof(T) == typeof(float)) { - Span span = MemoryMarshal.Cast(result.AsSpan()); + Span span = MemoryMarshal.Cast(result); #if NET BinaryPrimitives.ReverseEndianness(span, span); #else @@ -185,7 +185,7 @@ internal static IReadOnlyList DecodePrimitiveTypes(BinaryReader reader, int c } else if (typeof(T) == typeof(long) || typeof(T) == typeof(ulong) || typeof(T) == typeof(double)) { - Span span = MemoryMarshal.Cast(result.AsSpan()); + Span span = MemoryMarshal.Cast(result); #if NET BinaryPrimitives.ReverseEndianness(span, span); #else @@ -201,7 +201,7 @@ internal static IReadOnlyList DecodePrimitiveTypes(BinaryReader reader, int c { // See DontCastBytesToBooleans test to see what could go wrong. bool[] booleans = (bool[])(object)result; - Span resultAsBytes = MemoryMarshal.AsBytes(result.AsSpan()); + Span resultAsBytes = MemoryMarshal.AsBytes(result); for (int i = 0; i < booleans.Length; i++) { // We don't use the bool array to get the value, as an optimizing compiler or JIT could elide this. diff --git a/src/libraries/System.Linq/tests/RangeTests.cs b/src/libraries/System.Linq/tests/RangeTests.cs index 26ec544f327af7..2e331cfee7ecd7 100644 --- a/src/libraries/System.Linq/tests/RangeTests.cs +++ b/src/libraries/System.Linq/tests/RangeTests.cs @@ -270,7 +270,7 @@ static void Validate(IEnumerable e, int[] expected) list.CopyTo(actual, 1); Assert.Equal(0, actual[0]); Assert.Equal(0, actual[^1]); - AssertExtensions.SequenceEqual(expected.AsSpan(), actual.AsSpan(1, expected.Length)); + AssertExtensions.SequenceEqual(expected, actual.AsSpan(1, expected.Length)); } } } diff --git a/src/libraries/System.Linq/tests/RepeatTests.cs b/src/libraries/System.Linq/tests/RepeatTests.cs index 9ee0d7f68fb146..df8eebda35691e 100644 --- a/src/libraries/System.Linq/tests/RepeatTests.cs +++ b/src/libraries/System.Linq/tests/RepeatTests.cs @@ -282,7 +282,7 @@ static void Validate(IEnumerable e, int[] expected) list.CopyTo(actual, 1); Assert.Equal(0, actual[0]); Assert.Equal(0, actual[^1]); - AssertExtensions.SequenceEqual(expected.AsSpan(), actual.AsSpan(1, expected.Length)); + AssertExtensions.SequenceEqual(expected, actual.AsSpan(1, expected.Length)); } } } diff --git a/src/libraries/System.Memory/tests/Base64Url/Base64UrlUnicodeAPIsUnitTests.cs b/src/libraries/System.Memory/tests/Base64Url/Base64UrlUnicodeAPIsUnitTests.cs index 350a6c3112c11b..0d39bc7854bc24 100644 --- a/src/libraries/System.Memory/tests/Base64Url/Base64UrlUnicodeAPIsUnitTests.cs +++ b/src/libraries/System.Memory/tests/Base64Url/Base64UrlUnicodeAPIsUnitTests.cs @@ -438,7 +438,7 @@ public static void Base64_AllMethodsRoundtripConsistently() Span decodedBytes = new byte[original.Length]; int decoded = Base64Url.DecodeFromChars(encodedArray, decodedBytes); Assert.Equal(original.Length, decoded); - AssertExtensions.SequenceEqual(original.AsSpan(), decodedBytes); + AssertExtensions.SequenceEqual(original, decodedBytes); byte[] actualBytes = new byte[original.Length]; Assert.True(Base64Url.TryDecodeFromChars(encodedSpan, actualBytes, out int bytesWritten)); diff --git a/src/libraries/System.Memory/tests/Memory/CopyTo.cs b/src/libraries/System.Memory/tests/Memory/CopyTo.cs index c88fd64d52e5d4..69f9f1fd2a4423 100644 --- a/src/libraries/System.Memory/tests/Memory/CopyTo.cs +++ b/src/libraries/System.Memory/tests/Memory/CopyTo.cs @@ -41,7 +41,7 @@ public static void TryCopyToArraySegmentImplicit() Memory srcMemory = src; bool success = srcMemory.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src.AsSpan(), segment); + Assert.Equal(src, segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/MemoryMarshal/GetArrayDataReference.cs b/src/libraries/System.Memory/tests/MemoryMarshal/GetArrayDataReference.cs index d76867c5c76820..c3478421c358c1 100644 --- a/src/libraries/System.Memory/tests/MemoryMarshal/GetArrayDataReference.cs +++ b/src/libraries/System.Memory/tests/MemoryMarshal/GetArrayDataReference.cs @@ -90,9 +90,7 @@ public static void GetArrayDataReference_IgnoresArrayVarianceChecks() private sealed class RawObject { - #pragma warning disable CS0649 // Field is never assigned to, and will always have its default value null internal byte Data; - #pragma warning restore CS0649 } } } diff --git a/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs b/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs index 0d297485f7a40f..578f7867ac96ce 100644 --- a/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs +++ b/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs @@ -42,7 +42,7 @@ public static void TryCopyToArraySegmentImplicit() ReadOnlySpan srcSpan = new ReadOnlySpan(src); bool success = srcSpan.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src.AsSpan(), segment); + Assert.Equal(src, segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/CopyTo.cs b/src/libraries/System.Memory/tests/Span/CopyTo.cs index 4b10f5d00bdb1e..0e87eea54c61fc 100644 --- a/src/libraries/System.Memory/tests/Span/CopyTo.cs +++ b/src/libraries/System.Memory/tests/Span/CopyTo.cs @@ -42,7 +42,7 @@ public static void TryCopyToArraySegmentImplicit() Span srcSpan = new Span(src); bool success = srcSpan.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src.AsSpan(), segment); + Assert.Equal(src, segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/SearchValues.cs b/src/libraries/System.Memory/tests/Span/SearchValues.cs index 361830f38364c0..8f39a95bd3c0f4 100644 --- a/src/libraries/System.Memory/tests/Span/SearchValues.cs +++ b/src/libraries/System.Memory/tests/Span/SearchValues.cs @@ -458,7 +458,7 @@ static SearchValuesTestHelper() s_randomLatin1Chars[i] = (char)rng.Next(0, 256); } - rng.NextBytes(MemoryMarshal.Cast(s_randomChars.AsSpan())); + rng.NextBytes(MemoryMarshal.Cast(s_randomChars)); s_randomAsciiBytes = Encoding.ASCII.GetBytes(s_randomAsciiChars); diff --git a/src/libraries/System.Memory/tests/Span/StringSearchValues.cs b/src/libraries/System.Memory/tests/Span/StringSearchValues.cs index f702b0bdcad99d..c0b80b5ab06776 100644 --- a/src/libraries/System.Memory/tests/Span/StringSearchValues.cs +++ b/src/libraries/System.Memory/tests/Span/StringSearchValues.cs @@ -620,7 +620,7 @@ public StringSearchValuesTestHelper(IndexOfAnySearchDelegate expected, SearchVal })); } - rng.NextBytes(MemoryMarshal.Cast(_randomChars.AsSpan())); + rng.NextBytes(MemoryMarshal.Cast(_randomChars)); } public void StressRandomInputs(TimeSpan duration) diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs index ef8b5f06288463..03b5934ea38dc1 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs @@ -1165,7 +1165,7 @@ internal static void GetStoreValuesAsStringOrStringArray(HeaderDescriptor descri else { Debug.Assert(length > 1, "The header should have been removed when it became empty"); - values = (multiValue = new string[length])!; + values = multiValue = new string[length]; } int currentIndex = 0; @@ -1205,8 +1205,8 @@ internal static int GetStoreValuesIntoStringArray(HeaderDescriptor descriptor, o } int currentIndex = 0; - ReadStoreValues(values!, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); - ReadStoreValues(values!, info.RawValue, null, ref currentIndex); + ReadStoreValues(values, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); + ReadStoreValues(values, info.RawValue, null, ref currentIndex); Debug.Assert(currentIndex == length); return length; diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketAsyncEventArgsTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketAsyncEventArgsTest.cs index 8f5cd1c6f0dac2..afd56dfcc9ef76 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketAsyncEventArgsTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketAsyncEventArgsTest.cs @@ -727,7 +727,7 @@ public void AcceptAsync_WithReceiveBuffer_Success() Assert.Equal(acceptBufferDataSize, acceptArgs.BytesTransferred); - AssertExtensions.SequenceEqual(sendBuffer.AsSpan(), acceptArgs.Buffer.AsSpan(0, acceptArgs.BytesTransferred)); + AssertExtensions.SequenceEqual(sendBuffer, acceptArgs.Buffer.AsSpan(0, acceptArgs.BytesTransferred)); } } diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs index 414e3c55d91f21..8c8f02970db525 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs @@ -2658,7 +2658,7 @@ public static Tensor PermuteDimensions(this Tensor tensor, params ReadO if (dimensions.IsEmpty) { - lengths = Enumerable.Reverse(tensor._lengths).ToArray(); + lengths = tensor._lengths.Reverse().ToArray(); permutation = Enumerable.Range(0, tensor.Rank).Reverse().ToArray(); } else diff --git a/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs b/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs index 357fb4c295f90f..b1ad7a4c2d78cf 100644 --- a/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs +++ b/src/libraries/System.Numerics.Tensors/tests/TensorTests.cs @@ -684,7 +684,7 @@ public static void TensorMultiplyTests() Tensor t1 = Tensor.Create(Enumerable.Range(0, 3), [3, 1]); Tensor t2 = Tensor.Multiply(t0.AsReadOnlyTensorSpan(), t1); - Assert.Equal([3,3], t2.Lengths); + Assert.Equal([3,3], t2.Lengths.ToArray()); Assert.Equal(0, t2[0, 0]); Assert.Equal(0, t2[0, 1]); Assert.Equal(0, t2[0, 2]); @@ -697,7 +697,7 @@ public static void TensorMultiplyTests() t2 = Tensor.Multiply(t1.AsReadOnlyTensorSpan(), t0); - Assert.Equal([3, 3], t2.Lengths); + Assert.Equal([3, 3], t2.Lengths.ToArray()); Assert.Equal(0, t2[0, 0]); Assert.Equal(0, t2[0, 1]); Assert.Equal(0, t2[0, 2]); @@ -711,7 +711,7 @@ public static void TensorMultiplyTests() t1 = Tensor.Create(Enumerable.Range(0, 9), [3, 3]); t2 = Tensor.Multiply(t0.AsReadOnlyTensorSpan(), t1); - Assert.Equal([3, 3], t2.Lengths); + Assert.Equal([3, 3], t2.Lengths.ToArray()); Assert.Equal(0, t2[0, 0]); Assert.Equal(1, t2[0, 1]); Assert.Equal(4, t2[0, 2]); @@ -729,7 +729,7 @@ public static void TensorBroadcastTests() Tensor t0 = Tensor.Create(Enumerable.Range(0, 3), [1, 3, 1, 1, 1]); Tensor t1 = Tensor.Broadcast(t0, [1, 3, 1, 2, 1]); - Assert.Equal([1, 3, 1, 2, 1], t1.Lengths); + Assert.Equal([1, 3, 1, 2, 1], t1.Lengths.ToArray()); Assert.Equal(0, t1[0, 0, 0, 0, 0]); Assert.Equal(0, t1[0, 0, 0, 1, 0]); @@ -739,7 +739,7 @@ public static void TensorBroadcastTests() Assert.Equal(2, t1[0, 2, 0, 1, 0]); t1 = Tensor.Broadcast(t0, [1, 3, 2, 1, 1]); - Assert.Equal([1, 3, 2, 1, 1], t1.Lengths); + Assert.Equal([1, 3, 2, 1, 1], t1.Lengths.ToArray()); Assert.Equal(0, t1[0, 0, 0, 0, 0]); Assert.Equal(0, t1[0, 0, 1, 0, 0]); @@ -751,7 +751,7 @@ public static void TensorBroadcastTests() t0 = Tensor.Create(Enumerable.Range(0, 3), [1, 3]); t1 = Tensor.Create(Enumerable.Range(0, 3), [3, 1]); var t2 = Tensor.Broadcast(t0, [3, 3]); - Assert.Equal([3, 3], t2.Lengths); + Assert.Equal([3, 3], t2.Lengths.ToArray()); Assert.Equal(0, t2[0, 0]); Assert.Equal(1, t2[0, 1]); @@ -765,7 +765,7 @@ public static void TensorBroadcastTests() t1 = Tensor.Create(Enumerable.Range(0, 3), [3, 1]); t2 = Tensor.Broadcast(t1, [3, 3]); - Assert.Equal([3, 3], t2.Lengths); + Assert.Equal([3, 3], t2.Lengths.ToArray()); Assert.Equal(0, t2[0, 0]); Assert.Equal(0, t2[0, 1]); @@ -789,11 +789,11 @@ public static void TensorBroadcastTests() Assert.Equal(2, s1[2, 2]); var t3 = t2.Slice(0..1, ..); - Assert.Equal([1, 3], t3.Lengths); + Assert.Equal([1, 3], t3.Lengths.ToArray()); t1 = Tensor.Create(Enumerable.Range(0, 3), default); t2 = Tensor.Broadcast(t1, [3, 3]); - Assert.Equal([3, 3], t2.Lengths); + Assert.Equal([3, 3], t2.Lengths.ToArray()); Assert.Equal(0, t2[0, 0]); Assert.Equal(1, t2[0, 1]); @@ -811,15 +811,15 @@ public static void TensorResizeTests() { Tensor t0 = Tensor.Create(Enumerable.Range(0, 8), [2, 2, 2]); var t1 = Tensor.Resize(t0, [1]); - Assert.Equal([1], t1.Lengths); + Assert.Equal([1], t1.Lengths.ToArray()); Assert.Equal(0, t1[0]); t1 = Tensor.Resize(t0, [1, 1]); - Assert.Equal([1, 1], t1.Lengths); + Assert.Equal([1, 1], t1.Lengths.ToArray()); Assert.Equal(0, t1[0, 0]); t1 = Tensor.Resize(t0, [6]); - Assert.Equal([6], t1.Lengths); + Assert.Equal([6], t1.Lengths.ToArray()); Assert.Equal(0, t1[0]); Assert.Equal(1, t1[1]); Assert.Equal(2, t1[2]); @@ -828,7 +828,7 @@ public static void TensorResizeTests() Assert.Equal(5, t1[5]); t1 = Tensor.Resize(t0, [10]); - Assert.Equal([10], t1.Lengths); + Assert.Equal([10], t1.Lengths.ToArray()); Assert.Equal(0, t1[0]); Assert.Equal(1, t1[1]); Assert.Equal(2, t1[2]); @@ -841,7 +841,7 @@ public static void TensorResizeTests() Assert.Equal(0, t1[9]); t1 = Tensor.Resize(t0, [2, 5]); - Assert.Equal([2, 5], t1.Lengths); + Assert.Equal([2, 5], t1.Lengths.ToArray()); Assert.Equal(0, t1[0, 0]); Assert.Equal(1, t1[0, 1]); Assert.Equal(2, t1[0, 2]); @@ -859,8 +859,8 @@ public static void TensorSplitTests() { Tensor t0 = Tensor.Create(Enumerable.Range(0, 8), [2, 2, 2]); var t1 = Tensor.Split(t0, 2, 0); - Assert.Equal([1, 2, 2], t1[0].Lengths); - Assert.Equal([1, 2, 2], t1[1].Lengths); + Assert.Equal([1, 2, 2], t1[0].Lengths.ToArray()); + Assert.Equal([1, 2, 2], t1[1].Lengths.ToArray()); Assert.Equal(0, t1[0][0, 0, 0]); Assert.Equal(1, t1[0][0, 0, 1]); Assert.Equal(2, t1[0][0, 1, 0]); @@ -871,8 +871,8 @@ public static void TensorSplitTests() Assert.Equal(7, t1[1][0, 1, 1]); t1 = Tensor.Split(t0, 2, 1); - Assert.Equal([2, 1, 2], t1[0].Lengths); - Assert.Equal([2, 1, 2], t1[1].Lengths); + Assert.Equal([2, 1, 2], t1[0].Lengths.ToArray()); + Assert.Equal([2, 1, 2], t1[1].Lengths.ToArray()); Assert.Equal(0, t1[0][0, 0, 0]); Assert.Equal(1, t1[0][0, 0, 1]); Assert.Equal(4, t1[0][1, 0, 0]); @@ -883,8 +883,8 @@ public static void TensorSplitTests() Assert.Equal(7, t1[1][1, 0, 1]); t1 = Tensor.Split(t0, 2, 2); - Assert.Equal([2, 2, 1], t1[0].Lengths); - Assert.Equal([2, 2, 1], t1[1].Lengths); + Assert.Equal([2, 2, 1], t1[0].Lengths.ToArray()); + Assert.Equal([2, 2, 1], t1[1].Lengths.ToArray()); Assert.Equal(0, t1[0][0, 0, 0]); Assert.Equal(2, t1[0][0, 1, 0]); Assert.Equal(4, t1[0][1, 0, 0]); diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/ArrayTests.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/ArrayTests.cs index 2af9744d7b8bc4..c0d7398b039c12 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/ArrayTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/ArrayTests.cs @@ -271,7 +271,7 @@ public void CharArray_Ref() char[] array = CharacterTests.CharacterMappings().Select(o => (char)o[0]).ToArray(); var newArray = array; NativeExportsNE.Arrays.ReverseChars(ref newArray, array.Length); - Assert.Equal(Enumerable.Reverse(array), newArray); + Assert.Equal(array.Reverse(), newArray); } [Fact] diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs index e798e184b6bf76..2aedfde9936f47 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs @@ -171,7 +171,7 @@ public void FromManaged(ManagedType m) {} public nint ToUnmanaged() => default; public void Free() {} public Span GetUnmanagedValuesDestination() => default; - + public ReadOnlySpan GetManagedValuesSource() { throw new NotImplementedException(); @@ -602,6 +602,7 @@ public void FromManaged(ManagedType m, Span buffer) {} public void Free() {} public ReadOnlySpan GetManagedValuesSource() => default; public Span GetUnmanagedValuesDestination() => default; + public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs index cb2c5d8caf10ec..9a72a5fbc4916f 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs @@ -382,6 +382,7 @@ public void FromManaged(ManagedType m, Span b) {} public int ToUnmanaged() => default; public void Free() {} + public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs index b60bb78f2acc2b..fec16b2bc7ff7c 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs @@ -614,6 +614,7 @@ static class MarshallerType public static ReadOnlySpan GetManagedValuesSource(ManagedType m) => default; public static Span GetUnmanagedValuesDestination(nint unmanaged, int numElements) => default; + public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs index 35c90af32f81b2..7d94afb9985f79 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs @@ -363,6 +363,7 @@ class ManagedType {} static class MarshallerType { public static nint ConvertToUnmanaged(ManagedType m, Span b) => default; + public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/CollectionsMarshalTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/CollectionsMarshalTests.cs index 867ee99b852e89..325c9a43de6303 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/CollectionsMarshalTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/CollectionsMarshalTests.cs @@ -527,19 +527,19 @@ public void ListSetCount() CollectionsMarshal.SetCount(list, 3); Assert.Equal(3, list.Count); Assert.Throws(() => list[3]); - AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(list), new int[] { 1, 2, 3 }.AsSpan()); + AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(list), new int[] { 1, 2, 3 }); Assert.True(Unsafe.AreSame(ref intRef, ref MemoryMarshal.GetReference(CollectionsMarshal.AsSpan(list)))); // make sure that size increase preserves content and doesn't clear CollectionsMarshal.SetCount(list, 5); - AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(list), new int[] { 1, 2, 3, 4, 5 }.AsSpan()); + AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(list), new int[] { 1, 2, 3, 4, 5 }); Assert.True(Unsafe.AreSame(ref intRef, ref MemoryMarshal.GetReference(CollectionsMarshal.AsSpan(list)))); // make sure that reallocations preserve content int newCount = list.Capacity * 2; CollectionsMarshal.SetCount(list, newCount); Assert.Equal(newCount, list.Count); - AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(list)[..3], new int[] { 1, 2, 3 }.AsSpan()); + AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(list)[..3], new int[] { 1, 2, 3 }); Assert.True(!Unsafe.AreSame(ref intRef, ref MemoryMarshal.GetReference(CollectionsMarshal.AsSpan(list)))); List listReference = new() { "a", "b", "c", "d", "e" }; @@ -547,12 +547,12 @@ public void ListSetCount() CollectionsMarshal.SetCount(listReference, 3); // verify that reference types aren't cleared - AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(listReference), new string[] { "a", "b", "c" }.AsSpan()); + AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(listReference), new string[] { "a", "b", "c" }); Assert.True(Unsafe.AreSame(ref stringRef, ref MemoryMarshal.GetReference(CollectionsMarshal.AsSpan(listReference)))); CollectionsMarshal.SetCount(listReference, 5); // verify that removed reference types are cleared - AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(listReference), new string[] { "a", "b", "c", null, null }.AsSpan()); + AssertExtensions.SequenceEqual(CollectionsMarshal.AsSpan(listReference), new string[] { "a", "b", "c", null, null }); Assert.True(Unsafe.AreSame(ref stringRef, ref MemoryMarshal.GetReference(CollectionsMarshal.AsSpan(listReference)))); } } diff --git a/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs b/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs index 6a9a0e52afa7fd..e173705da39c47 100644 --- a/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs +++ b/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs @@ -384,7 +384,7 @@ public BigInteger(ReadOnlySpan value, bool isUnsigned = false, bool isBigE // The bytes parameter is in little-endian byte order. // We can just copy the bytes directly into the uint array. - value.Slice(0, wholeUInt32Count * 4).CopyTo(MemoryMarshal.AsBytes(val.AsSpan())); + value.Slice(0, wholeUInt32Count * 4).CopyTo(MemoryMarshal.AsBytes(val)); } // In both of the above cases on big-endian architecture, we need to perform diff --git a/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj b/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj index 8cd911f50213dc..f27284e29a9079 100644 --- a/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj +++ b/src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj @@ -13,7 +13,6 @@ - diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs b/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs index e7edba854fae70..c741edd8829661 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Tests/System/Globalization/GraphemeBreakTest.cs @@ -141,7 +141,7 @@ public void VisualBasicReverseString() // Arrange string forwardActual = string.Concat(clusters.SelectMany(cluster => cluster).Select(rune => rune.ToString())); - string reverseExpected = string.Concat(Enumerable.Reverse(clusters).SelectMany(cluster => cluster).Select(rune => rune.ToString())); + string reverseExpected = string.Concat(clusters.Reverse().SelectMany(cluster => cluster).Select(rune => rune.ToString())); // Act diff --git a/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileStream/ReadAsync.cs b/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileStream/ReadAsync.cs index 40220b45ef875a..d31149d297c5e0 100644 --- a/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileStream/ReadAsync.cs +++ b/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileStream/ReadAsync.cs @@ -123,7 +123,7 @@ public async Task IncompleteReadCantSetPositionBeyondEndOfFile(FileShare fileSha await Task.WhenAll(reads); // but when they are finished, the first buffer should contain valid data: Assert.Equal(fileSize, reads.First().Result); - AssertExtensions.SequenceEqual(content.AsSpan(), buffers.First().AsSpan(0, fileSize)); + AssertExtensions.SequenceEqual(content, buffers.First().AsSpan(0, fileSize)); // and other reads should return 0: Assert.All(reads.Skip(1), read => Assert.Equal(0, read.Result)); // and the Position must be correct: diff --git a/src/libraries/System.Runtime/tests/System.Reflection.Tests/FieldInfoTests.cs b/src/libraries/System.Runtime/tests/System.Reflection.Tests/FieldInfoTests.cs index d8c6425f3b1a72..c3ff97fb342297 100644 --- a/src/libraries/System.Runtime/tests/System.Reflection.Tests/FieldInfoTests.cs +++ b/src/libraries/System.Runtime/tests/System.Reflection.Tests/FieldInfoTests.cs @@ -868,9 +868,7 @@ public static class SettingsForMyTypeThatThrowsInClassInitializer private class RawData { - #pragma warning disable CS0649 // Field is never assigned to, and will always have its default value null public byte Data; - #pragma warning restore CS0649 } } } diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.FromHexString.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.FromHexString.cs index 643971e0163962..fd8bcd6c8e05d0 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.FromHexString.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.FromHexString.cs @@ -42,7 +42,7 @@ private static void TestSequence(byte[] expected, string actual) Assert.Equal(OperationStatus.Done, Convert.FromHexString(actual, tryResult, out int consumed, out int written)); Assert.Equal(fromResult.Length, written); Assert.Equal(actual.Length, consumed); - AssertExtensions.SequenceEqual(expected.AsSpan(), tryResult); + AssertExtensions.SequenceEqual(expected, tryResult); } [Fact] diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs index d737c8978f52c9..27cfa26920e064 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs @@ -713,9 +713,9 @@ public static void Shuffle_Array_Seeded(bool emptyShuffle) Random random = new Random(0x70636A61); int[] items = new int[] { 1, 2, 3, 4 }; random.Shuffle(items); - AssertExtensions.SequenceEqual(stackalloc int[] { 4, 2, 1, 3 }, items.AsSpan()); + AssertExtensions.SequenceEqual(stackalloc int[] { 4, 2, 1, 3 }, items); random.Shuffle(items); - AssertExtensions.SequenceEqual(stackalloc int[] { 2, 3, 4, 1 }, items.AsSpan()); + AssertExtensions.SequenceEqual(stackalloc int[] { 2, 3, 4, 1 }, items); if (emptyShuffle) { @@ -724,7 +724,7 @@ public static void Shuffle_Array_Seeded(bool emptyShuffle) } random.Shuffle(items); - AssertExtensions.SequenceEqual(stackalloc int[] { 1, 4, 3, 2 }, items.AsSpan()); + AssertExtensions.SequenceEqual(stackalloc int[] { 1, 4, 3, 2 }, items); } [Fact] @@ -831,13 +831,13 @@ public static void GetItems_Buffer_Seeded() Span buffer = stackalloc byte[7]; random.GetItems(items, buffer); - AssertExtensions.SequenceEqual(new byte[] { 3, 1, 3, 2, 3, 3, 3 }.AsSpan(), buffer); + AssertExtensions.SequenceEqual(new byte[] { 3, 1, 3, 2, 3, 3, 3 }, buffer); random.GetItems(items, buffer); - AssertExtensions.SequenceEqual(new byte[] { 2, 1, 2, 1, 2, 3, 1 }.AsSpan(), buffer); + AssertExtensions.SequenceEqual(new byte[] { 2, 1, 2, 1, 2, 3, 1 }, buffer); random.GetItems(items, buffer); - AssertExtensions.SequenceEqual(new byte[] { 1, 1, 3, 1, 3, 2, 2 }.AsSpan(), buffer); + AssertExtensions.SequenceEqual(new byte[] { 1, 1, 3, 1, 3, 2, 2 }, buffer); } private static Random Create(bool derived, bool seeded) => diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs index 8c9f6ea247c580..13ce28e4f233cd 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs @@ -391,10 +391,10 @@ public static void ArrayGetSubArrayTest() Assert.Equal(a, RuntimeHelpers.GetSubArray(a, range)); range = new Range(Index.FromStart(1), Index.FromEnd(5)); - Assert.Equal(new int[] { 2, 3, 4, 5 }, RuntimeHelpers.GetSubArray(a, range)); + Assert.Equal(new int [] { 2, 3, 4, 5}, RuntimeHelpers.GetSubArray(a, range)); range = new Range(Index.FromStart(0), Index.FromStart(a.Length + 1)); - Assert.Throws(() => { int[] array = RuntimeHelpers.GetSubArray(a, range); }); + Assert.Throws(() => { int [] array = RuntimeHelpers.GetSubArray(a, range); }); } [Fact] @@ -454,11 +454,6 @@ private ref struct RefStructWithReferences private ref struct RefStructWithRef { public ref int a; - - internal RefStructWithRef(ref int aVal) - { - a = ref aVal; - } } private ref struct RefStructWithNestedRef @@ -504,7 +499,7 @@ public static unsafe void SizeOf() Assert.Equal(8, RuntimeHelpers.SizeOf(typeof(double).TypeHandle)); Assert.Equal(3, RuntimeHelpers.SizeOf(typeof(Byte3).TypeHandle)); Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(void*).TypeHandle)); - Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(delegate*).TypeHandle)); + Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(delegate* ).TypeHandle)); Assert.Equal(nint.Size, RuntimeHelpers.SizeOf(typeof(int).MakeByRefType().TypeHandle)); Assert.Throws(() => RuntimeHelpers.SizeOf(default)); Assert.ThrowsAny(() => RuntimeHelpers.SizeOf(typeof(List<>).TypeHandle)); diff --git a/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Ascii/CaseConversionTests.cs b/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Ascii/CaseConversionTests.cs index ef06e40d1c2dfd..ceb836ff268a41 100644 --- a/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Ascii/CaseConversionTests.cs +++ b/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Ascii/CaseConversionTests.cs @@ -25,20 +25,20 @@ public static void OverlappingBuffers_Throws() Assert.Throws(() => Ascii.ToUpper(byteBuffer, byteBuffer, out _)); Assert.Throws(() => Ascii.ToUpper(byteBuffer.AsSpan(1, 3), byteBuffer.AsSpan(3, 5), out _)); // byte -> char - Assert.Throws(() => Ascii.ToLower(byteBuffer, MemoryMarshal.Cast(byteBuffer.AsSpan()), out _)); - Assert.Throws(() => Ascii.ToLower(byteBuffer, MemoryMarshal.Cast(byteBuffer.AsSpan()).Slice(1, 3), out _)); - Assert.Throws(() => Ascii.ToUpper(byteBuffer, MemoryMarshal.Cast(byteBuffer.AsSpan()), out _)); - Assert.Throws(() => Ascii.ToUpper(byteBuffer, MemoryMarshal.Cast(byteBuffer.AsSpan()).Slice(1, 3), out _)); + Assert.Throws(() => Ascii.ToLower(byteBuffer, MemoryMarshal.Cast(byteBuffer), out _)); + Assert.Throws(() => Ascii.ToLower(byteBuffer, MemoryMarshal.Cast(byteBuffer).Slice(1, 3), out _)); + Assert.Throws(() => Ascii.ToUpper(byteBuffer, MemoryMarshal.Cast(byteBuffer), out _)); + Assert.Throws(() => Ascii.ToUpper(byteBuffer, MemoryMarshal.Cast(byteBuffer).Slice(1, 3), out _)); // char -> char Assert.Throws(() => Ascii.ToLower(charBuffer, charBuffer, out _)); Assert.Throws(() => Ascii.ToLower(charBuffer.AsSpan(1, 3), charBuffer.AsSpan(3, 5), out _)); Assert.Throws(() => Ascii.ToUpper(charBuffer, charBuffer, out _)); Assert.Throws(() => Ascii.ToUpper(charBuffer.AsSpan(1, 3), charBuffer.AsSpan(3, 5), out _)); // char -> byte - Assert.Throws(() => Ascii.ToLower(charBuffer, MemoryMarshal.Cast(charBuffer.AsSpan()), out _)); - Assert.Throws(() => Ascii.ToLower(charBuffer, MemoryMarshal.Cast(charBuffer.AsSpan()).Slice(1, 3), out _)); - Assert.Throws(() => Ascii.ToUpper(charBuffer, MemoryMarshal.Cast(charBuffer.AsSpan()), out _)); - Assert.Throws(() => Ascii.ToUpper(charBuffer, MemoryMarshal.Cast(charBuffer.AsSpan()).Slice(1, 3), out _)); + Assert.Throws(() => Ascii.ToLower(charBuffer, MemoryMarshal.Cast(charBuffer), out _)); + Assert.Throws(() => Ascii.ToLower(charBuffer, MemoryMarshal.Cast(charBuffer).Slice(1, 3), out _)); + Assert.Throws(() => Ascii.ToUpper(charBuffer, MemoryMarshal.Cast(charBuffer), out _)); + Assert.Throws(() => Ascii.ToUpper(charBuffer, MemoryMarshal.Cast(charBuffer).Slice(1, 3), out _)); } private static void VerifySingleChar(OperationStatus status, int value, T expected, T actual, int written) diff --git a/src/libraries/System.Security.Cryptography.Cose/tests/CoseHeaderValueTests.cs b/src/libraries/System.Security.Cryptography.Cose/tests/CoseHeaderValueTests.cs index 2d7c891fecf4e6..b01cbc953177c4 100644 --- a/src/libraries/System.Security.Cryptography.Cose/tests/CoseHeaderValueTests.cs +++ b/src/libraries/System.Security.Cryptography.Cose/tests/CoseHeaderValueTests.cs @@ -97,7 +97,7 @@ public void GetValueAsBytesSucceeds(ContentTestCase @case) Span buffer = new byte[content.Length]; int length = headerValue.GetValueAsBytes(buffer); Assert.Equal(content.Length, length); - AssertExtensions.SequenceEqual(content.AsSpan(), buffer); + AssertExtensions.SequenceEqual(content, buffer); } [Theory] @@ -138,7 +138,7 @@ void Verify(int repetitions) for (int i = 0; i < expectedLength; i+= content.Length) { - AssertExtensions.SequenceEqual(content.AsSpan(), buffer.Slice(i, content.Length)); + AssertExtensions.SequenceEqual(content, buffer.Slice(i, content.Length)); } } } @@ -244,7 +244,7 @@ public void FromBytesSucceeds(ContentTestCase @case) Span buffer = new byte[content.Length]; int length = headerValue.GetValueAsBytes(buffer); - AssertExtensions.SequenceEqual(content.AsSpan(), buffer); + AssertExtensions.SequenceEqual(content, buffer); Assert.Equal(content.Length, length); } diff --git a/src/libraries/System.Security.Cryptography/tests/HashAlgorithmTestDriver.cs b/src/libraries/System.Security.Cryptography/tests/HashAlgorithmTestDriver.cs index 53e6839c5eee42..bbcf23ec0e596e 100644 --- a/src/libraries/System.Security.Cryptography/tests/HashAlgorithmTestDriver.cs +++ b/src/libraries/System.Security.Cryptography/tests/HashAlgorithmTestDriver.cs @@ -66,7 +66,7 @@ private void VerifyOneShotStream(Stream input, string output) Span buffer = stackalloc byte[512 / 8]; int written = HashData(input, buffer); - AssertExtensions.SequenceEqual(expected.AsSpan(), buffer.Slice(0, written)); + AssertExtensions.SequenceEqual(expected, buffer.Slice(0, written)); } private async Task VerifyOneShotStreamAsync(Stream input, string output) @@ -75,7 +75,7 @@ private async Task VerifyOneShotStreamAsync(Stream input, string output) Memory buffer = new byte[512 / 8]; int written = await HashDataAsync(input, buffer, cancellationToken: default); - AssertExtensions.SequenceEqual(expected.AsSpan(), buffer.Slice(0, written).Span); + AssertExtensions.SequenceEqual(expected, buffer.Slice(0, written).Span); } private void VerifyOneShotAllocatingStream(Stream input, string output) @@ -100,7 +100,7 @@ private void VerifyOneShotStream_CryptographicOperations(Stream input, string ou Span buffer = stackalloc byte[512 / 8]; int written = CryptographicOperations.HashData(HashAlgorithm, input, buffer); - AssertExtensions.SequenceEqual(expected.AsSpan(), buffer.Slice(0, written)); + AssertExtensions.SequenceEqual(expected, buffer.Slice(0, written)); } private async Task VerifyOneShotStreamAsync_CryptographicOperations(Stream input, string output) @@ -114,7 +114,7 @@ private async Task VerifyOneShotStreamAsync_CryptographicOperations(Stream input buffer, cancellationToken: default); - AssertExtensions.SequenceEqual(expected.AsSpan(), buffer.Slice(0, written).Span); + AssertExtensions.SequenceEqual(expected, buffer.Slice(0, written).Span); } private void VerifyOneShotAllocatingStream_CryptographicOperations(Stream input, string output) diff --git a/src/libraries/System.Security.Cryptography/tests/HmacTests.cs b/src/libraries/System.Security.Cryptography/tests/HmacTests.cs index a2d649fb3d960a..75a36fba2e879e 100644 --- a/src/libraries/System.Security.Cryptography/tests/HmacTests.cs +++ b/src/libraries/System.Security.Cryptography/tests/HmacTests.cs @@ -136,7 +136,7 @@ protected void VerifyHashDataStream(ReadOnlySpan key, Stream stream, strin int written = HashDataOneShot(key, stream, destination); Assert.Equal(MacSize, written); - AssertExtensions.SequenceEqual(expected.AsSpan(), destination); + AssertExtensions.SequenceEqual(expected, destination); } protected void VerifyHashDataStream_CryptographicOperations(ReadOnlySpan key, Stream stream, string output) @@ -146,7 +146,7 @@ protected void VerifyHashDataStream_CryptographicOperations(ReadOnlySpan k int written = CryptographicOperations.HmacData(HashAlgorithm, key, stream, destination); Assert.Equal(MacSize, written); - AssertExtensions.SequenceEqual(expected.AsSpan(), destination); + AssertExtensions.SequenceEqual(expected, destination); } protected async Task VerifyHashDataStreamAsync(ReadOnlyMemory key, Stream stream, string output) @@ -156,7 +156,7 @@ protected async Task VerifyHashDataStreamAsync(ReadOnlyMemory key, Stream int written = await HashDataOneShotAsync(key, stream, destination, cancellationToken: default); Assert.Equal(MacSize, written); - AssertExtensions.SequenceEqual(expected.AsSpan(), destination.Span); + AssertExtensions.SequenceEqual(expected, destination.Span); } protected async Task VerifyHashDataStreamAsync_CryptographicOperations(ReadOnlyMemory key, Stream stream, string output) @@ -171,7 +171,7 @@ protected async Task VerifyHashDataStreamAsync_CryptographicOperations(ReadOnlyM cancellationToken: default); Assert.Equal(MacSize, written); - AssertExtensions.SequenceEqual(expected.AsSpan(), destination.Span); + AssertExtensions.SequenceEqual(expected, destination.Span); } protected void VerifyHashDataStreamAllocating(byte[] key, Stream stream, string output, bool spanKey) diff --git a/src/libraries/System.Security.Cryptography/tests/KmacTestDriver.cs b/src/libraries/System.Security.Cryptography/tests/KmacTestDriver.cs index 4d7c10b317add9..b508acacc1d6d5 100644 --- a/src/libraries/System.Security.Cryptography/tests/KmacTestDriver.cs +++ b/src/libraries/System.Security.Cryptography/tests/KmacTestDriver.cs @@ -500,7 +500,7 @@ public void GetHashAndReset_ResetWithEmpty() mac = stackalloc byte[OutputLength]; TKmacTrait.AppendData(kmac, "habaneros"u8); TKmacTrait.GetHashAndReset(kmac, mac); - AssertExtensions.SequenceEqual(expected.AsSpan(), mac); + AssertExtensions.SequenceEqual(expected, mac); } } diff --git a/src/libraries/System.Security.Cryptography/tests/X509Certificates/ExtensionsTests/AuthorityKeyIdentifierTests.cs b/src/libraries/System.Security.Cryptography/tests/X509Certificates/ExtensionsTests/AuthorityKeyIdentifierTests.cs index d4fa69b979b0fe..aea774d4b6968d 100644 --- a/src/libraries/System.Security.Cryptography/tests/X509Certificates/ExtensionsTests/AuthorityKeyIdentifierTests.cs +++ b/src/libraries/System.Security.Cryptography/tests/X509Certificates/ExtensionsTests/AuthorityKeyIdentifierTests.cs @@ -477,7 +477,7 @@ public static void CreateFromLargeKeyIdentifier() byte[] rawData = akid.RawData; - AssertExtensions.SequenceEqual(keyId.AsSpan(), rawData.AsSpan(6)); + AssertExtensions.SequenceEqual(keyId, rawData.AsSpan(6)); Assert.Equal("308183808180", rawData.AsSpan(0, 6).ByteArrayToHex()); } diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs index 20cdf3775c0a43..dca61c889c89d8 100644 --- a/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs +++ b/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs @@ -381,7 +381,7 @@ internal MetadataDb CopySegment(int startIndex, int endIndex) byte[] newDatabase = new byte[length]; _data.AsSpan(startIndex, length).CopyTo(newDatabase); - Span newDbInts = MemoryMarshal.Cast(newDatabase.AsSpan()); + Span newDbInts = MemoryMarshal.Cast(newDatabase); int locationOffset = newDbInts[0]; // Need to nudge one forward to account for the hidden quote on the string. diff --git a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Memory.cs b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Memory.cs index b99428c39c7d6c..58525300624be0 100644 --- a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Memory.cs +++ b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Memory.cs @@ -34,7 +34,7 @@ public async Task SerializeReadOnlyMemoryOfTAsync() public async Task DeserializeMemoryOfTAsync() { Memory memoryInt = await Serializer.DeserializeWrapper>("[1,2,3]"); - AssertExtensions.SequenceEqual(new int[] { 1, 2, 3 }.AsSpan(), memoryInt.Span); + AssertExtensions.SequenceEqual(new int[] { 1, 2, 3 }, memoryInt.Span); Memory memoryPoco = new EmptyClass[] { new(), new(), new() }.AsMemory(); Assert.Equal(3, memoryPoco.Length); @@ -75,7 +75,7 @@ public async Task DeserializeMemoryOfTClassAsync() { string json = @"{""Memory"":[1,2,3]}"; MemoryOfTClass memoryOfIntClass = await Serializer.DeserializeWrapper>(json); - AssertExtensions.SequenceEqual(new int[] { 1, 2, 3 }.AsSpan(), memoryOfIntClass.Memory.Span); + AssertExtensions.SequenceEqual(new int[] { 1, 2, 3 }, memoryOfIntClass.Memory.Span); } [Fact] @@ -97,7 +97,7 @@ public async Task SerializeMemoryByteAsync() public async Task DeserializeMemoryByteAsync() { Memory memory = await Serializer.DeserializeWrapper>("\"VGhpcyBpcyBzb21lIHRlc3QgZGF0YSEhIQ==\""); - AssertExtensions.SequenceEqual(s_testData.AsSpan(), memory.Span); + AssertExtensions.SequenceEqual(s_testData, memory.Span); ReadOnlyMemory readOnlyMemory = await Serializer.DeserializeWrapper>("\"VGhpcyBpcyBzb21lIHRlc3QgZGF0YSEhIQ==\""); AssertExtensions.SequenceEqual(s_testData, readOnlyMemory.Span); @@ -135,7 +135,7 @@ public async Task DeserializeMemoryByteClassAsync() string json = @"{""Memory"":""VGhpcyBpcyBzb21lIHRlc3QgZGF0YSEhIQ==""}"; MemoryOfTClass memoryOfByteClass = await Serializer.DeserializeWrapper>(json); - AssertExtensions.SequenceEqual(s_testData.AsSpan(), memoryOfByteClass.Memory.Span); + AssertExtensions.SequenceEqual(s_testData, memoryOfByteClass.Memory.Span); } } } diff --git a/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs b/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs index c1a704287c87be..feca0c535edf97 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs @@ -85,7 +85,9 @@ public async Task TopLevelStatements(InvocationType invocationType) string test = @"using System.Text.RegularExpressions; var isMatch = [|" + ConstructRegexInvocation(invocationType, pattern: "\"\"") + @"|]" + isMatchInvocation + ";"; string fixedCode = @"using System.Text.RegularExpressions; -var isMatch = MyRegex().IsMatch(""""); partial class Program +var isMatch = MyRegex().IsMatch(""""); + +partial class Program { [GeneratedRegex("""")] private static partial Regex MyRegex(); @@ -848,7 +850,9 @@ public async Task TopLevelStatements_MultipleSourceFiles() }, FixedState = { - Sources = { "public class C { }", @"var r = MyRegex(); partial class Program + Sources = { "public class C { }", @"var r = MyRegex(); + +partial class Program { [System.Text.RegularExpressions.GeneratedRegex("""")] private static partial System.Text.RegularExpressions.Regex MyRegex(); diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs index f46a06eb2debcf..b59683325cdf0d 100644 --- a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs +++ b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs @@ -63,7 +63,6 @@ public static IEnumerable IteratorWithCorrectDataflow () t_IteratorWithCorrectDataflow.RequiresAll (); } - [UnexpectedWarning ("IL2062", Tool.Trimmer | Tool.NativeAot, "https://github.com/dotnet/runtime/issues/110553", CompilerGeneratedCode = true)] public static IEnumerable IteratorWithIntegerDataflow () { int integerLocal = 0; From bfcf50aa8950b6809f94446d6a5a8c3ad7ce9460 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Wed, 3 Dec 2025 11:48:03 -0800 Subject: [PATCH 14/21] Don't use toolset compiler package --- eng/Versions.props | 2 -- 1 file changed, 2 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index 093ba9c212e6a3..651fd6074a53af 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -28,8 +28,6 @@ true true - - true From 3269af0e5723f1cd3fdddc54aaebbbbc09d379d4 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Wed, 3 Dec 2025 13:58:45 -0800 Subject: [PATCH 15/21] Add back prebuilt baseline --- eng/SourceBuildPrebuiltBaseline.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/eng/SourceBuildPrebuiltBaseline.xml b/eng/SourceBuildPrebuiltBaseline.xml index 4185d755fa6129..296c7a7f4b81df 100644 --- a/eng/SourceBuildPrebuiltBaseline.xml +++ b/eng/SourceBuildPrebuiltBaseline.xml @@ -35,5 +35,18 @@ + + + + + + + + + + + + From 1fb69f895ed2502f3af1b7d9463bf7cfea771f9e Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Wed, 3 Dec 2025 17:28:06 -0800 Subject: [PATCH 16/21] Add back attribute for new warning --- .../DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs index b59683325cdf0d..f46a06eb2debcf 100644 --- a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs +++ b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs @@ -63,6 +63,7 @@ public static IEnumerable IteratorWithCorrectDataflow () t_IteratorWithCorrectDataflow.RequiresAll (); } + [UnexpectedWarning ("IL2062", Tool.Trimmer | Tool.NativeAot, "https://github.com/dotnet/runtime/issues/110553", CompilerGeneratedCode = true)] public static IEnumerable IteratorWithIntegerDataflow () { int integerLocal = 0; From 247d9c969727500229b84ebc3a7308d132eb024d Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Thu, 4 Dec 2025 10:17:02 -0800 Subject: [PATCH 17/21] Fix test analyzer reference --- .../ILLink.RoslynAnalyzer.Tests.Generator.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj b/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj index 095efe39a63b9a..17489190fc16b5 100644 --- a/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj +++ b/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj @@ -6,7 +6,7 @@ - + From 98fc9240585f297f1834ba312a0535331c8ee6d4 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Thu, 4 Dec 2025 10:24:38 -0800 Subject: [PATCH 18/21] Fix CustomMarshaller tests --- ...ttributeFixerTests_StatefulLinearCollectionShapeValidation.cs | 1 - ...MarshallerAttributeFixerTests_StatefulValueShapeValidation.cs | 1 - ...tributeFixerTests_StatelessLinearCollectionShapeValidation.cs | 1 - ...arshallerAttributeFixerTests_StatelessValueShapeValidation.cs | 1 - 4 files changed, 4 deletions(-) diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs index 2aedfde9936f47..eb60cf353dbcce 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs @@ -602,7 +602,6 @@ public void FromManaged(ManagedType m, Span buffer) {} public void Free() {} public ReadOnlySpan GetManagedValuesSource() => default; public Span GetUnmanagedValuesDestination() => default; - public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs index 9a72a5fbc4916f..cb2c5d8caf10ec 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs @@ -382,7 +382,6 @@ public void FromManaged(ManagedType m, Span b) {} public int ToUnmanaged() => default; public void Free() {} - public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs index fec16b2bc7ff7c..b60bb78f2acc2b 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs @@ -614,7 +614,6 @@ static class MarshallerType public static ReadOnlySpan GetManagedValuesSource(ManagedType m) => default; public static Span GetUnmanagedValuesDestination(nint unmanaged, int numElements) => default; - public static int BufferSize { get diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs index 7d94afb9985f79..35c90af32f81b2 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs @@ -363,7 +363,6 @@ class ManagedType {} static class MarshallerType { public static nint ConvertToUnmanaged(ManagedType m, Span b) => default; - public static int BufferSize { get From 739e3f714925498bf2d8a6824dda6462a90cac2b Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Thu, 4 Dec 2025 10:30:53 -0800 Subject: [PATCH 19/21] Fix RegularExpressions tests --- .../UpgradeToGeneratedRegexAnalyzerTests.cs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs b/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs index feca0c535edf97..c1a704287c87be 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs @@ -85,9 +85,7 @@ public async Task TopLevelStatements(InvocationType invocationType) string test = @"using System.Text.RegularExpressions; var isMatch = [|" + ConstructRegexInvocation(invocationType, pattern: "\"\"") + @"|]" + isMatchInvocation + ";"; string fixedCode = @"using System.Text.RegularExpressions; -var isMatch = MyRegex().IsMatch(""""); - -partial class Program +var isMatch = MyRegex().IsMatch(""""); partial class Program { [GeneratedRegex("""")] private static partial Regex MyRegex(); @@ -850,9 +848,7 @@ public async Task TopLevelStatements_MultipleSourceFiles() }, FixedState = { - Sources = { "public class C { }", @"var r = MyRegex(); - -partial class Program + Sources = { "public class C { }", @"var r = MyRegex(); partial class Program { [System.Text.RegularExpressions.GeneratedRegex("""")] private static partial System.Text.RegularExpressions.Regex MyRegex(); From 81eefc39ee72f43e2c4079613956084b46c0f9c1 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Wed, 10 Dec 2025 02:04:24 +0000 Subject: [PATCH 20/21] Update dependencies from https://github.com/dotnet/roslyn build 20251209.6 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25569.8 -> To Version 4.14.0-3.25609.6 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25609.6 --- eng/Version.Details.xml | 20 ++++++++++---------- eng/Versions.props | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 504ab1e57bd181..c70843b3364ab0 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -360,30 +360,30 @@ https://github.com/dotnet/runtime-assets 91ea918f8fb26ec1d290283e5c5eeb1b003113da - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 369b11e3228ac1d246dbd5f309f967992d5c59f1 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 369b11e3228ac1d246dbd5f309f967992d5c59f1 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 369b11e3228ac1d246dbd5f309f967992d5c59f1 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 369b11e3228ac1d246dbd5f309f967992d5c59f1 https://github.com/dotnet/roslyn-analyzers 16865ea61910500f1022ad2b96c499e5df02c228 - + https://github.com/dotnet/roslyn - 8cafac4760a78176ef0e167bea66b97b65437930 + 369b11e3228ac1d246dbd5f309f967992d5c59f1 diff --git a/eng/Versions.props b/eng/Versions.props index 651fd6074a53af..144aec91ed9005 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -34,7 +34,7 @@ - 3.12.0-beta1.25570.7 + 3.12.0-beta1.25609.6 9.0.0-preview.25173.3 - 4.14.0-3.25570.7 - 4.14.0-3.25570.7 - 4.14.0-3.25570.7 + 4.14.0-3.25609.6 + 4.14.0-3.25609.6 + 4.14.0-3.25609.6 - + https://github.com/dotnet/roslyn - 369b11e3228ac1d246dbd5f309f967992d5c59f1 + 44b81fc54139e9fce040efc2a6558110c038896b diff --git a/eng/Versions.props b/eng/Versions.props index 144aec91ed9005..1a5f1eab58e14c 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -34,7 +34,7 @@ - 3.12.0-beta1.25609.6 + 3.12.0-beta1.25609.16 9.0.0-preview.25173.3 - 4.14.0-3.25609.6 - 4.14.0-3.25609.6 - 4.14.0-3.25609.6 + 4.14.0-3.25609.16 + 4.14.0-3.25609.16 + 4.14.0-3.25609.16