Magit status did not refresh after with-editor-finish

[chenyanming]

As the title mentioned, after with-editor-finish or push, I have to run magit-refresh-all to refresh

After with-editor-finish or push, the page does not change:

Run magit-refresh-all (which is not supposed to run this command)

I used gptel branch, with default setting, no additional settings. Emacs 30, both mac and linux are same behavior.

[douo]

Did you commit through magit-gptcommit-commit-create? I reviewed the relevant code but couldn’t find any clues suggesting that magit-gptcommit would cause this issue, and I couldn’t reproduce it on my end.

All magit-gptcommit does is replace the generated message in the COMMIT_EDITMSG buffer via git-commit-setup-hook. You can check magit-gptcommit-commit-accept for details.

[chenyanming]

Both magit-gptcommit-commit-create (cC) or normal magit commit (cc). The problem exists if magit-gptcommit-mode is enable. I have to disable magit-gptcommit to make it back to normal. It is wired through.

[avishefi]

What versions of magit and gptel are you using?

[chenyanming]

Sorry I can not check it now, but I guess they are the lastest. Since I try to delete magit and gptel repo and clone again, it is the same.

[LemonBreezes]

Did you commit through magit-gptcommit-commit-create? I reviewed the relevant code but couldn’t find any clues suggesting that magit-gptcommit would cause this issue, and I couldn’t reproduce it on my end.

All magit-gptcommit does is replace the generated message in the COMMIT_EDITMSG buffer via git-commit-setup-hook. You can check magit-gptcommit-commit-accept for details.

What is happening is that we are setting magit-inhibit-refresh to t in magit-gptcommit--insert. That hack needs to be removed and the issue it's working around needs to be fixed another way.

[LemonBreezes]

Hey @chenyanming @avishefi if you can please test my PR #28 which fixes this issue.