Saving model with auto-fetched relations causes stack overflow

[dirkmc]

If a model has autoFetch true, and you fetch the model then try to save it, Node reports:

RangeError: Maximum call stack size exceeded
2 Aug 19:22:00 - [nodemon] app crashed - waiting for file changes before starting...

If the auto-fetched field is overwritten it saves ok:

db.Post.get(1337, function(e,p) {
    p.user = null;
    p.channel = null;
    p.template = null;
    p.save({ updated_at: new Date() }, function(err) {
        console.log('done')
    });
});

[dresende]

Please tell use node version, orm version.

[dirkmc]

This is with the latest version of orm on the master branch

mac> node --version
v0.10.12

[dirkmc]

In Instance.js I added some debugging output so that it looks like this:

var saveInstance = function (cb, saveOptions) {
    console.log('------------')
    handleValidations(function (err) {
        if (err) {
            return saveError(cb, err);
        }

        if (opts.is_new) {
            waitHooks([ "beforeCreate", "beforeSave" ], function (err) {
                if (err) {
                    return saveError(cb, err);
                }

                return saveNew(cb, saveOptions, getInstanceData());
            });
        } else {
            waitHooks([ "beforeSave" ], function (err) {
                if (err) {
                    return saveError(cb, err);
                }

                console.log(opts.table, opts.data.id)
                console.log(opts.changes);

                if (opts.changes.length === 0) {
                    console.log('saving associations')
                    return saveAssociations(function (err) {
                        return afterSave(cb, false, err);
                    });
                }
                    console.log('saving persisted')

                return savePersisted(cb, saveOptions, getInstanceData());
            });
        }
    });
};

Is this line correct?

                if (opts.changes.length === 0) {

This is the console output:

    ...
------------
users 1
[]
saving associations
------------
posts 1337
[]
saving associations
------------
users 1
[]
saving associations
------------
posts 1337
[]
saving associations
------------
users 1
[]
saving associations
------------
posts 1337
[]
saving associations
------------
users 1
[]
saving associations

RangeError: Maximum call stack size exceeded

In my definitions I have this:

models.User = db.define("users", {
    // ...
}, {
    autoFetch: true,
    autoFetchLimit: 1,

models.Post = db.define("posts", {
    // ...
}, {
    autoFetch: true,
    autoFetchLimit: 1,

// ...
models.Post.hasOne("user", models.User);
models.Post.hasOne("channel", models.Channel);
models.Post.hasOne("template", models.Template);

models.User.hasMany("channels", models.Channel, {
    // ...
}, {
    reverse: "users", // Other side of many-to-many
    mergeTable: "subscriptions",
    mergeId: "user_id",
    mergeAssocId: "channel_id"
});

[goulwenlorcy]

Hello, I have the same problem with a simple code (latest version of orm & node v0.8.9)

            this.models.permissions.get(uid, function (err, item) {
               item.save(arg, function (err) {     
                     /* ... */
                });               
            });

Node crash with:

RangeError: Maximum call stack size exceeded

Without autoFetch, it works.

[notheotherben]

@goulwenlorcy would you be able to test with v2.0.15 of ORM and tell us whether it has the same issue there? Just trying to narrow down where the issue may have crept in.

[goulwenlorcy]

With the v2.0.15, I haven't the crash error but it doesn't work and the /* ... */ part is executed 2 times.

[dresende]

This line (and subsequent scope)..

 if (opts.changes.length === 0) {

.. was added by me to try to solve the double call to .save(). Not sure how it happened. It makes the workflow continue if there are no changes (avoiding calling UPDATE on the model but continue to check associations).

[dresende]

@goulwenlorcy please post a complete example. I cannot reproduce your error..

[dirkmc]

Here's a complete example:

app.use(orm.express(Config.db.uri, {
    define: function (db, models) {
        models.User = db.define("users", {
            email: String
        });

        models.Post = db.define("posts", {
            context: String
        }, {
            // If I comment out this line it works
            autoFetch: true
        });

        models.Post.hasOne("user", models.User);

        models.Post.get(1337, function(e,p) {
            // If I uncomment this line it works
            // p.user = null;
            p.save({ updated_at: new Date() }, function(err) {
                console.log('done')
            });
        });
    }
}));

This produces a stack overflow error:

RangeError: Maximum call stack size exceeded

[dresende]

Please try v2.1.0 and tell us if the same happens.

[petrovi4]

I have same bug in v2.1.0

[dirkmc]

Hi, I'm afraid I see the same bug also. Diogo are you not able to repro with the code I pasted above?

[dxg]

I've reproduced it, going to add a failing test case in a moment

[notheotherben]

Just a heads up - the test runner is currently not running test. I've fixed it in my repo (2e50cf2) which I'm planning on merging as soon as I can get a free minute to make Travis pass all tests. (Having issues with the SQLite driver, but ORM itself is working correctly)