Fix for saving of Instance.extra fields.#312
Merged
dresende merged 1 commit intodresende:masterfrom Aug 26, 2013
Merged
Conversation
Collaborator
|
Ah, well spotted. Looks good to merge, let's see what @dresende has to say - but good with me. |
Owner
|
Thank you! :) |
dresende
added a commit
that referenced
this pull request
Aug 26, 2013
Fix for saving of Instance.extra fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an extra value in a to-many relationship table has been changed, the saving logic breaks in the instance class. This fix worked for me. In the snippet I changed, opts.extra_info.id is an array containing the column names of each of the extra fields that need to be saved. I changed it so that instead of comparing the iterator variable i to the id array (which didn't make sense), you instead compare to the length of the array.