postgres: fix queries for prop create index, and for primary keys#377
Closed
kapouer wants to merge 1 commit intodresende:masterfrom
Closed
postgres: fix queries for prop create index, and for primary keys#377kapouer wants to merge 1 commit intodresende:masterfrom
kapouer wants to merge 1 commit intodresende:masterfrom
Conversation
Owner
|
I'm going to move DML part to an external module. I've done it, just need a few more checks. Change can then be done there. |
Contributor
Author
|
Really ? i found node-orm2 more appealing precisely because it bundles the drivers, |
Owner
|
Sorry, I meant DDL (database synching). I'm doing the move now to https://github.com/dresende/node-sql-ddl-sync |
Owner
|
The module is mine, so they will be kept on par. The difference is that in the module I and any contributors can focus on table synching (avoiding dropping table and recreating when a new property is needed). |
Contributor
Author
|
i understand, in fact i was afraid you were talking about splitting each database driver in its own module. |
Owner
|
I just made the PR #383, will merge it now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they were totally broken ;)