hasMany association properties not being checked#49
Merged
dresende merged 1 commit intodresende:masterfrom Feb 23, 2013
Merged
Conversation
Owner
|
Thank you :) |
dresende
added a commit
that referenced
this pull request
Feb 23, 2013
…-not-checked hasMany association properties not being checked
|
Changes Unknown when pulling b3e6325 on zachberry:issue/has-many-assoc-properties-not-checked into * on dresende:master*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(The following has been tested with the MySQL driver)
Consider the following hasMany relationship:
Now imagine
syncis invoked on all tables. In 2.0.2 price_paid works fine, however year_bought results in a value ofundefinedbeing passed for thepropargument inbuildColumnDefinition, and throws an error.I poked around and I think this is due to the fact that
Propertyscheckmethod is not transforming the types of anymany_associations. The attached code is a simple copy/paste job that duplicates the check code fromORM.prototype.defineinto theManyclass.This fix allows both of the additional properties for this association to sync correctly.
I can help if more is needed or this should be organized in a different manner.