hasMany sync() wrong column datatypes

[snovak7]

When I set custom key to a model, and make a hasMany relationship, the underlying table is incorrect. tried with version (excerpt from package.json -> "orm": "~2.1.10")

var Email = persistence.define('email', {
    id: {type: 'text', key: true},
    bounced: Boolean,
    last_checked: Date,
}); 

var Account = persistence.define('account', {
    name: String
});

Account.hasMany('email', Email); // or
Email.hasMany('account', Account);

I get these DDL commands for base tables

[SQL/postgres] CREATE TABLE "email" ("id" TEXT, "bounced" BOOLEAN, "last_checked" DATE, PRIMARY KEY ("id"))
[SQL/postgres] CREATE TABLE "account" ("name" TEXT, "id" SERIAL, "parent_id" INTEGER, "account_type_id" INTEGER, PRIMARY KEY ("id"))

and many to many table

[SQL/postgres] CREATE TABLE "account_email" ("account_id" TEXT, "email_id" INTEGER, PRIMARY KEY ("account_id"))

Two observations which I noticed is, that it reverses the datatype, and only one is primary key, both should be primary keys... no matter what datatype.

[dxg]

I've fixed the problem. It appears the issue was present for a long time.

It's on master - please test it by changing your package.json to:

"orm": "git://github.com/dresende/node-orm2.git#master",

As for primary keys - the single primary key was indeed a bug. By default ORM never created keys for join tables. Whilst this is somewhat unexpected behaviour, changing it might break things for people.

To get a composite primary key, you can define the association like so:

Account.hasMany('email', Email, {}, { key: true });