Merged
Conversation
…ng databases may've used zero as a valid entity identifier
…ng databases may've used zero as a valid entity identifier.
Collaborator
|
Looks good and makes sense, however the new tests are failing in postgres :( |
Author
|
Fixed for postgres....better check sqllite now. |
Author
|
Fixed it for postgres & sqlite wonder what's wrong for redshift. |
Author
|
Had to do a silly commit to force Travis to re-try the build. Seems ok now. |
Collaborator
|
👍 |
Collaborator
|
Released in v2.1.29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got a pre-existing database that started all its 'serial' IDs at zero...so I need to allow for Zero as a valid value for FK column in hasOne().
hasValues() is only used in hasOne association, so it's probably ok to make this change.