Skip to content

Suggestions #1

@matt-bailey

Description

@matt-bailey

Firstly thanks so much for this, it's saved me a whole lot of bother!

I have a couple of suggestions if that's ok?

The methods in the code example are incorrect. They should be:

  1. <action method="setFirstItem">, rather than <action method="setFirst">
  2. <action method="setLastItem">, rather than <action method="setLast">

Also, maybe this is obvious to other people, but it took me a bit of head-scratching to figure out that I still had to add my JS or CSS in the same way as well as using your code - i.e. your code doesn't actually load the assets, it just sets the order. So my code looks like this:

<action method="addJs"><script>[path]/[to]/myscript.js</script></action>
<action method="setFirstItem"><first>[path]/[to]/myscript.js</first></action>

Maybe it's worth mentioning this in the README, or expanding the example?

Thanks again :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions