Bug: Using `withComposedBased` doesn't work as expected

[MrYamous]

I'm currently upgrading a project using Rector and I'm in trouble with composer based configurations.

My project is in Laravel 11, I want to upgrade to Laravel 12.
In my composer.json, Laravel 12 is required.

If I run rector with this config, no file is changed :

    ->withPaths([
        __DIR__ . '/app',
        __DIR__ . '/bootstrap',
        __DIR__ . '/config',
        __DIR__ . '/public',
        __DIR__ . '/resources',
        __DIR__ . '/routes',
        __DIR__ . '/tests',
    ])
    ->withSetProviders(LaravelSetProvider::class)
    ->withComposerBased(laravel: true);

Then I change my config to :

    ->withPaths([
        __DIR__ . '/app',
        __DIR__ . '/bootstrap',
        __DIR__ . '/config',
        __DIR__ . '/public',
        __DIR__ . '/resources',
        __DIR__ . '/routes',
        __DIR__ . '/tests',
    ])
    ->withSets([LaravelLevelSetList::UP_TO_LARAVEL_120]);

And 8 files are changed.

This behavior looks wrong to me, as I'm expecting withComposerBased can detect my Laravel version and apply rules from UP_TO_LARAVEL_120 set list

[calebdw]

What rules specifically are being applied?

Try using this instead and let me know if there's still changes:

-    ->withSets([LaravelLevelSetList::UP_TO_LARAVEL_120]);
+    ->withSets([LaravelSetList::LARAVEL_120]);

The UP_TO_* rules includes everything from previous sets, not just what's on the laravel 12 upgrade list

[MrYamous]

What rules specifically are being applied?

Try using this instead and let me know if there's still changes:

• ->withSets([LaravelLevelSetList::UP_TO_LARAVEL_120]);

• ->withSets([LaravelSetList::LARAVEL_120]);
  The UP_TO_* rules includes everything from previous sets, not just what's on the laravel 12 upgrade list

Do you mean composerBased doesn't apply UP_TO_ rules ?

[calebdw]

Do you mean composerBased doesn't apply UP_TO_ rules ?

Exactly, it only applies the rules that are specific to that particular version (e.g., the Laravel 12.x rules). It is mainly intended for upgrade rules that should only be applied for that version (think renaming a particular property or method).

I recently PR'd rectorphp/rector-src#7877 to Rector, which we can use for some of the more useful code-style rules that may just have a particular minimum framework version requirement

[calebdw]

Closing as it looks like withComposerBased is correctly applying the correct 12.x rules. I will implement the other interface when I have the time