v1.2 - Figma commits to Github not mapping properly

[mgz513]

When testing out the new updates I started in Github by changing my xs spacing value from 4 to 24. When committed, it showed in Figma as expected. Now in Figma, I changed that same value from 24 back to 4, but the update would not render in Github. Its getting my commit messages, but it seems to be synced to the wrong json, as you can see my commits are showing up in colors instead of spacing. Basically, it seems that the sync is only working in 1 direction, which of course isn't ideal.

I then tried again to change the radius value in Figma from 9999 to 1000, and it again is mapping to colors instead of to spacing as it should. Lastly, when I updated the full radius value to 45 in Github, it went through to Figma - HOWEVER - it did not show up automatically. This sounds amazing in theory, but it may be best to keep a refresh button for pulls just in case auto doesnt work. There seems to be a timeout period. I wound up clicking pull anyway, despite there not being a notif, and only then did it recognize I had a commit to push. About 1 min later is when the pull button turned blue unprompted.

[mgz513]

I actually think I have found the issue/solution myself! The JSON values you provided in the design token start file are correct, but I somehow have them mixed together despite downloading from there?? You have a spacing.json and a color.json, but the values for spacing and radius are also included in the colors.json file. So the changes are happening, but because these values are listed in 2 places, its only updating them in one, Im assuming the top one, which is the values in the colors file. Very strange...

Im going to try removing/remapping the spacing/radius values from the colors.json and see if that fixes the mapping issues.

[ds1]

I appreciate all of the details with your setup and you pointing out areas of improvement. The manual refresh button is a great idea and revisiting the file mapping and provided files is something I'll prioritize too!

[mgz513]

OK, something weird is happening on the plugin side.

I went back to the provided jsons and copy/pasted your starter values into my repo. Only colors were in the color file, and only spacing was in the spacing file (i skipped adding type). Same in Figma. However, when I try to push a commit from Figma into github, it ADDS these values into my code! For instance, what was at first 76 lines of spacing/radius only code, turned into 161 lines of code, adding text and background colors into my spacing specific file. In my colors file, it also added the spacing and radius values inside of there.

IDK whats causing this but hoping my account will help you get to the bottom of it! I dont want Figma adding anything to the code I havent purposefully done myself and vice versa. @ds1

[mgz513]

@ds1 any updates on this issue^^?