From b076f3442500d17f6360d193ea1377df89d22a2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Dinis=20Ferreira?= Date: Sat, 4 Apr 2026 14:22:43 +0200 Subject: [PATCH] chore: remove unnecessary @SuppressWarnings annotations Remove @SuppressWarnings that are no longer needed: - "removal" on XtextBuildTrigger (no removal-deprecated API used) - "restriction" on CheckBatchLinkableResource, AbstractAcfContentAssistTest, AbstractGeneratorTest (no restricted API access) - "unchecked" on CheckContextsGenerator, ClassRunner, XtextClassRunner, AbstractFingerprintComputer, AbstractStreamingFingerprintComputer (no unchecked casts present) Co-Authored-By: Claude Opus 4.6 (1M context) --- .../tools/ddk/check/resource/CheckBatchLinkableResource.java | 1 - .../tools/ddk/check/ui/builder/CheckContextsGenerator.java | 1 - .../avaloq/tools/ddk/test/core/junit/runners/ClassRunner.java | 1 - .../tools/ddk/xtext/builder/layered/XtextBuildTrigger.java | 2 +- .../xtext/test/contentassist/AbstractAcfContentAssistTest.java | 1 - .../tools/ddk/xtext/test/generator/AbstractGeneratorTest.java | 2 +- .../tools/ddk/xtext/test/junit/runners/XtextClassRunner.java | 1 - .../ddk/xtext/test/jupiter/AbstractAcfContentAssistTest.java | 1 - .../tools/ddk/xtext/resource/AbstractFingerprintComputer.java | 1 - .../xtext/resource/AbstractStreamingFingerprintComputer.java | 1 - 10 files changed, 2 insertions(+), 10 deletions(-) diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/resource/CheckBatchLinkableResource.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/resource/CheckBatchLinkableResource.java index 7e44dad8ba..2693425345 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/resource/CheckBatchLinkableResource.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/resource/CheckBatchLinkableResource.java @@ -49,7 +49,6 @@ public InputStream createInputStream(final URI uri, final Map options) thr }; } - @SuppressWarnings("restriction") @Override public void load(final Map options) throws IOException { modelLocation = (IModelLocation) options.get(MAYBE_LOCATION_DATA); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java index e68a2ed1fb..ff23bcfca0 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckContextsGenerator.java @@ -172,7 +172,6 @@ private CtxHelpContext createContextForCheck(final CtxHelpDocumentFactory factor * @throws CoreException * the core exception */ - @SuppressWarnings("unchecked") public void removeContexts(final Delta delta) throws CoreException { final IProject project = RuntimeProjectUtil.getProject(delta.getUri(), mapper); if (project != null) { diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/ClassRunner.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/ClassRunner.java index 60074e5ac4..fabcf58c8f 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/ClassRunner.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/junit/runners/ClassRunner.java @@ -100,7 +100,6 @@ public class ClassRunner extends BlockJUnit4ClassRunner { public static final String PROPERTY_UNSTABLE_FAIL = "com.avaloq.test.unstablefail"; //$NON-NLS-1$ /** Class-wide logger. */ private static final Logger LOGGER = LogManager.getLogger(ClassRunner.class); - @SuppressWarnings("unchecked") private static final List> TEST_ANNOTATIONS = Lists.newArrayList(Test.class, UnitTest.class, ModuleTest.class, IntegrationTest.class, SystemTest.class, PerformanceTest.class, BugTest.class); private List expectedMethods; private int currentMethodIndex; diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/layered/XtextBuildTrigger.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/layered/XtextBuildTrigger.java index 27c181fe27..27d648c6b1 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/layered/XtextBuildTrigger.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/layered/XtextBuildTrigger.java @@ -21,7 +21,7 @@ /** * Build trigger that actually does trigger a full build. Assumes we have a {@link IWorkspace} and a {@link BuildScheduler}. */ -@SuppressWarnings({"deprecation", "removal"}) +@SuppressWarnings("deprecation") public class XtextBuildTrigger implements IXtextBuildTrigger { @Inject diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/contentassist/AbstractAcfContentAssistTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/contentassist/AbstractAcfContentAssistTest.java index 569fc457e7..33bb772e92 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/contentassist/AbstractAcfContentAssistTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/contentassist/AbstractAcfContentAssistTest.java @@ -188,7 +188,6 @@ protected void assertExactlyCompletionProposal(final ICompletionProposal[] compu * @param sourceFileName * the filename of the test source that the proposals were to be computed from, must not be {@code null} */ - @SuppressWarnings("restriction") private void assertSourceProposals(final String sourceFileName) { try { AcfContentAssistProcessorTestBuilder builder = newBuilder().append(getTestSource(sourceFileName).getContent()); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java index 1877aebb2f..01165a2a3c 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/generator/AbstractGeneratorTest.java @@ -60,7 +60,7 @@ /** * A base class for xtext generator tests. Allows creating a project and adding files. */ -@SuppressWarnings({"PMD.AbstractClassWithoutAbstractMethod", "restriction", "nls"}) +@SuppressWarnings({"PMD.AbstractClassWithoutAbstractMethod", "nls"}) public abstract class AbstractGeneratorTest { private static final String MESSAGE_GENERATED_FILE_MUST_EXIST = "Generated file ''{0}'' must exist."; private static final String MESSAGE_GENERATED_CODE_MUST_BE_CORRECT = "Generated contents of ''{0}'' must be correct."; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/junit/runners/XtextClassRunner.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/junit/runners/XtextClassRunner.java index b616167c5c..7124d8f2e3 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/junit/runners/XtextClassRunner.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/junit/runners/XtextClassRunner.java @@ -101,7 +101,6 @@ public class XtextClassRunner extends XtextRunner { public static final String PROPERTY_UNSTABLE_FAIL = "com.avaloq.test.unstablefail"; //$NON-NLS-1$ /** Class-wide logger. */ private static final Logger LOGGER = LogManager.getLogger(XtextClassRunner.class); - @SuppressWarnings("unchecked") private static final List> TEST_ANNOTATIONS = Lists.newArrayList(Test.class, UnitTest.class, ModuleTest.class, IntegrationTest.class, SystemTest.class, PerformanceTest.class, BugTest.class); private List expectedMethods; private int currentMethodIndex; diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractAcfContentAssistTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractAcfContentAssistTest.java index aa945db99f..e0f0f9794c 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractAcfContentAssistTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractAcfContentAssistTest.java @@ -187,7 +187,6 @@ protected void assertExactlyCompletionProposal(final ICompletionProposal[] compu * @param sourceFileName * the filename of the test source that the proposals were to be computed from, must not be {@code null} */ - @SuppressWarnings("restriction") private void assertSourceProposals(final String sourceFileName) { try { AcfContentAssistProcessorTestBuilder builder = newBuilder().append(getTestSource(sourceFileName).getContent()); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractFingerprintComputer.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractFingerprintComputer.java index 8abc20beb8..3c49e9c1d9 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractFingerprintComputer.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractFingerprintComputer.java @@ -517,7 +517,6 @@ protected ExportItem fingerprintRef(final EObject obj, final EReference ref, fin * the URIs or by calling a generated function, must not be {@code null} * @return the fingerprint */ - @SuppressWarnings("unchecked") protected ExportItem fingerprintExpr(final Object obj, final EObject context, final FingerprintOrder order, final FingerprintIndirection indirection) { if (obj instanceof EObject) { if (indirection == FingerprintIndirection.INDIRECT) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractStreamingFingerprintComputer.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractStreamingFingerprintComputer.java index fa69529426..bf9223d127 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractStreamingFingerprintComputer.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractStreamingFingerprintComputer.java @@ -456,7 +456,6 @@ protected void fingerprintRef(final EObject obj, final EReference ref, final Fin * @param hasher * hasher to stream to */ - @SuppressWarnings("unchecked") protected void fingerprintExpr(final Object obj, final EObject context, final FingerprintOrder order, final FingerprintIndirection indirection, final Hasher hasher) { if (obj instanceof EObject) { if (indirection == FingerprintIndirection.INDIRECT) {