-
Notifications
You must be signed in to change notification settings - Fork 26
Correct the CTS output generated by multivariate MODE #3329
Copy link
Copy link
Open
Labels
MET: Object VerificationObject-based feature VerificationObject-based feature Verificationalert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuepriority: highHigh PriorityHigh Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: enhancementImprove something that it is currently doingImprove something that it is currently doing
Milestone
Metadata
Metadata
Assignees
Labels
MET: Object VerificationObject-based feature VerificationObject-based feature Verificationalert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuepriority: highHigh PriorityHigh Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: enhancementImprove something that it is currently doingImprove something that it is currently doing
Type
Projects
Status
🩺 Needs Triage
Describe the Enhancement
While working on issue #3286, I ran across unexpected output generated by multivariate MODE. I'd originally planned to fix it on the same issue but found it to be rather involved. I'm splitting that work out into this new issue to be addressed for the MET-13.0.0 beta2 development cycle.
There are 2 problems in multivariate MODE which will likely be fixed by the same change to the logic. For multivariate MODE, the super object field is currently filled with bad data at most grid points or 0 for the superobject grid points. This structure of the data leads to issues in the contingency table counts/statistics and the PostScript plots.
Check the
TOTALcolumn of the multivariate MODE CTS output lines. That value should be roughly the number of points in the grid (e.g. Nx*Ny) minus any grid points containing bad data in the input. However, it's currently the number of grid points which are included in both the fcst and obs super objects. This is an artifact of how the data for the super objects is stored.Similarly, when
plot_valid_flag = TRUEand no intensity comparisons are requested, the PostScript output from multivariate MODE is zoomed up to only contain the grid points falling inside the super objects. This is also an artifact of how the data for the super objects is stored.Recommend revisiting and updating the logic as needed so that the CTS counts/statistics and PostScript plots generated by multivariate MODE are consistent with those generated by traditional MODE.
Consider keeping track of the grid points which contain valid data for ALL the input fields and using that to define how
plot_valid_flag = TRUEshould be handled when no intensity comparisons are requested.Time Estimate
Unknown
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>Pull request:
feature <Issue Number> <Description>Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y Development project for development toward the next coordinated release