Extract WebViewCompat test logic to another class

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -181,8 +181,6 @@ import com.duckduckgo.app.browser.webshare.WebShareChooser
 import com.duckduckgo.app.browser.webshare.WebViewCompatWebShareChooser
 import com.duckduckgo.app.browser.webview.WebContentDebugging
 import com.duckduckgo.app.browser.webview.WebViewBlobDownloadFeature
-import com.duckduckgo.app.browser.webview.WebViewCompatFeature
-import com.duckduckgo.app.browser.webview.WebViewCompatFeatureSettings
 import com.duckduckgo.app.browser.webview.safewebview.SafeWebViewFeature
 import com.duckduckgo.app.cta.ui.BrokenSitePromptDialogCta
 import com.duckduckgo.app.cta.ui.Cta
@@ -330,7 +328,7 @@ import com.duckduckgo.savedsites.api.models.SavedSitesNames
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksBottomSheetDialog
 import com.duckduckgo.savedsites.impl.bookmarks.FaviconPromptSheet
 import com.duckduckgo.savedsites.impl.dialogs.EditSavedSiteDialogFragment
-import com.duckduckgo.serp.logos.api.SerpLogoScreens.*
+import com.duckduckgo.serp.logos.api.SerpLogoScreens.EasterEggLogoScreen
 import com.duckduckgo.serp.logos.api.SerpLogos
 import com.duckduckgo.site.permissions.api.SitePermissionsDialogLauncher
 import com.duckduckgo.site.permissions.api.SitePermissionsGrantedListener
@@ -344,8 +342,6 @@ import com.google.android.material.bottomsheet.BottomSheetBehavior
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
 import com.google.android.material.snackbar.BaseTransientBottomBar
 import com.google.android.material.snackbar.Snackbar
-import com.squareup.moshi.Moshi
-import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Job
 import kotlinx.coroutines.SupervisorJob
@@ -603,7 +599,7 @@ class BrowserTabFragment :
     lateinit var omnibarFeatureRepository: OmnibarFeatureRepository
 
     @Inject
-    lateinit var webViewCompatFeature: WebViewCompatFeature
+    lateinit var webViewCompatTestHelper: WebViewCompatTestHelper
 
     /**
      * We use this to monitor whether the user was seeing the in-context Email Protection signup prompt
@@ -3224,7 +3220,9 @@ class BrowserTabFragment :
                 onInContextEmailProtectionSignupPromptShown = { showNativeInContextEmailProtectionSignupPrompt() },
             )
             configureWebViewForBlobDownload(it)
-            configureWebViewForWebViewCompatTest(it)
+            lifecycleScope.launch {
+                webViewCompatTestHelper.configureWebViewForWebViewCompatTest(it)
+            }
             configureWebViewForAutofill(it)
             printInjector.addJsInterface(it) { viewModel.printFromWebView() }
             autoconsent.addJsInterface(it, autoconsentCallback)
@@ -3347,32 +3345,6 @@ class BrowserTabFragment :
         daxDialogIntroBubble.root.gone()
     }
 
-    private var proxy: JavaScriptReplyProxy? = null
-
-    private val delay = "\$DELAY$"
-    private val postInitialPing = "\$POST_INITIAL_PING$"
-    private val replyToNativeMessages = "\$REPLY_TO_NATIVE_MESSAGES$"
-
-    private fun configureWebViewForWebViewCompatTest(webView: DuckDuckGoWebView) {
-        lifecycleScope.launch(dispatchers.main()) {
-            val script = withContext(dispatchers.io()) {
-                if (!webViewCompatFeature.self().isEnabled()) return@withContext null
-
-                val moshi = Moshi.Builder().add(KotlinJsonAdapterFactory()).build()
-                val adapter = moshi.adapter(WebViewCompatFeatureSettings::class.java)
-                val webViewCompatSettings = webViewCompatFeature.self().getSettings()?.let {
-                    adapter.fromJson(it)
-                }
-                context?.resources?.openRawResource(R.raw.webviewcompat_test_script)?.bufferedReader().use { it?.readText() }.orEmpty()
-                    .replace(delay, webViewCompatSettings?.jsInitialPingDelay?.toString() ?: "0")
-                    .replace(postInitialPing, webViewCompatFeature.jsSendsInitialPing().isEnabled().toString())
-                    .replace(replyToNativeMessages, webViewCompatFeature.jsRepliesToNativeMessages().isEnabled().toString())
-            } ?: return@launch
-
-            webViewCompatWrapper.addDocumentStartJavaScript(webView, script, setOf("*"))
-        }
-    }
-
     @SuppressLint("AddDocumentStartJavaScriptUsage")
     private fun configureWebViewForBlobDownload(webView: DuckDuckGoWebView) {
         lifecycleScope.launch(dispatchers.main()) {

app/src/main/java/com/duckduckgo/app/browser/WebViewCompatTestHelper.kt

@@ -0,0 +1,66 @@
+/*
+ * Copyright (c) 2025 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.app.browser
+
+import com.duckduckgo.app.browser.webview.WebViewCompatFeature
+import com.duckduckgo.app.browser.webview.WebViewCompatFeatureSettings
+import com.duckduckgo.browser.api.webviewcompat.WebViewCompatWrapper
+import com.duckduckgo.common.utils.DispatcherProvider
+import com.duckduckgo.di.scopes.FragmentScope
+import com.squareup.anvil.annotations.ContributesBinding
+import com.squareup.moshi.Moshi
+import dagger.SingleInstanceIn
+import kotlinx.coroutines.withContext
+import javax.inject.Inject
+
+private const val delay = "\$DELAY$"
+private const val postInitialPing = "\$POST_INITIAL_PING$"
+private const val replyToNativeMessages = "\$REPLY_TO_NATIVE_MESSAGES$"
+
+interface WebViewCompatTestHelper {
+    suspend fun configureWebViewForWebViewCompatTest(webView: DuckDuckGoWebView)
+}
+
+@ContributesBinding(FragmentScope::class)
+@SingleInstanceIn(FragmentScope::class)
+class RealWebViewCompatTestHelper @Inject constructor(
+    private val dispatchers: DispatcherProvider,
+    private val webViewCompatFeature: WebViewCompatFeature,
+    private val webViewCompatWrapper: WebViewCompatWrapper,
+    moshi: Moshi,
+) : WebViewCompatTestHelper {
+
+    private val adapter = moshi.adapter(WebViewCompatFeatureSettings::class.java)
+
+    override suspend fun configureWebViewForWebViewCompatTest(webView: DuckDuckGoWebView) {
+        withContext(dispatchers.main()) {
+            val script = withContext(dispatchers.io()) {
+                if (!webViewCompatFeature.self().isEnabled()) return@withContext null
+
+                val webViewCompatSettings = webViewCompatFeature.self().getSettings()?.let {
+                    adapter.fromJson(it)
+                }
+                webView.resources?.openRawResource(R.raw.webviewcompat_test_script)?.bufferedReader().use { it?.readText() }.orEmpty()
+                    .replace(delay, webViewCompatSettings?.jsInitialPingDelay?.toString() ?: "0")
+                    .replace(postInitialPing, webViewCompatFeature.jsSendsInitialPing().isEnabled().toString())
+                    .replace(replyToNativeMessages, webViewCompatFeature.jsRepliesToNativeMessages().isEnabled().toString())
+            } ?: return@withContext
+
+            webViewCompatWrapper.addDocumentStartJavaScript(webView, script, setOf("*"))
+        }
+    }
+}