Replace the use of feature flags with the repository

Author: 0nko

app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

@@ -192,6 +192,7 @@ import com.duckduckgo.app.browser.model.BasicAuthenticationRequest
 import com.duckduckgo.app.browser.model.LongPressTarget
 import com.duckduckgo.app.browser.newtab.FavoritesQuickAccessAdapter
 import com.duckduckgo.app.browser.omnibar.OmnibarEntryConverter
+import com.duckduckgo.app.browser.omnibar.OmnibarFeatureRepository
 import com.duckduckgo.app.browser.omnibar.QueryOrigin
 import com.duckduckgo.app.browser.omnibar.QueryOrigin.FromAutocomplete
 import com.duckduckgo.app.browser.refreshpixels.RefreshPixelSender
@@ -488,6 +489,7 @@ class BrowserTabViewModel @Inject constructor(
     private val webViewCompatWrapper: WebViewCompatWrapper,
     private val addressBarTrackersAnimationFeatureToggle: AddressBarTrackersAnimationFeatureToggle,
     private val autoconsentPixelManager: AutoconsentPixelManager,
+    private val omnibarFeatureRepository: OmnibarFeatureRepository,
 ) : ViewModel(),
     WebViewClientListener,
     EditSavedSiteListener,
@@ -556,9 +558,7 @@ class BrowserTabViewModel @Inject constructor(
         get() = site?.title
 
     val isSplitOmnibarEnabled: Boolean by lazy {
-        androidBrowserConfig.useUnifiedOmnibarLayout().isEnabled() &&
-            androidBrowserConfig.splitOmnibar().isEnabled() &&
-            settingsDataStore.omnibarType == OmnibarType.SPLIT
+        omnibarFeatureRepository.isSplitOmnibarAvailable && settingsDataStore.omnibarType == OmnibarType.SPLIT
     }
 
     private var locationPermissionRequest: LocationPermissionRequest? = null

app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt

@@ -20,8 +20,6 @@ import com.duckduckgo.anvil.annotations.ContributesRemoteFeature
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.feature.toggles.api.Toggle
 import com.duckduckgo.feature.toggles.api.Toggle.DefaultFeatureValue
-import com.duckduckgo.feature.toggles.api.Toggle.DefaultFeatureValue.FALSE
-import com.duckduckgo.feature.toggles.api.Toggle.DefaultFeatureValue.TRUE
 
 /**
  * This is the class that represents the browser feature flags
@@ -181,10 +179,19 @@ interface AndroidBrowserConfigFeature {
     @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
     fun vpnMenuItem(): Toggle
 
-    @Toggle.DefaultValue(TRUE)
+    /**
+     * @return `true` when the remote config has the global "useUnifiedOmnibarLayout" androidBrowserConfig
+     * sub-feature flag enabled
+     * If the remote feature is not present defaults to `true`
+     */
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun useUnifiedOmnibarLayout(): Toggle
 
-    @Toggle.DefaultValue(FALSE)
-    @Toggle.InternalAlwaysEnabled
+    /**
+     * @return `true` when the remote config has the global "splitOmnibar" androidBrowserConfig
+     * sub-feature flag enabled
+     * If the remote feature is not present defaults to `false`
+     */
+    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
     fun splitOmnibar(): Toggle
 }