Make Config objects immutable #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up a fair bit of the logic in here, and safeguards us against potential bugs. It is however a technically-breaking change.
Collaborator
Author
|
Why is |
Owner
|
@nbraud I merged #249 - not sure what to do with this one since there's so much overlap between the two. |
Owner
|
Updated this to be based on the current codebase and use latest frozendict. There's some problems with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stepping stone towards making
Configbe a dataclass,so the new dependency on
frozendictmight not stay long.Piggy-backs on #249 (
Config.resolved: Major bugfix(es)) so please merge that first