Update scores and bonus points at turn end #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
changed the title
richpjames
force-pushed
the
update-answers-and-bonus-points-at-turn-end
branch
2 times, most recently
from
2f52410 to
80c4a2b
Compare
yndajas
commented
Aug 19, 2024
Member
Author
yndajas
left a comment
yndajas
left a comment
There was a problem hiding this comment.
Nice! We don't seem to be using the output yet, as far as I can tell, and we're still manually getting stuff on turnEnd - can we start using the output instead?
Also, the WIPs need removing from the commit messages
richpjames
force-pushed
the
update-answers-and-bonus-points-at-turn-end
branch
4 times, most recently
from
d3fddfe to
cc86dda
Compare
yndajas
commented
Aug 20, 2024
Member
Author
yndajas
left a comment
yndajas
left a comment
There was a problem hiding this comment.
Looking good! Mostly just a few suggestions, though there's one test assertion that needs fixing
richpjames
force-pushed
the
update-answers-and-bonus-points-at-turn-end
branch
from
cc86dda to
aeb9730
Compare
yndajas
commented
Aug 21, 2024
Member
Author
yndajas
left a comment
yndajas
left a comment
There was a problem hiding this comment.
Looking good. Just one thing about the git history, but otherwise I think it's good to go. Nice work!
(I can't approve it because I opened the PR)
Co-authored-by: Rich James <rich.james@dxw.com>
This is the correct way to output data from a machine when it reaches its final state. See docs: https://stately.ai/docs/final-states#output
richpjames
force-pushed
the
update-answers-and-bonus-points-at-turn-end
branch
from
aeb9730 to
be338ad
Compare
richpjames
approved these changes
Aug 21, 2024
The logic here is relatively complex so worthwhile testing. I have opted to only test the exported functions as the smaller, local ones are very simple. Co-authored-by: Rich James <rich.james@dxw.com>
This is just useful for logging to see if the interactions in the model are working as expected. Depending on the guard we will either play another turn or end the round.
richpjames
force-pushed
the
update-answers-and-bonus-points-at-turn-end
branch
from
be338ad to
1f086f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers some more of #180