Replies: 1 comment
-
|
We've been discussing this, and think that in order to properly fix visibility of exception classes in MSVC, we would need a breaking change where our base exception does not inherit from |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This discussion's intent is to define a better approach from symbols' visibility. It has sprouted from #88 and #89 by @roehling.
Important points to clarify would be:
std::exceptionwhich is not exported.For this case, Fix visibility of exception classes #88 proposed simply disabling the MSVC warnings, but does not seem like a solution to the problem either, so it was discarded.
-fvisibility=hiddenand-fvisibility-inlines-hiddenflags in GCC so that only the specified symbols are exported (similar to MSVC approach)Beta Was this translation helpful? Give feedback.
All reactions