Building Fast-CDR failed on windows using MinGW [13749]

[sky-fire]

I followed the instructions here, but when I tap this command: cmake --build . --target install, it failed,and the fail reason is : /usr/bin/windres:no resources

[MiguelCompany]

@sky-fire

It seems you are not building natively on windows, as /usr/bin/windres seems a linux-like path.

The instructions are for natively building on a system with Visual Studio installed.

So can you fully describe your build environment?

[LanceAZA]

I have the same problem by using MinGW in windows

[JLBuenoLopez]

MinGW is not an officially supported platform. I am moving the ticket to the corresponding discussion forum.

[felixf4xu]

This is actually a valid issue.

The error happens when building FastCdr as a static library, in that case fastcdr_EXPORTS is not defined, then

Fast-CDR/src/cpp/FastCdr.rc

Lines 86 to 121 in f889eee

	#if defined(fastcdr_EXPORTS)
	#ifndef _DEBUG
	#define VER_DEBUG 0
	#else
	#define VER_DEBUG VS_FF_DEBUG
	#endif // _DEBUG
	VS_VERSION_INFO VERSIONINFO
	FILEVERSION VER_PRODUCTVERSION
	PRODUCTVERSION VER_PRODUCTVERSION
	FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
	FILEFLAGS VER_DEBUG
	FILEOS VOS__WINDOWS32
	FILETYPE VFT_DLL
	FILESUBTYPE VFT2_UNKNOWN
	BEGIN
	BLOCK "StringFileInfo"
	BEGIN
	BLOCK "0c0a04b0"
	BEGIN
	VALUE "CompanyName", VER_COMPANYNAME_STR
	VALUE "FileDescription", VER_FILEDESCRIPTION_STR
	VALUE "FileVersion", VER_PRODUCTVERSION_STR
	VALUE "LegalCopyright", VER_LEGALCOPYRIGHT_STR
	VALUE "ProductName", VER_PRODUCTNAME_STR
	VALUE "ProductVersion", VER_PRODUCTVERSION_STR
	END
	END
	BLOCK "VarFileInfo"
	BEGIN
	VALUE "Translation", 0xc0a, 1200
	END
	END
	#endif

will be empty, that's why windres says:

no resources

[stefanct]

I can confirm felix' observations. I am also building fast-cdr by use of mingw as part of a bigger cmake project (plotjuggler) which defaults to building fast-cdr statically AFAICT. If I comment out the ifdef, the build of fast-cdr succeeds and an application linked to it can also be built successfully. So I agree with felix that this is an actual issue that would be nice to solve as it probably is also not correct for non-mingw builds (even though it might simply be ignored by the microsoft tools). The check was changed in e251dea by @richiware. I have no idea about resource files but if the whole file is not needed in static builds then the correct fix would be to not add it to ${PROJECT_NAME}_source_files in the cmake file if not building the shared lib.

I have submitted a PR that implements this fix: #259