consider limiting unit tests to specific paths changed in a pull request

[itcarroll]

earthaccess/.github/workflows/test.yml

Lines 4 to 8 in 68459a0

	push:
	branches:
	- main
	pull_request:
	types: [opened, synchronize]

The unit tests run for any pull request. If we use the paths key, we could limit it to changes that don't effect the earthaccess package (e.g. documentation changes). Is this considered a safe pratice?

I also don't understand why we run the unit tests on push ... isn't it too late by then!?

[betolink]

I agree with this, we should limit unit tests to code and perhaps the pyproject.toml

[mfisher87]

And the unit tests GHA Workflow file itself :)

Is this considered a safe pratice?

Yeah! We just need to be thoughtful about the paths.

I also don't understand why we run the unit tests on push ... isn't it too late by then!?

I think this is useful as a baseline to compare a unit test run on the main branch against a unit test run on a PR. At this point in time, we know the tests had this result. An informational tool rather than a preventative tool.