Skip to content

Bug: Function proxy_bridge.rs/mw_com_impl_initialize(...) doesnt compile for ARM #172

@TimofteBogdan1900

Description

@TimofteBogdan1900

Description

A patch is required to compile for ARM architecture because on aarch64 (ARM), C's char is unsigned (u8)

Error Occurrence Rate

None

How to reproduce

Try and compile communication for arm

Supporting Information

The patch is

--- a/score/mw/com/impl/rust/proxy_bridge.rs
+++ b/score/mw/com/impl/rust/proxy_bridge.rs
@@ -38,6 +38,7 @@
 mod ffi {
     use std::marker::PhantomData;
     use std::mem::transmute;
+    use std::os::raw::c_char;
 
     /// This type represents score::mw::com::InstanceSpecifier as an opaque struct.
     /// Note that this struct is empty as we only use references to it on Rust side.
@@ -133,7 +134,7 @@
             container: *const NativeHandleContainer,
             pos: u32,
         ) -> *const HandleType;
-        pub(super) fn mw_com_impl_initialize(options: *mut *const i8, len: i32);
+        pub(super) fn mw_com_impl_initialize(options: *mut *const c_char, len: i32);
         pub(super) fn mw_com_impl_sample_ptr_get_size() -> u32;
         pub(super) fn mw_com_impl_proxy_event_subscribe(
             proxy_event: *mut ProxyEventBase,

Its already fixed on main branch (commit b9efce9702d108fd63be806738db50c14d354302 ) but not in official release.

Classification

minor

Affected Version

0.5

Expected Closure Version

0.5

Category

  • Safety Related
  • Security Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingrust-api

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions