have shellcheck exclusions followed by rationale

Author: lurtz

scripts/create_builder.sh

@@ -25,8 +25,8 @@ check_proxy_config() {
 
 # Check if builder exists and has correct proxy configuration
 if docker buildx inspect multiarch &>/dev/null; then
-  # it is an optional rule, enabled via --enable all
   # shellcheck disable=SC2310
+  # it is an optional rule, enabled via --enable all
   if ! check_proxy_config; then
     echo "Builder 'multiarch' exists but has incorrect proxy configuration. Recreating..."
     docker buildx rm multiarch

src/s-core-devcontainer/.devcontainer/bazel-feature/install.sh

@@ -10,8 +10,8 @@ COPY_TARGET="${FEATURES_DIR}/$(basename "${SCRIPT_DIR%%_*}")"
 cp -R "${SCRIPT_DIR}" "${COPY_TARGET}"
 rm -f "${COPY_TARGET}/devcontainer-features.env" "${COPY_TARGET}/devcontainer-features-install.sh"
 
-# used by apt-get only inside this script
 # shellcheck disable=SC2034
+# used by apt-get only inside this script
 DEBIAN_FRONTEND=noninteractive
 
 # Read tool versions + metadata into environment variables

src/s-core-devcontainer/.devcontainer/bazel-feature/install_matching_bazel_version.sh

@@ -13,8 +13,8 @@ if [ -f .bazelversion ] && [ "$(cat .bazelversion)" != "${INSTALLED_BAZEL_VERSIO
         bash="bash"
     fi
 
-    # $bash might be empty and then an empty string is passed to the command, which will fail
     # shellcheck disable=SC2248
+    # without quotes is intentional: $bash might be empty and then an empty string is passed to the command, which will fail
     bazel help completion ${bash} > /tmp/bazel-complete.bash
     sudo mv /tmp/bazel-complete.bash /etc/bash_completion.d/bazel-complete.bash
     echo "INSTALLED_BAZEL_VERSION=${USE_BAZEL_VERSION}" | sudo tee /devcontainer/features/bazel/bazel_setup.sh

src/s-core-devcontainer/.devcontainer/s-core-local/install.sh

@@ -10,8 +10,8 @@ COPY_TARGET="${FEATURES_DIR}/$(basename "${SCRIPT_DIR%%_*}")"
 cp -R "${SCRIPT_DIR}" "${COPY_TARGET}"
 rm -f "${COPY_TARGET}/devcontainer-features.env" "${COPY_TARGET}/devcontainer-features-install.sh"
 
-# used by apt-get only inside this script
 # shellcheck disable=SC2034
+# used by apt-get only inside this script
 DEBIAN_FRONTEND=noninteractive
 
 # Read tool versions + metadata into environment variables